Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review75112 --- core/src/test/scala/unit/kafka/log/CleanerTest.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review75047 --- core/src/test/scala/unit/kafka/log/CleanerTest.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74992 --- Ship it! Ship It! - Mayuresh Gharat On Feb. 26, 2015, 6:54 p.m.,

Re: Review Request 31306: Patch for KAFKA-1755

> On March 3, 2015, 5:43 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 413 > > > > > > This will mean that if there are unkeyed messages we will neglect them > > and not throw a

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74986 --- core/src/main/scala/kafka/log/LogCleaner.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74985 --- Ship it! Ship It! - Guozhang Wang On Feb. 26, 2015, 6:54 p.m., J

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74329 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- (Updated Feb. 26, 2015, 6:54 p.m.) Review request for kafka. Bugs: KAFKA-1755

Re: Review Request 31306: Patch for KAFKA-1755

> On Feb. 26, 2015, 3:23 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 205 > > > > > > Can we add the key-validation logic into analyzeAndValidateMessageSet()? No -

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74201 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73692 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- (Updated Feb. 23, 2015, 10:29 p.m.) Review request for kafka. Bugs: KAFKA-175

Re: Review Request 31306: Patch for KAFKA-1755

> On Feb. 23, 2015, 7:05 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 209 > > > > > > In doing !compactedTopic here I'm forcing iteration over the messages > > below.

Re: Review Request 31306: Patch for KAFKA-1755

> On Feb. 23, 2015, 6:36 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 221 > > > > > > We may also need to check this right: > > sourceCodec != NoCompressionCod

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73629 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73618 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31306: Patch for KAFKA-1755

> On Feb. 23, 2015, 5:08 p.m., Neha Narkhede wrote: > > It also makes a lot of sense to disallow setting a compacted topic to > > uncompacted and vice versa without deleting the topic. Was there a reason > > to not include that change here or are you planning on including it in your > > follow

Re: Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review73584 --- It also makes a lot of sense to disallow setting a compacted topic t

Review Request 31306: Patch for KAFKA-1755

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- Review request for kafka. Bugs: KAFKA-1755 https://issues.apache.org/jira/b