Re: Review Request 31893: Patch for KAFKA-2013

> On March 31, 2015, 11:47 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala, line 261 > > > > > > Could we just put FakeOperation to the delayQueue directly instead of > > wrappi

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- (Updated April 1, 2015, 12:31 a.m.) Review request for kafka. Bugs: KAFKA-201

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/#review76975 --- Thanks for the new patch. I really like the desgin of this test! A f

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- (Updated March 19, 2015, 11:31 p.m.) Review request for kafka. Bugs: KAFKA-20

Re: Review Request 31893: Patch for KAFKA-2013

> On March 16, 2015, 5:17 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala, line 193 > > > > > > Is there a particular reason that we need to overwrite isCompleted()? > > Typical

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- (Updated March 16, 2015, 9:39 p.m.) Review request for kafka. Bugs: KAFKA-201

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- (Updated March 16, 2015, 9:13 p.m.) Review request for kafka. Bugs: KAFKA-201

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- (Updated March 16, 2015, 8:23 p.m.) Review request for kafka. Bugs: KAFKA-201

Re: Review Request 31893: Patch for KAFKA-2013

> On March 16, 2015, 5:17 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala, line 193 > > > > > > Is there a particular reason that we need to overwrite isCompleted()? > > Typical

Re: Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/#review76566 --- Thanks for the patch. A few comments. core/src/test/scala/other/ka

Review Request 31893: Patch for KAFKA-2013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/ --- Review request for kafka. Bugs: KAFKA-2013 https://issues.apache.org/jira/b