Re: Review Request 31958: Patch for KAFKA-1684

2015-03-16 Thread Michael Herstine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31958/#review76640 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 31958: Patch for KAFKA-1684

2015-03-16 Thread Sriharsha Chintalapani
On March 16, 2015, 9:24 p.m., Michael Herstine wrote: core/src/main/scala/kafka/network/ssl/SSLChannel.scala, line 137 https://reviews.apache.org/r/31958/diff/1/?file=891658#file891658line137 Suppose SSLEngine has written the current message (via `wrap`) to `netOutBuffer`, but

Re: Review Request 31958: Patch for KAFKA-1684

2015-03-16 Thread Sriharsha Chintalapani
On March 16, 2015, 9:24 p.m., Michael Herstine wrote: core/src/main/scala/kafka/network/SocketServer.scala, line 318 https://reviews.apache.org/r/31958/diff/1/?file=891657#file891657line318 `{want,needs}ClientAuth` can be tricky-- check the javadoc for

Review Request 31958: Patch for KAFKA-1684

2015-03-11 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31958/ --- Review request for kafka. Bugs: KAFKA-1684