Review Request 32199: Patch for KAFKA-1858

2015-03-18 Thread Adrian Preston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32199/ --- Review request for kafka. Bugs: KAFKA-1858 https://issues.apache.org/jira/b

Re: Review Request 32199: Patch for KAFKA-1858

2015-03-18 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32199/#review76896 --- This will definitely make the test more stable. I am just thinking d

Re: Review Request 32199: Patch for KAFKA-1858

2015-03-19 Thread Adrian Preston
> On March 18, 2015, 3:17 p.m., Jiangjie Qin wrote: > > This will definitely make the test more stable. I am just thinking does it > > make sense to add a non deamon thread check in each test? So we can make > > sure there is no deamon thread left from some tests. Good question. I think this d

Re: Review Request 32199: Patch for KAFKA-1858

2015-03-19 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32199/#review77060 --- LGTM - Mayuresh Gharat On March 18, 2015, 11:12 a.m., Adrian Pres