Re: Review Request 32251: Patch for KAFKA-2032

2015-07-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/#review91936 --- Ship it! Ship It! - Sriharsha Chintalapani On March 19, 2015, 7:

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/#review77090 --- Ship it! Ship It! - Sriharsha Chintalapani On March 19, 2015, 7:

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/ --- (Updated March 19, 2015, 7:19 p.m.) Review request for kafka. Bugs: KAFKA-203

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
> On March 19, 2015, 6:52 p.m., Jason Rosenberg wrote: > > core/src/main/scala/kafka/consumer/ConsumerConfig.scala, line 90 > > > > > > Should this be called 'validatePartitionAssignmentStrategy'? > > > > At an

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Jason Rosenberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/#review77081 --- core/src/main/scala/kafka/consumer/ConsumerConfig.scala

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/ --- (Updated March 19, 2015, 6:47 p.m.) Review request for kafka. Bugs: KAFKA-203

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/ --- (Updated March 19, 2015, 6:44 p.m.) Review request for kafka. Bugs: KAFKA-203

Re: Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/ --- (Updated March 19, 2015, 6:42 p.m.) Review request for kafka. Bugs: KAFKA-203

Review Request 32251: Patch for KAFKA-2032

2015-03-19 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32251/ --- Review request for kafka. Bugs: KAFKA-2032 https://issues.apache.org/jira/b