Re: Review Request 32459: Patch for KAFKA-2044

2015-03-27 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 27, 2015, 4:22 p.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-27 Thread Gwen Shapira
> On March 26, 2015, 3:54 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java, > > lines 49-64 > > > > > > For the error response for MetadataRequest, we want to create

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/#review77907 --- Thanks for the new patch. Looks good overall. Just a couple of more

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 26, 2015, 2:20 a.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
> On March 26, 2015, 12:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java, > > line 53 > > > > > > Cluster may not serialize properly with those nulls in PartitionI

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Jun Rao
> On March 26, 2015, 12:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java, > > line 53 > > > > > > Cluster may not serialize properly with those nulls in PartitionI

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
> On March 26, 2015, 12:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java, > > line 53 > > > > > > Cluster may not serialize properly with those nulls in PartitionI

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 26, 2015, 1:49 a.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
> On March 26, 2015, 12:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java, > > line 53 > > > > > > Cluster may not serialize properly with those nulls in PartitionI

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/#review77832 --- Thanks for the new patch. A few comments below. Perhaps we can add a

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 25, 2015, 11:53 p.m.) Review request for kafka. Bugs: KAFKA-20

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 25, 2015, 11:48 p.m.) Review request for kafka. Bugs: KAFKA-20

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- (Updated March 25, 2015, 11:48 p.m.) Review request for kafka. Bugs: KAFKA-20

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Jun Rao
> On March 25, 2015, 9:43 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java, > > lines 46-54 > > > > > > Instead of adding this method here, would it be better

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Gwen Shapira
> On March 25, 2015, 9:43 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java, > > lines 46-54 > > > > > > Instead of adding this method here, would it be better

Re: Review Request 32459: Patch for KAFKA-2044

2015-03-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/#review77805 --- Thanks for the patch. Looks good to me overall. A few comments below

Review Request 32459: Patch for KAFKA-2044

2015-03-24 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/ --- Review request for kafka. Bugs: KAFKA-2044 https://issues.apache.org/jira/b