Review Request 32465: Patch for KAFKA-2047

2015-03-24 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/ --- Review request for kafka. Bugs: KAFKA-2047 https://issues.apache.org/jira/b

Re: Review Request 32465: Patch for KAFKA-2047

2015-03-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/#review77789 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 32465: Patch for KAFKA-2047

2015-03-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/ --- (Updated March 25, 2015, 8:48 p.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32465: Patch for KAFKA-2047

2015-03-25 Thread Jiangjie Qin
> On March 25, 2015, 8:37 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 325 > > > > > > Wondering if we call System.exit(-1) directly from one of the MM > > thread, if we have

Re: Review Request 32465: Patch for KAFKA-2047

2015-03-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/#review77791 --- Ship it! Will make the minor change upon checkin. core/src/main/s

Re: Review Request 32465: Patch for KAFKA-2047

2015-03-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465/#review77794 --- core/src/main/scala/kafka/tools/MirrorMaker.scala