---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review101976
---
core/src/main/scala/kafka/server/ClientQuotaManager.scala (line
On Aug. 18, 2015, 11:33 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaManager.scala, line 147
https://reviews.apache.org/r/33049/diff/28/?file=1040947#file1040947line147
The window used here is a bit different from that used in
Rate.measure() and it doesn't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95793
---
On Aug. 14, 2015, 1:57 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java,
lines 69-77
https://reviews.apache.org/r/33049/diff/25/?file=1039169#file1039169line69
This is probably not the right place to throw QuotaViolationException.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95496
---
Ship it!
Minor edits that I will take care of on check-in.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 15, 2015, 12:43 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 15, 2015, 12:43 a.m.)
Review request for kafka, Joel Koshy and
On Aug. 14, 2015, 1:57 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java,
lines 69-77
https://reviews.apache.org/r/33049/diff/25/?file=1039169#file1039169line69
This is probably not the right place to throw QuotaViolationException.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95344
---
build.gradle (line 383)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95369
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 14, 2015, 2:08 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 14, 2015, 2:09 a.m.)
Review request for kafka, Joel Koshy and
On Aug. 14, 2015, 1:57 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java,
lines 69-77
https://reviews.apache.org/r/33049/diff/25/?file=1039169#file1039169line69
This is probably not the right place to throw QuotaViolationException.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 14, 2015, 2:20 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 14, 2015, 2:19 a.m.)
Review request for kafka, Joel Koshy and
On Aug. 6, 2015, 4:17 p.m., Jun Rao wrote:
A few more comments.
We need to be careful with sensors at the client-id level. Clients can come
and go (e.g. console consumer). We probably don't want to hold sensors that
are not longer actively used since it takes memory. So, we will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95216
---
core/src/main/scala/kafka/server/ClientQuotaManager.scala (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 13, 2015, 4:24 a.m.)
Review request for kafka, Joel Koshy and
On June 17, 2015, 4:40 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 1
https://reviews.apache.org/r/33049/diff/15/?file=983845#file983845line1
Why was MockTime moved from test to main?
Aditya Auradkar wrote:
Because I need to depend
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:02 p.m.)
Review request for kafka, Joel Koshy and
On Aug. 12, 2015, 12:34 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines
131-150
https://reviews.apache.org/r/33049/diff/21/?file=1037164#file1037164line131
I think the comment can be a simpler. Basically, if O is the observed
rate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:03 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:04 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:05 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:08 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 12, 2015, 7:09 p.m.)
Review request for kafka, Joel Koshy and
On Aug. 12, 2015, 12:42 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/KafkaConfig.scala, line 419
https://reviews.apache.org/r/33049/diff/21/?file=1037170#file1037170line419
I am still not sure that I see the value of the delay factor. If one
wants to be a bit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95033
---
Just a couple of comments below. Otherwise, LGTM.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95035
---
core/src/main/scala/kafka/server/KafkaConfig.scala (line 418)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 11, 2015, 4:58 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 11, 2015, 4:57 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 10, 2015, 8:49 p.m.)
Review request for kafka, Joel Koshy and
On Aug. 6, 2015, 4:17 p.m., Jun Rao wrote:
A few more comments.
We need to be careful with sensors at the client-id level. Clients can come
and go (e.g. console consumer). We probably don't want to hold sensors that
are not longer actively used since it takes memory. So, we will
On Aug. 6, 2015, 2:02 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines
135-139
https://reviews.apache.org/r/33049/diff/18/?file=1032143#file1032143line135
Is that calculation here right? Based on the calculation in Throttler,
it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 10, 2015, 8:48 p.m.)
Review request for kafka, Joel Koshy and
On Aug. 6, 2015, 2:02 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines
135-139
https://reviews.apache.org/r/33049/diff/18/?file=1032143#file1032143line135
Is that calculation here right? Based on the calculation in Throttler,
it
On Aug. 6, 2015, 4:17 p.m., Jun Rao wrote:
A few more comments.
We need to be careful with sensors at the client-id level. Clients can come
and go (e.g. console consumer). We probably don't want to hold sensors that
are not longer actively used since it takes memory. So, we will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 7, 2015, 6:28 p.m.)
Review request for kafka, Joel Koshy and Jun
On Aug. 6, 2015, 2:02 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaManager.scala, lines 208-211
https://reviews.apache.org/r/33049/diff/18/?file=1032147#file1032147line208
Instead of creating a new metric instance, we probably should just
reuse the same metric
On Aug. 6, 2015, 4:17 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaManager.scala, lines 154-201
https://reviews.apache.org/r/33049/diff/18/?file=1032147#file1032147line154
Not sure why the lock is needed. metrics.sensor() is synchronized and
alreayd does the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 7, 2015, 6:27 p.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review94412
---
A few more comments.
We need to be careful with sensors at the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review94333
---
Thanks for the patch. A few comments below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 5, 2015, 1:50 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 5, 2015, 2:08 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 5, 2015, 2:07 a.m.)
Review request for kafka, Joel Koshy and Jun
On Aug. 4, 2015, 3:28 a.m., Edward Ribeiro wrote:
clients/src/main/java/org/apache/kafka/common/metrics/QuotaViolationException.java,
line 27
https://reviews.apache.org/r/33049/diff/16/?file=995401#file995401line27
It's a very good pratice to make any field ``final`` unless
On Aug. 4, 2015, 12:36 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 98
https://reviews.apache.org/r/33049/diff/16/?file=995406#file995406line98
A number of places in this patch use a : b instead of a: b. Highly
stylistic, I'm beginning
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review93965
---
Looks good overall. I have a few more minor comments/suggestions.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review93991
---
clients/src/main/java/org/apache/kafka/common/metrics/Quota.java
On June 17, 2015, 4:40 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 1
https://reviews.apache.org/r/33049/diff/15/?file=983845#file983845line1
Why was MockTime moved from test to main?
Because I need to depend on MockTime from clients in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 30, 2015, 12:54 a.m.)
Review request for kafka, Joel Koshy and
On June 17, 2015, 4:40 p.m., Joel Koshy wrote:
core/src/test/scala/integration/kafka/api/QuotasTest.scala, line 142
https://reviews.apache.org/r/33049/diff/15/?file=983852#file983852line142
This is an important test, but this is a bit non-deterministic no?
i.e., the replicas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review88180
---
This is looking very good.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 12, 2015, 5:40 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 12, 2015, 5:39 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 4, 2015, 11:32 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 4, 2015, 11:31 p.m.)
Review request for kafka, Joel Koshy and
On June 3, 2015, 3:57 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/KafkaServer.scala, line 200
https://reviews.apache.org/r/33049/diff/10/?file=972069#file972069line200
Can we consider migrating the server to use the Time interface in
clients and just use that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review86418
---
I had collected my comments on this older revision. I have not
On May 28, 2015, 12:20 a.m., Dong Lin wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 60
https://reviews.apache.org/r/33049/diff/10/?file=972066#file972066line60
Should we set this to 0, or remove this configuratrion, if there is no
use case for having this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 3, 2015, 12:10 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated June 3, 2015, 12:09 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review85545
---
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala
On May 28, 2015, 12:58 p.m., Manikumar Reddy O wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 145
https://reviews.apache.org/r/33049/diff/10/?file=972066#file972066line145
Are we using clientID as uniqueKey?. But as of now, clientID is not
mandatory and it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review85465
---
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala
On May 12, 2015, 7:38 p.m., Dong Lin wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, line 117
https://reviews.apache.org/r/33049/diff/9/?file=955824#file955824line117
metric.value(timeMs), which translates to Rate.measure(config, timeMs),
may return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 26, 2015, 6:50 p.m.)
Review request for kafka, Joel Koshy and Jun
On May 12, 2015, 7:38 p.m., Dong Lin wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines
122-127
https://reviews.apache.org/r/33049/diff/9/?file=955824#file955824line122
The function quits on the first quota violaation, and calculate
delayTime based
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review84025
---
core/src/main/scala/kafka/server/KafkaApis.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review83441
---
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
On May 12, 2015, 7:38 p.m., Dong Lin wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, line 117
https://reviews.apache.org/r/33049/diff/9/?file=955824#file955824line117
metric.value(timeMs), which translates to Rate.measure(config, timeMs),
may return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 11, 2015, 11:16 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 11, 2015, 11:17 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 6, 2015, 12:52 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 10:27 p.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 10:29 p.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review82382
---
Thanks for the patch.
I agree that ClientQuotaMetrics2 is better.
On May 4, 2015, 3:46 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics2.scala, lines 153-162
https://reviews.apache.org/r/33049/diff/5/?file=938427#file938427line153
For measuring the amount of throtting, would it be better to measure it
as a percentage of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 4:33 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated April 21, 2015, 7:33 p.m.)
Review request for kafka and Joel Koshy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated April 21, 2015, 7:21 p.m.)
Review request for kafka and Joel Koshy.
On April 17, 2015, 11:21 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 33
https://reviews.apache.org/r/33049/diff/3/?file=924194#file924194line33
Is this necessary?
Not strictly but I felt it was a nice to have. I can make the default 1 if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated April 21, 2015, 7:28 p.m.)
Review request for kafka and Joel Koshy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review80130
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated April 11, 2015, 12:24 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated April 11, 2015, 12:25 a.m.)
Review request for kafka.
Bugs:
87 matches
Mail list logo
