Re: Review Request 34641: Patch for KAFKA-2214

2015-08-06 Thread Michael Noll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review94378 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated Aug. 5, 2015, 3:19 p.m.) Review request for kafka. Bugs: KAFKA-2214

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
On July 21, 2015, 1:50 p.m., Ismael Juma wrote: Thanks for the suggestions. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92403

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
On July 17, 2015, 5:03 a.m., Gwen Shapira wrote: Just realized that verifyAssigment runs on a Map of Partition, Status and originally printed status for each partition (some can succeed, fail or be in-progress). We need to return a single error code. In the existing code, we return

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-21 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92403 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-16 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92024 --- Just realized that verifyAssigment runs on a Map of Partition,

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 14, 2015, 10:03 a.m.) Review request for kafka. Bugs:

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 14, 2015, 10:13 a.m.) Review request for kafka. Bugs:

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
On May 26, 2015, 7:08 a.m., Michael Noll wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81 https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81 Should we also consider reassignments that are in-progress as errors? The

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 13, 2015, 3:43 p.m.) Review request for kafka. Bugs:

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-10 Thread Gwen Shapira
On May 26, 2015, 7:08 a.m., Michael Noll wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81 https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81 Should we also consider reassignments that are in-progress as errors? The

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-10 Thread Gwen Shapira
On May 26, 2015, 7:08 a.m., Michael Noll wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81 https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81 Should we also consider reassignments that are in-progress as errors? The

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-10 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 10, 2015, 4:28 p.m.) Review request for kafka. Bugs:

Re: Review Request 34641: Patch for KAFKA-2214

2015-05-26 Thread Manikumar Reddy O
On May 26, 2015, 7:08 a.m., Michael Noll wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81 https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81 Should we also consider reassignments that are in-progress as errors? The

Re: Review Request 34641: Patch for KAFKA-2214

2015-05-26 Thread Michael Noll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review85154 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala