Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review90847 --- Ship it! Ship It! - Joel Koshy On June 24, 2015, 8 p.m., Dong Li

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89241 --- Ship it! Ship It! - Jason Gustafson On June 24, 2015, 8 p.m., Do

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- (Updated June 24, 2015, 8 p.m.) Review request for kafka. Bugs: KAFKA-2298

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- (Updated June 24, 2015, 1:48 a.m.) Review request for kafka. Bugs: KAFKA-2298

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

> On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 282 > > > > > > Do you think we should just move the disconnected.add() into the

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89010 --- clients/src/main/java/org/apache/kafka/common/network/Selector.java

Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- Review request for kafka. Bugs: KAFKA-2298 https://issues.apache.org/jira/b