---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/#review90712
---
Ship it!
Ship It!
- Guozhang Wang
On July 7, 2015, 1:22 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/
---
(Updated July 7, 2015, 5:47 p.m.)
Review request for kafka and Joel Koshy.
On July 7, 2015, 5:28 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 408
https://reviews.apache.org/r/36034/diff/3/?file=1000835#file1000835line408
Missed one more point here: I think it is better to use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/#review90765
---
Ship it!
Ship It!
- Guozhang Wang
On July 7, 2015, 5:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/#review90730
---
On July 3, 2015, 1:36 a.m., Guozhang Wang wrote:
Thanks for the patch. I have a few thoughts regarding the names of the
metrics, since in the producer other causes can also result in dropped
messages (i.e. rejected before it enteres the producer buffer), such as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/#review90614
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/
---
(Updated July 6, 2015, 9:54 p.m.)
Review request for kafka and Joel Koshy.
On July 3, 2015, 1:36 a.m., Guozhang Wang wrote:
Thanks for the patch. I have a few thoughts regarding the names of the
metrics, since in the producer other causes can also result in dropped
messages (i.e. rejected before it enteres the producer buffer), such as
On July 3, 2015, 1:36 a.m., Guozhang Wang wrote:
Thanks for the patch. I have a few thoughts regarding the names of the
metrics, since in the producer other causes can also result in dropped
messages (i.e. rejected before it enteres the producer buffer), such as
On July 3, 2015, 1:36 a.m., Guozhang Wang wrote:
Thanks for the patch. I have a few thoughts regarding the names of the
metrics, since in the producer other causes can also result in dropped
messages (i.e. rejected before it enteres the producer buffer), such as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/#review90303
---
Thanks for the patch. I have a few thoughts regarding the names of
On July 3, 2015, 1:36 a.m., Guozhang Wang wrote:
Thanks for the patch. I have a few thoughts regarding the names of the
metrics, since in the producer other causes can also result in dropped
messages (i.e. rejected before it enteres the producer buffer), such as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36034/
---
Review request for kafka.
Bugs: KAFKA-2306
14 matches
Mail list logo
