mimaison merged PR #379:
URL: https://github.com/apache/kafka-site/pull/379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache
cadonna commented on PR #407:
URL: https://github.com/apache/kafka-site/pull/407#issuecomment-1119359385
Call for review: @bbejeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
cadonna merged PR #407:
URL: https://github.com/apache/kafka-site/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
rbowen opened a new pull request, #408:
URL: https://github.com/apache/kafka-site/pull/408
1) It looks like you have moved your primary IRC presence to libera.chat, as
you should. Update the website accordingly.
2) The link to botbot.me is no longer accurate, and it references freenod
gty92 opened a new pull request, #409:
URL: https://github.com/apache/kafka-site/pull/409
Hello Kafka team,
please consider merge this small PR where a new entry is added to
`powered-by.html`. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the
qingwei91 opened a new pull request, #410:
URL: https://github.com/apache/kafka-site/pull/410
I've added a Dockerfile and handy script to run documentation locally with 1
command.
It should reduce friction for docs contribution.
--
This is an automated message from the Apache G
qingwei91 commented on PR #410:
URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1124867030
I dont think we can do the same on https://github.com/apache/kafka/ itself,
please correct me if I'm wrong
--
This is an automated message from the Apache Git Service.
To respond to
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r871522164
##
README.md:
##
@@ -0,0 +1,11 @@
+# How to preview the documentation changes locally?
+
+The documentation can hosted on a local webserver via httpd.
+
+You can run i
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r871576678
##
README.md:
##
@@ -0,0 +1,11 @@
+# How to preview the documentation changes locally?
+
+The documentation can hosted on a local webserver via httpd.
+
+You can run
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r871588483
##
README.md:
##
@@ -0,0 +1,11 @@
+# How to preview the documentation changes locally?
+
+The documentation can hosted on a local webserver via httpd.
+
+You can run i
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r871590415
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872153458
##
README.md:
##
@@ -0,0 +1,11 @@
+# How to preview the documentation changes locally?
+
+The documentation can hosted on a local webserver via httpd.
+
+You can run
tombentley commented on PR #411:
URL: https://github.com/apache/kafka-site/pull/411#issuecomment-1125855598
@dajac @cadonna or @mimaison PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872225024
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
tombentley merged PR #411:
URL: https://github.com/apache/kafka-site/pull/411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apac
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872286879
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872289325
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872289325
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872289325
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872351993
##
start-preview.sh:
##
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -euxo pipefail
+
+docker build -t kafka-site-preview .
+
+docker run -dit --rm --name mypreview -p
mimaison commented on PR #410:
URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1126118797
When I run this locally, I can only access pages under `Docs`, for anything
else I get 404.
Is it expected? I would be nice to preview the complete website.
--
This is an autom
qingwei91 commented on PR #410:
URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1126166013
Woops, might be a regression, sorry, let me check, I will move this into
draft in the mean time
I agree, it is better to make it work for the whole site
--
This is an automate
qingwei91 commented on PR #410:
URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1126221013
Hi @mimaison sorry for the back and forth, after some fiddling, I realize
the problem is that when requesting `localhost:8080/path`, httpd tries to find
a file named`path`, which does
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872567579
##
.htaccess:
##
@@ -9,3 +9,5 @@ RewriteRule ^/?(\d+)/javadoc - [S=2]
RewriteRule ^/?(\d+)/images/ - [S=1]
RewriteCond $2 !=protocol
RewriteRule ^/?(\d+)/([a-z]+)(
qingwei91 commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r872567579
##
.htaccess:
##
@@ -9,3 +9,5 @@ RewriteRule ^/?(\d+)/javadoc - [S=2]
RewriteRule ^/?(\d+)/images/ - [S=1]
RewriteCond $2 !=protocol
RewriteRule ^/?(\d+)/([a-z]+)(
milindmantri opened a new pull request, #412:
URL: https://github.com/apache/kafka-site/pull/412
Reference: apache/kafka#12152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
qingwei91 commented on PR #410:
URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1129651258
Hi @mimaison , if you get a chance, can you review this again? I've
addressed the issue you pointed out, thanks!
--
This is an automated message from the Apache Git Service.
To respo
guozhangwang merged PR #412:
URL: https://github.com/apache/kafka-site/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.ap
mimaison commented on code in PR #410:
URL: https://github.com/apache/kafka-site/pull/410#discussion_r876875276
##
.htaccess:
##
@@ -9,3 +9,5 @@ RewriteRule ^/?(\d+)/javadoc - [S=2]
RewriteRule ^/?(\d+)/images/ - [S=1]
RewriteCond $2 !=protocol
RewriteRule ^/?(\d+)/([a-z]+)(\
ZachLC opened a new pull request, #413:
URL: https://github.com/apache/kafka-site/pull/413
We really are fans at Covage. congrats of what you've done with Kafka.
![image](https://user-images.githubusercontent.com/106680797/171433210-905085eb-1c02-4783-a35a-ffb8ef22b3bb.png)
--
This
ocadaruma opened a new pull request, #414:
URL: https://github.com/apache/kafka-site/pull/414
refs: https://github.com/apache/kafka/pull/12251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon merged PR #414:
URL: https://github.com/apache/kafka-site/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
showuon commented on PR #414:
URL: https://github.com/apache/kafka-site/pull/414#issuecomment-1146565749
Thank you, @ocadaruma !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
RivenSun2 opened a new pull request, #415:
URL: https://github.com/apache/kafka-site/pull/415
Update the kafka-reassign-partitions script command in documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
RivenSun2 commented on PR #415:
URL: https://github.com/apache/kafka-site/pull/415#issuecomment-1147068637
refs: https://github.com/apache/kafka/pull/12237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
showuon merged PR #415:
URL: https://github.com/apache/kafka-site/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
showuon opened a new pull request, #416:
URL: https://github.com/apache/kafka-site/pull/416
refer to : https://github.com/apache/kafka/pull/12261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
showuon merged PR #416:
URL: https://github.com/apache/kafka-site/pull/416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
dongjinleekr opened a new pull request, #417:
URL: https://github.com/apache/kafka-site/pull/417
Do we need to apply this into 3.1, 3.0, or even 2.8 documentations?
:thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
realdengziqi opened a new pull request, #418:
URL: https://github.com/apache/kafka-site/pull/418
Validated rendering and links by running Apache server locally. The entry
renders like this:
![atguigu](https://user-images.githubusercontent.com/42276568/175461790-3275fed7-f03d-4c0c-bc3
realdengziqi commented on PR #418:
URL: https://github.com/apache/kafka-site/pull/418#issuecomment-1165180965
@cadonna can you please review? Thanks♪(・ω・)ノ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
realdengziqi commented on PR #418:
URL: https://github.com/apache/kafka-site/pull/418#issuecomment-1166460627
@PhilippB21 can you please review? Thank you♪(・ω・)ノ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
PhilippB21 commented on PR #418:
URL: https://github.com/apache/kafka-site/pull/418#issuecomment-1166965966
@realdengziqi Sorry, bur I am not authorized to do a review and so far I
have only submitted our company logo.
--
This is an automated message from the Apache Git Service.
To respon
guozhangwang merged PR #418:
URL: https://github.com/apache/kafka-site/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.ap
bbejeck commented on PR #413:
URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1168958992
HI @ZachLC can you rebase this PR and we can get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
bbejeck merged PR #317:
URL: https://github.com/apache/kafka-site/pull/317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck merged PR #372:
URL: https://github.com/apache/kafka-site/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck commented on PR #372:
URL: https://github.com/apache/kafka-site/pull/372#issuecomment-1169000109
@d-t-w merged this, thanks for the addition to the powered-by section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbejeck merged PR #373:
URL: https://github.com/apache/kafka-site/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck commented on PR #373:
URL: https://github.com/apache/kafka-site/pull/373#issuecomment-1169006063
merged to asf-site thanks for the addition to the powered-by page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bbejeck commented on PR #315:
URL: https://github.com/apache/kafka-site/pull/315#issuecomment-1169006981
Hi @acraske - sorry it's taken a while to get to this PR - can you rebase
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bbejeck commented on PR #395:
URL: https://github.com/apache/kafka-site/pull/395#issuecomment-1169015004
Hi @Venom-git - I was about to merge this PR but it renders like this for me
![Screen Shot 2022-06-28 at 1 22 15
PM](https://user-images.githubusercontent.com/199238/176244571-e5ecade9
d-t-w commented on PR #372:
URL: https://github.com/apache/kafka-site/pull/372#issuecomment-1169631953
Thanks @bbejeck much appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ZachLC commented on PR #413:
URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1169764733
> HI @ZachLC can you rebase this PR and we can get this merged?
Hi @bbejeck,
Sure. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the me
bbejeck merged PR #413:
URL: https://github.com/apache/kafka-site/pull/413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck commented on PR #413:
URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1170063176
merged #413 into asf-site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
bbejeck merged PR #320:
URL: https://github.com/apache/kafka-site/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck commented on PR #320:
URL: https://github.com/apache/kafka-site/pull/320#issuecomment-117005
merged #320 into asf-site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
bbejeck commented on PR #320:
URL: https://github.com/apache/kafka-site/pull/320#issuecomment-1170078043
Thanks @JaviOverflow for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bbejeck commented on PR #406:
URL: https://github.com/apache/kafka-site/pull/406#issuecomment-1170082018
Hi @StephanZimmermann if you can rebase this PR we'll get this merged.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
JaviOverflow commented on PR #320:
URL: https://github.com/apache/kafka-site/pull/320#issuecomment-1170851653
After 1 year and 8 months, you may want to check if 80% is still the right
number haha
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
JK-Wang opened a new pull request, #419:
URL: https://github.com/apache/kafka-site/pull/419
refs: [apache/kafka#12252](https://github.com/apache/kafka/pull/12252)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
guozhangwang merged PR #419:
URL: https://github.com/apache/kafka-site/pull/419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.ap
dongjinleekr commented on PR #417:
URL: https://github.com/apache/kafka-site/pull/417#issuecomment-1179669841
@mimaison @ableegoldman @dajac Could you kindly have a look? This is
continuation of [this PR](https://github.com/apache/kafka/pull/11473).
--
This is an automated message from th
mimaison merged PR #417:
URL: https://github.com/apache/kafka-site/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache
divijvaidya opened a new pull request, #420:
URL: https://github.com/apache/kafka-site/pull/420
As per the [Apache privacy
policy](https://privacy.apache.org/faq/committers.html), Google Fonts are
recommended to be hosted along with the website.
This change adds the fonts locally in
divijvaidya commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1183179393
@ijuma @mimaison please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
divijvaidya opened a new pull request, #421:
URL: https://github.com/apache/kafka-site/pull/421
**Why**
As per the [Apache branching
policy](https://www.apache.org/foundation/marks/pmcs#navigation), every project
website's main navigation system must feature certain text links back to ke
divijvaidya commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1183316551
@mimaison please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
divijvaidya opened a new pull request, #422:
URL: https://github.com/apache/kafka-site/pull/422
As per the [Apache privacy
policy](https://privacy.apache.org/faq/committers.html), all JS files are
recommended to be hosted along with the website so that we don't have a
dependency on CDNs su
divijvaidya commented on PR #422:
URL: https://github.com/apache/kafka-site/pull/422#issuecomment-1183421173
@mimaison please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mumrah opened a new pull request, #423:
URL: https://github.com/apache/kafka-site/pull/423
This is in preparation for the upcoming 3.2.1 release. This key can also be
found on [keys.openpgp.org](https://keys.openpgp.org/)
--
This is an automated message from the Apache Git Service.
To res
mumrah merged PR #423:
URL: https://github.com/apache/kafka-site/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.o
StephanZimmermann commented on PR #406:
URL: https://github.com/apache/kafka-site/pull/406#issuecomment-1185481331
Hi @bbejeck , I did the requested rebase. Ready to pull :-) Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mimaison commented on code in PR #420:
URL: https://github.com/apache/kafka-site/pull/420#discussion_r923193623
##
css/fonts.css:
##
@@ -0,0 +1,352 @@
+/* latin-ext */
+@font-face {
+font-family: 'Cutive Mono';
+font-style: normal;
+font-weight: 400;
+src:
url(h
mimaison commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187033048
Thanks @divijvaidya for looking into this as the deadline is approaching
quickly now!
I'm not sure we need a full Apache menu. Have you considered just adding a
Privacy Policy li
divijvaidya commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187036010
@mimaison thank you for your review.
> I'm not sure we need a full Apache menu
I think we do indeed need the full Apache menu. Please refer to [Apache
branding policy](h
mimaison merged PR #422:
URL: https://github.com/apache/kafka-site/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache
mimaison commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187557669
You are right, these links should be included. Thanks for following up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mimaison commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923435396
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923438915
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923468457
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923497051
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575015
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575649
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923583008
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
divijvaidya commented on code in PR #420:
URL: https://github.com/apache/kafka-site/pull/420#discussion_r923600664
##
css/fonts.css:
##
@@ -0,0 +1,352 @@
+/* latin-ext */
+@font-face {
+font-family: 'Cutive Mono';
+font-style: normal;
+font-weight: 400;
+src:
ur
divijvaidya commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188046357
> As an alternative, have you tried getting rid of these custom fonts and
using a standard one like helvetica?
No. Roboto is a fairly common and popular font used across websit
showuon commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r924146761
##
includes/_top.htm:
##
@@ -150,6 +150,48 @@
showuon commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188708449
@scott-confluent , could you help review this PR since you added the google
font into this project? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to t
divijvaidya commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188739303
> @divijvaidya , why do you use
https://google-webfonts-helper.herokuapp.com/fonts/ to download the fonts,
instead of the original link:
[https://fonts.googleapis.com/css?family=Cut
showuon commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188822349
@divijvaidya , I see. But in
https://fonts.googleapis.com/css?family=Cutive+Mono%7CRoboto:100,300,400,700,900%7CRoboto+Condensed:300
, we can download all the fonts in `woff2` format via
divijvaidya commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1188923709
> We can download the font via
https://fonts.gstatic.com/s/cutivemono/v14/m8JWjfRfY7WVjVi2E-K9H6RMTm6o39ucNvc.woff2
Oh yes. We can do that but I think that would be less mainta
mimaison merged PR #421:
URL: https://github.com/apache/kafka-site/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache
showuon commented on PR #420:
URL: https://github.com/apache/kafka-site/pull/420#issuecomment-1189006953
> That is a very fair question to ask. The number of actual font files are
lesser because the new font files contain all the charset in one file.
I see. Thanks.
> I
divijvaidya opened a new pull request, #424:
URL: https://github.com/apache/kafka-site/pull/424
As per the [ASF privacy
policy](https://privacy.apache.org/faq/committers.html), Google Analytics
should be replaced with Apache hosted version of Matomo to remain complaint
with GDPR.
Em
divijvaidya commented on PR #424:
URL: https://github.com/apache/kafka-site/pull/424#issuecomment-1189065641
@mimaison please review for the GDPR compliance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tombentley commented on code in PR #420:
URL: https://github.com/apache/kafka-site/pull/420#discussion_r924521925
##
css/fonts.css:
##
@@ -0,0 +1,82 @@
+/* cutive-mono-regular - latin-ext_latin */
+@font-face {
+font-family: 'Cutive Mono';
+font-style: normal;
+font-
bbejeck merged PR #406:
URL: https://github.com/apache/kafka-site/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.
bbejeck commented on PR #406:
URL: https://github.com/apache/kafka-site/pull/406#issuecomment-1189089886
@StephanZimmermann thanks for rebasing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
401 - 500 of 857 matches
Mail list logo