Re: [VOTE] 2.0.0 RC0

2018-06-25 Thread Thomas Crayford
+1 (non-binding) Heroku has run our usual set of upgrade and performance tests, and we haven't found any notable issues through that. On Sat, Jun 23, 2018 at 12:30 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > +1 (non-binding) > > Built from source and ran quickstart successfully

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-06-20 Thread Thomas Crayford
+1 (non-binding) On Tue, Jun 19, 2018 at 8:20 PM, Lucas Wang wrote: > Hi Jun, Ismael, > > Can you please take a look when you get a chance? Thanks! > > Lucas > > On Mon, Jun 18, 2018 at 1:47 PM, Ted Yu wrote: > > > +1 > > > > On Mon, Jun 18, 2018 at 1:04 PM, Lucas Wang > wrote: > > > > > Hi

Re: [VOTE] KIP-278: Add version option to Kafka's commands

2018-05-11 Thread Thomas Crayford
+1 (non-binding) On Fri, May 11, 2018 at 5:17 PM, Guozhang Wang wrote: > Thanks Toru-san, +1 (binding) > > On Fri, May 11, 2018 at 8:30 AM, Jason Gustafson > wrote: > > > Thanks for the KIP! +1 (binding) > > > > On Fri, May 11, 2018 at 12:35 AM,

Re: [VOTE] Kafka 2.0.0 in June 2018

2018-04-24 Thread Thomas Crayford
+1 (non-binding). Whilst 1.0 -> 2.0 seems like visibly a "big" jump in version numbers to have so soon after 1.0, it makes sense with semver requirements and the deprecations contained. Thanks Tom Crayford Heroku Kafka On Tue, Apr 24, 2018 at 11:20 AM, zhenya Sun wrote: >

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Thomas Crayford
+1 (non-binding) On Wed, Mar 28, 2018 at 9:15 PM, Ted Yu wrote: > +1 > > On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison > > wrote: > > > +1 (non binding) > > Thanks for the KIP > > > > On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira

Re: [VOTE] 1.0.0 RC2

2017-10-23 Thread Thomas Crayford
We (Heroku) have run our usual set of perf tests against 1.0 RC2 and found no notable issues so far. Once RC3 is out we will test that too. Thanks Tom Crayford Heroku Kafka On Tue, Oct 17, 2017 at 5:47 PM, Guozhang Wang wrote: > Hello Kafka users, developers and

Re: [VOTE] 1.0.0 RC1

2017-10-17 Thread Thomas Crayford
Hi Ghouzang, We have indeed started our performance testing at Heroku for RC1. However, we are more than happy to retest once RC2 is available, especially given larger amounts of time to do so. Thanks Tom Crayford Heroku Kafka On Tue, Oct 17, 2017 at 2:50 AM, Ismael Juma

Re: [VOTE] 1.0.0 RC1

2017-10-16 Thread Thomas Crayford
Hi Guozhang, This says the due date on the testing is October 13th, which was the day this email was sent. Is that accurate, or is it meant to read October 17th, which is next Tuesday? I feel like this short a testing window for a 1.0 RC is a little low, as 1.0 is clearly a big announcement of

Re: [VOTE] 0.11.0.1 RC0

2017-09-12 Thread Thomas Crayford
Heroku has vetted this through our typical performance and regression testing, and everything looks good. +1 (non-binding) from us. On Tue, Sep 5, 2017 at 9:34 PM, Damian Guy wrote: > Hello Kafka users, developers and client-developers, > > This is the first candidate for

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-04 Thread Thomas Crayford
+1 (non-binding) On Mon, Sep 4, 2017 at 3:30 PM, Manikumar wrote: > +1 (non-binding) > > On Mon, Sep 4, 2017 at 6:39 PM, Rajini Sivaram > wrote: > > > All the suggestions on the discuss thread have been incorporated into the > > KIP. Please

Re: Kafka 0.11.0.0

2017-08-14 Thread Thomas Crayford
0.11.0.0 is a brand new release, with a very large number of changes compared to the previous stable release (0.10.2.1). As a thing that stores data, I would not recommend you switch to it without a very large amount of testing and validation, probably involving running a shadow setup of your