Re: [VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-07-04 Thread Nishanth Pradeep
Hello Ted, That's my fault. I replied in the PR because at the time John had made his comment I hadn't added myself to the dev email list to reply. You can see my comment here. https://github.com/apache/kafka/pull/5284#discussion_r199360544 There is still ongoing discussion about the purpose of

Re: [VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-07-03 Thread Ted Yu
Hi, I don't seem to find response to John's comment : http://search-hadoop.com/m/Kafka/uyzND11alrn1G5N3Y1?subj=Re+Discuss+KIP+321+Add+method+to+get+TopicNameExtractor+in+TopologyDescription On Tue, Jul 3, 2018 at 7:38 PM, Nishanth Pradeep wrote: > Hello, > > I would like to start the vote on

[VOTE] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

2018-07-03 Thread Nishanth Pradeep
Hello, I would like to start the vote on extending the TopologyDescription.Sink interface to return the class of the TopicNameExtractor in cases where dynamic routing is used. The user can override the toString method of the TopicNameExtractor class in order to provide a better textual