Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

We have following votes: non-binding 1. John Roesler 2. vito jeng 3. Richard Yu 4. Bill Bejeck 5. Satish Duggana binding 1. Matthias J. Sax 2. Ismael Juma 3. Damian Guy KIP-331 has passed. Thanks for all votes -- Chia-Ping On 2018/07/05 14:45:01, Chia-Ping Tsai wrote: > hi all, > > I would

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks +1 binding On Sun, 7 Oct 2018 at 03:16, Chia-Ping Tsai wrote: > (just bump) > > We have following votes: > > non-binding > 1. John Roesler > 2. vito jeng > 3. Richard Yu > 4. Bill Bejeck > 5. Satish Duggana > > binding > 1. Matthias J. Sax > 2. Ismael Juma > > it needs one more ticket

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

(just bump) We have following votes: non-binding 1. John Roesler 2. vito jeng 3. Richard Yu 4. Bill Bejeck 5. Satish Duggana binding 1. Matthias J. Sax 2. Ismael Juma it needs one more ticket :) Cheers, Chia-Ping On 2018/07/05 14:45:01, Chia-Ping Tsai wrote: > hi all, > > I would like to

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP! +1 (non-binding) On Tue, Sep 25, 2018 at 1:38 PM, Ismael Juma wrote: > Thanks, +1 (binding). > > Ismael > > On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai wrote: > >> KIP-336[1] has been merged so it is time to activate this thread >> (KIP-331[2]). Last discussion is about

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks, +1 (binding). Ismael On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai wrote: > KIP-336[1] has been merged so it is time to activate this thread > (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface > annotation to Serializer and Deserializer". In discussion of

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the reply. I think my question may have been ambiguous. I was confirming that there would be just one method *without* a default implementation, and therefore that the lambda I quoted would actually work. Thanks, -John On Sun, Sep 23, 2018 at 10:53 AM Chia-Ping Tsai wrote: > > This

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

> This means that I could supply a serializer like this: "(topic, myData) -> > myData.toByteArrayOrWhatever()", right? (and of course similar for > deserializers). That code will work well if KIP-331 is merged. However, the lambda expressions will fail if we add default implementation to all

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

If I understand the way that this works in light of KIP-331, all the methods of Serializer, for example, will have defaults except for : "byte[] serialize(String topic, T data);" This means that I could supply a serializer like this: "(topic, myData) -> myData.toByteArrayOrWhatever()", right?

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

KIP-336[1] has been merged so it is time to activate this thread (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface annotation to Serializer and Deserializer". In discussion of KIP-336 we mentioned that we probably add the default implementation for headless method later.

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

> Part of the motivation for this KIP is to make these interfaces functional > interfaces. But I think that may not be desirable due to the method that > passes headers. So, it doesn't make sense to discuss two separate changes > to the same interfaces in isolation, we should figure out how we

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Part of the motivation for this KIP is to make these interfaces functional interfaces. But I think that may not be desirable due to the method that passes headers. So, it doesn't make sense to discuss two separate changes to the same interfaces in isolation, we should figure out how we want them

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

> The KIP needs 3 binding votes to pass. Thanks for the reminder. I will reopen the ballot box until we get 3 tickets. > I still think we should include the details of how things will look like > with the headers being passed to serializers/deserializers to ensure > things actually make sense

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP! +1 from me. -Bill On Sun, Jul 8, 2018 at 9:55 PM Ismael Juma wrote: > The KIP needs 3 binding votes to pass. I still think we should include the > details of how things will look like with the headers being passed to > serializers/deserializers to ensure things actually

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

The KIP needs 3 binding votes to pass. I still think we should include the details of how things will look like with the headers being passed to serializers/deserializers to ensure things actually make sense as a whole. Ismael On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, wrote: > All, > > The 72

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

All, The 72 hours has passed. The vote result of KIP-313 is shown below. 1 binding vote (Matthias J. Sax) 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping) Cheers, Chia-Ping On 2018/07/05 14:45:01, Chia-Ping Tsai wrote: > hi all, > > I would like to start voting on

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP! +1(non-binding) --- Vito On Sat, Jul 7, 2018 at 11:29 AM, Chia-Ping Tsai wrote: > hi Ismael > > > I think we should be thinking about > > https://issues.apache.org/jira/browse/KAFKA-6923 at the same time. > > you are right. KAFKA-6923 and KAFKA-6161 are the keys to

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

hi Ismael > I think we should be thinking about > https://issues.apache.org/jira/browse/KAFKA-6923 at the same time. you are right. KAFKA-6923 and KAFKA-6161 are the keys to complete the Serializer and Deserializer. Let us add the default implementations first (KAFKA-6161). And then integrate

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP. I think we should be thinking about https://issues.apache.org/jira/browse/KAFKA-6923 at the same time. Ismael On Thu, 5 Jul 2018, 07:45 Chia-Ping Tsai, wrote: > hi all, > > I would like to start voting on "KIP-331 Add default implementation to > close() and configure() for

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thank you! I'm +1 (non-binding) On Thu, Jul 5, 2018 at 10:24 PM Richard Yu wrote: > Nice KIP! > +1 (non-binding) > -Richard > > On Friday, July 6, 2018, 9:10:43 AM GMT+8, Matthias J. Sax < > matth...@confluent.io> wrote: > > Thanks for the KIP! > > +1 (binding) > > > -Matthias > > On

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Nice KIP! +1 (non-binding) -Richard On Friday, July 6, 2018, 9:10:43 AM GMT+8, Matthias J. Sax wrote: Thanks for the KIP! +1 (binding) -Matthias On 7/5/18 7:45 AM, Chia-Ping Tsai wrote: > hi all, > > I would like to start voting on "KIP-331 Add default implementation to >

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP! +1 (binding) -Matthias On 7/5/18 7:45 AM, Chia-Ping Tsai wrote: > hi all, > > I would like to start voting on "KIP-331 Add default implementation to > close() and configure() for Serializer, Deserializer and Serde" > >

[VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

hi all, I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"