[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java

2022-11-10 Thread GitBox
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1311132720 Agree, no mock here. Actually, it is hard to mock without extracting the `getEnv` as another method. Let me make the pattern static. -- This is an automated message from the Apache Git

[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java

2022-11-10 Thread GitBox
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310239716 Better to do a mock test. Post two snapshots for contrast for now: from ![image](https://user-images.githubusercontent.com/1907997/201096005-42689779-37d5-4a55-8ee7-ecebc81644bb

[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java

2022-11-10 Thread GitBox
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310221732 > @iskey can you add a test to validate please? ok, let me do some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi