Interesting proposal. Never thought about that but it could make sense.
Christian
On 05.03.2014 09:23, Jean-Baptiste Onofré wrote:
Rethinking about this, I propose:
groupId: org.apache.karaf.maven.plugins
artifactId: [scr-maven-plugin, instance-maven-plugin,
feature-maven-plugin, kar-maven-pl
By the way, let see what the others think about that.
Regards
JB
On 03/05/2014 09:36 AM, Jean-Baptiste Onofré wrote:
Yeah, I'm also "split" in my mind ;)
I really think that an unique plugin with multiple goal is better for
the users.
It's likely the Maven approach (for instance deploy:deploy
Yeah, I'm also "split" in my mind ;)
I really think that an unique plugin with multiple goal is better for
the users.
It's likely the Maven approach (for instance deploy:deploy and
deploy:deploy-file).
So, I'm hesitating.
I move forward on the enhancements anyway, I will come back with a
co
Don't know,
I would have prefered a one-to-rule-them-all maven plugin.
It is still a maven plugin, and everything else would distract from the
main purpose.
But this is just my 2 cents and I don't want to be ignorant.
regards, Achim
2014-03-05 9:23 GMT+01:00 Jean-Baptiste Onofré :
> Rethinki
Rethinking about this, I propose:
groupId: org.apache.karaf.maven.plugins
artifactId: [scr-maven-plugin, instance-maven-plugin,
feature-maven-plugin, kar-maven-plugin, ...]
The plugin module will be in each module:
- instance/instance-maven-plugin
- scr/scr-maven-plugin
- features/feature-mav
It makes sense to "spread" the plugin per module (instead of having all
in tooling).
I do the changes on my branch and come back with a proposal.
Regards
JB
On 03/05/2014 08:57 AM, Christian Schneider wrote:
I think the big problem with one big plugin project is that the code
will be very dif
I think the big problem with one big plugin project is that the code
will be very difficult to maintain and test.
The command names below sound good. Especially that they sound similar
to karaf commands. So it it easier for users to know what they do.
I think it should be possible to split the
I would prefer to have one plugin with multiple goal (I think it's
better for the users).
I have no problem to rename/split plugins for future. What do you think
about:
- karaf-commands:documentation
- karaf-scr:scr
- karaf-kar:create
- karaf-kar:install
- karaf-features:populate-repository
-
I think we should not put all karaf plugins into one maven plugin.
Instead I think it makes more
sense to analyze which goals have similar dependencies and put them
together.
For example the karaf-scr plugin has very few dependencies and is better
suited to be kept as a separate plugin.
The s
It's why I put on master, not on the karaf-3.0.x branch.
Master is 3.1.0-SNAPSHOT but should become 4.0.0-SNAPSHOT (as soon as we
will create the 3.1.x branch).
Regards
JB
On 03/05/2014 12:47 AM, Christoph Gritschenberger wrote:
I think it's a bad idea to _rename_ plugin-goals. That would br
I'm with Christoph on this one. I think people wont like us too much for
changing things during minor releases. Maybe we could print a deprecation
comment if the original commands are used instead of the new ones helping
the users switch.
Kind regards,
Andreas
On Wed, Mar 5, 2014 at 12:47 AM, Ch
I think it's a bad idea to _rename_ plugin-goals. That would break
compatibility with 3.0-plugin-configurations.
Maybe the new names should be provided as aliases and the old names
removed in 4.0
kind regards,
christoph
On 04/03/14 20:27, Jean-Baptiste Onofré wrote:
The refactoring is on ma
The refactoring is on master (3.1.x), I don't change on 3.0.x as it's a
maintenance branch now.
Regards
JB
On 03/04/2014 07:48 PM, Jamie G. wrote:
1a. Refactoring/Renaming goals - on the 3.0.x or for 3.1.x? The
shorter names are good, just want a clarification on target.
1b. New Goals - Sound
I second Jamie on this.
sounds like a big improvement, good job.
regards, Achim
2014-03-04 19:48 GMT+01:00 Jamie G. :
> 1a. Refactoring/Renaming goals - on the 3.0.x or for 3.1.x? The
> shorter names are good, just want a clarification on target.
>
> 1b. New Goals - Sounds good.
>
> 2. New tes
1a. Refactoring/Renaming goals - on the 3.0.x or for 3.1.x? The
shorter names are good, just want a clarification on target.
1b. New Goals - Sounds good.
2. New tests are always welcome :)
On Tue, Mar 4, 2014 at 3:09 PM, Jean-Baptiste Onofré wrote:
> Hi all,
>
> I would like to discuss with you
Hi all,
I would like to discuss with you about my current work on the
karaf-maven-plugin:
1/ on master, I refactored the karaf-maven-plugin to use the Maven
annotations. It's simpler and cleaner, and compatible with all Maven
version. I also added the Maven 3.1 and 3.2 support. I also fixed
16 matches
Mail list logo
