No worries. Double check is always better.
Regards
JB
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://wwx.talend.com
- Reply message -
From: "Guillaume Nodet"
To: "dev"
Subject: git commit: Fix legal and code style issues
Date:
My bad. I though the commit was on the branch. Sorry about the noise.
2014-02-22 14:54 GMT+01:00 Jean-Baptiste Onofré :
> Yes, command exporter is only on master (not on the 3.0.x branch).
>
> I fixed multiple issue (some files didn't contain license header), and as
> the packaging of command-
No worries.
It's exactly the purpose of the karaf-3.0.x branch: avoid to include
refactoring/new features/etc in a bug fix/minor update release.
Regards
JB
On 02/22/2014 04:27 PM, Christian Schneider wrote:
Then it is fine. I did not check the code.
I just wanted to make sure we do not accid
Then it is fine. I did not check the code.
I just wanted to make sure we do not accidentally include it.
Christian
On 22.02.2014 16:19, Jean-Baptiste Onofré wrote:
It's the case.
I think you didn't see the content of the commit:
- it's on master (so 3.1.0-SNAPSHOT)
- I didn't merge on karaf-3.
It's the case.
I think you didn't see the content of the commit:
- it's on master (so 3.1.0-SNAPSHOT)
- I didn't merge on karaf-3.0.x branch
I fixed the NOTICE, headers, etc on all branches.
Regards
JB
On 02/22/2014 04:01 PM, Christian Schneider wrote:
I agree. Lets not introduce it in 3.0.1
I agree. Lets not introduce it in 3.0.1 as I will most probably remove it.
Christian
Am 22.02.2014 14:47 schrieb "Guillaume Nodet" :
> I don't think the command exporter is supposed to be released.
> My understanding is that cschneider was going to remote it from master, but
> it should not be in
Yes, command exporter is only on master (not on the 3.0.x branch).
I fixed multiple issue (some files didn't contain license header), and
as the packaging of command-exporter is a bundle, I put a NOTICE file.
Regards
JB
On 02/22/2014 02:46 PM, Guillaume Nodet wrote:
I don't think the command
I don't think the command exporter is supposed to be released.
My understanding is that cschneider was going to remote it from master, but
it should not be in 3.0.1.
2014-02-22 10:55 GMT+01:00 :
> Repository: karaf
> Updated Branches:
> refs/heads/master ed167f00d -> ab704c6bc
>
>
> Fix legal
