+1 It is great that we are considering Pull request that would help to
increase community collaboration.
Jeffrey E Rodriguez
On Thu, Feb 7, 2019 at 3:43 PM Robert Levas
wrote:
> +1. I think this is a great idea.
>
> On Thu, Feb 7, 2019 at 5:29 PM larry mccay wrote:
>
> > Great list of
+1. I think this is a great idea.
On Thu, Feb 7, 2019 at 5:29 PM larry mccay wrote:
> Great list of ideas/practices there, Kevin!
>
> I for one would want comments added as comments to JIRA.
> I hate coming across a JIRA that would address something that I am looking
> for and then find no
Great list of ideas/practices there, Kevin!
I for one would want comments added as comments to JIRA.
I hate coming across a JIRA that would address something that I am looking
for and then find no meaningful comments.
On Thu, Feb 7, 2019 at 4:20 PM Phil Zampino wrote:
> +1, let's follow good
[
https://issues.apache.org/jira/browse/KNOX-931?focusedWorklogId=195962=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195962
]
ASF GitHub Bot logged work on KNOX-931:
---
Author: ASF GitHub Bot
risdenk closed pull request #7: KNOX-931:asType will not work for body filter
when using IdentityAsse…
URL: https://github.com/apache/knox/pull/7
This is an automated message from the Apache Git Service.
To respond to the
risdenk commented on issue #7: KNOX-931:asType will not work for body filter
when using IdentityAsse…
URL: https://github.com/apache/knox/pull/7#issuecomment-461607033
Closing since file related changes don't match PR title.
[
https://issues.apache.org/jira/browse/KNOX-931?focusedWorklogId=195961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195961
]
ASF GitHub Bot logged work on KNOX-931:
---
Author: ASF GitHub Bot
+1, let's follow good models from the community, and save ourselves those
headaches which can be avoided.
On Thu, Feb 7, 2019 at 4:17 PM Kevin Risden wrote:
> I think PRs are a good improvement since we get Travis CI checks by default
> currently. Something that we currently don't get with
I think PRs are a good improvement since we get Travis CI checks by default
currently. Something that we currently don't get with patches
If we go this route we should make sure we have the following in place:
- PR Github Template with useful info
-
I second Phil. Personally, I am more comfortable with the patches mostly
because of their simplistic nature but do like PRs as they are more
community friendly (helps people review, comment, critique) and looks like
they have become OSS standard as Phil pointed out.
So +1 from me.
Best,
Sandeep
I like the PR model, and it is familiar to many who contribute to OSS
projects. I suppose we could continue to support the patch attached to a
Jira model, but we should encourage the PR model, IMHO.
On Thu, Feb 7, 2019 at 4:03 PM larry mccay wrote:
> All -
>
> There has been interest from the
All -
There has been interest from the Knox community in support of Pull Requests
from github.
Our move to gitbox recently makes this easier to do.
What are your thoughts on enabling PRs in general?
Should we support both patches in JIRA as well as github based PRs?
thanks,
--larry
[
https://issues.apache.org/jira/browse/KNOX-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763025#comment-16763025
]
Larry McCay commented on KNOX-1758:
---
I see - you are just adding a target that does the above plus
[
https://issues.apache.org/jira/browse/KNOX-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763033#comment-16763033
]
Sandor Molnar commented on KNOX-1758:
-
Yepp; just like we have a convenient target to start all
[
https://issues.apache.org/jira/browse/KNOX-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Larry McCay updated KNOX-1758:
--
Summary: New Ant target to start test servers with gateway in debug mode
(was: New Ant target to start
[
https://issues.apache.org/jira/browse/KNOX-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763023#comment-16763023
]
Larry McCay commented on KNOX-1758:
---
Hi [~smolnar] - how is this different from:
{code}
ant
[
https://issues.apache.org/jira/browse/KNOX-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandor Molnar updated KNOX-1758:
Labels: pull-request-available (was: )
> New Ant target to start test servers in debug mode
>
Sandor Molnar created KNOX-1758:
---
Summary: New Ant target to start test servers in debug mode
Key: KNOX-1758
URL: https://issues.apache.org/jira/browse/KNOX-1758
Project: Apache Knox
Issue
18 matches
Mail list logo
