[GitHub] [knox] smolnar82 opened a new pull request #533: Knox 2680

2022-01-21 Thread GitBox
smolnar82 opened a new pull request #533: URL: https://github.com/apache/knox/pull/533 ## What changes were proposed in this pull request? `TODO` ## How was this patch tested? `TODO` -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread Sandeep Moré
Thanks Larry and Phil, Makes sense, we could simply rebase the feature branch periodically and keep it in sync (as Phil pointed out - which would be what we do with the fork currently). Thanks for the inputs! On Fri, Jan 21, 2022 at 1:32 PM larry mccay wrote: > +1 to the feature branch plan in

Re: [DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread larry mccay
+1 to the feature branch plan in general! I am -0 on double commits to the feature branch from master. It seems to me that syncing the feature branch is going to be more or less what is happening in the forks now but the other benefits to having a central feature branch here still add significant

Re: [DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread Phil Zampino
Thank you for kicking off this discussion. I'm in favor of the feature branch for this work, for all the reasons you've enumerated. So long as we can preserve the existing review questions/comments from the fork, I don't think we need to resolve any of those concerns before moving into a feature b

[DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread Sandeep Moré
All, I would like to get community input on the process of merging Webshell feature to master. *Problem*: 1. We would like to get this feature in by 2.0 but also would like to make sure we get a proper reviews for this feature. 2. Given the size of the feature, keeping it up to date with recent co

[jira] [Work started] (KNOX-2680) Centralized Source of Cluster Configuration Details for Discovery

2022-01-21 Thread Sandor Molnar (Jira)
[ https://issues.apache.org/jira/browse/KNOX-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KNOX-2680 started by Sandor Molnar. --- > Centralized Source of Cluster Configuration Details for Discovery > -