[jira] [Work logged] (KNOX-3138) Implement try-with-resources for instances of Closeable

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3138?focusedWorklogId=967924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967924 ] ASF GitHub Bot logged work on KNOX-3138: Author: ASF GitHub Bot

Re: [PR] KNOX-3138 implemented try-with-resources for Closeables [knox]

2025-04-28 Thread via GitHub
lmccay commented on PR #1033: URL: https://github.com/apache/knox/pull/1033#issuecomment-2837009114 Hi @dk2k - Thank you for your contribution! While we wait for the checks to pass, can you please revisit the PR description to follow the template that we provide for contributions? That leve

[jira] [Work logged] (KNOX-3138) Implement try-with-resources for instances of Closeable

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3138?focusedWorklogId=967903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967903 ] ASF GitHub Bot logged work on KNOX-3138: Author: ASF GitHub Bot

[PR] KNOX-3138 implemented try-with-resources for Closeables [knox]

2025-04-28 Thread via GitHub
dk2k opened a new pull request, #1033: URL: https://github.com/apache/knox/pull/1033 KNOX-3138 implemented try-with-resources for Closeables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (KNOX-3138) Implement try-with-resources for instances of Closeable

2025-04-28 Thread Dmitrii Kriukov (Jira)
Dmitrii Kriukov created KNOX-3138: - Summary: Implement try-with-resources for instances of Closeable Key: KNOX-3138 URL: https://issues.apache.org/jira/browse/KNOX-3138 Project: Apache Knox I

[jira] [Work logged] (KNOX-3137) 3 collections are updated, but never accessed

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3137?focusedWorklogId=967901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967901 ] ASF GitHub Bot logged work on KNOX-3137: Author: ASF GitHub Bot

[PR] KNOX-3137 removed three unused collections [knox]

2025-04-28 Thread via GitHub
dk2k opened a new pull request, #1032: URL: https://github.com/apache/knox/pull/1032 KNOX-3137 removed three unused collections -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Created] (KNOX-3137) 3 collections are updated, but never accessed

2025-04-28 Thread Dmitrii Kriukov (Jira)
Dmitrii Kriukov created KNOX-3137: - Summary: 3 collections are updated, but never accessed Key: KNOX-3137 URL: https://issues.apache.org/jira/browse/KNOX-3137 Project: Apache Knox Issue Type:

[jira] [Work logged] (KNOX-3136) Write-only object in class Matcher line 209

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3136?focusedWorklogId=967899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967899 ] ASF GitHub Bot logged work on KNOX-3136: Author: ASF GitHub Bot

[PR] KNOX-3136 removed write-only object [knox]

2025-04-28 Thread via GitHub
dk2k opened a new pull request, #1031: URL: https://github.com/apache/knox/pull/1031 KNOX-3136 removed write-only object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (KNOX-3136) Write-only object in class Matcher line 209

2025-04-28 Thread Dmitrii Kriukov (Jira)
Dmitrii Kriukov created KNOX-3136: - Summary: Write-only object in class Matcher line 209 Key: KNOX-3136 URL: https://issues.apache.org/jira/browse/KNOX-3136 Project: Apache Knox Issue Type: B

[jira] [Work logged] (KNOX-3135) Incorrect string format in GatewayWebsocketHandler

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3135?focusedWorklogId=967897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967897 ] ASF GitHub Bot logged work on KNOX-3135: Author: ASF GitHub Bot

[PR] KNOX-3135 Fixed incorrect string format [knox]

2025-04-28 Thread via GitHub
dk2k opened a new pull request, #1030: URL: https://github.com/apache/knox/pull/1030 KNOX-3135 Fixed incorrect string format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (KNOX-3135) Incorrect string format in GatewayWebsocketHandler

2025-04-28 Thread Dmitrii Kriukov (Jira)
Dmitrii Kriukov created KNOX-3135: - Summary: Incorrect string format in GatewayWebsocketHandler Key: KNOX-3135 URL: https://issues.apache.org/jira/browse/KNOX-3135 Project: Apache Knox Issue

[jira] [Work logged] (KNOX-3134) pac4jCsrfToken cookie Secure and HttpOnly attributes are not set

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3134?focusedWorklogId=967847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967847 ] ASF GitHub Bot logged work on KNOX-3134: Author: ASF GitHub Bot

Re: [PR] KNOX-3134: Set Secure and HttpOnly attributes for pac4jCsrfToken Cookie [knox]

2025-04-28 Thread via GitHub
hanicz commented on PR #1029: URL: https://github.com/apache/knox/pull/1029#issuecomment-2835461489 > Looks good. My only note is do we have a usecase where this needs to be false? i.e. when we are not using https, what happens then does it break? There could be cases where users might not

[jira] [Work logged] (KNOX-3134) pac4jCsrfToken cookie Secure and HttpOnly attributes are not set

2025-04-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KNOX-3134?focusedWorklogId=967813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967813 ] ASF GitHub Bot logged work on KNOX-3134: Author: ASF GitHub Bot

[PR] KNOX-3134: Set Secure and HttpOnly attributes for pac4jCsrfToken Cookie [knox]

2025-04-28 Thread via GitHub
hanicz opened a new pull request, #1029: URL: https://github.com/apache/knox/pull/1029 ## What changes were proposed in this pull request? pac4jCsrfToken cookie Secure and HttpOnly attributes are not set The fix is included in 5.1.5 https://www.pac4j.org/5.1.x/docs/release-no

[jira] [Created] (KNOX-3134) pac4jCsrfToken cookie Secure and HttpOnly attributes are not set

2025-04-28 Thread Jira
Tamás Hanicz created KNOX-3134: -- Summary: pac4jCsrfToken cookie Secure and HttpOnly attributes are not set Key: KNOX-3134 URL: https://issues.apache.org/jira/browse/KNOX-3134 Project: Apache Knox