Re: [VOTE] Release RC 2 as Apache Knox 1.3.0

2019-07-22 Thread Sandeep Moré
I am running into issues testing Zeppelin on a non-secure cluster, I can create an empty notebook but I cannot open it, when I try to open it I get prompted for login. I could not find error messages in Knox logs, I was able to confirm websockets are working and I can see the data going back and fo

Re: [VOTE] Release RC 2 as Apache Knox 1.3.0

2019-07-22 Thread Sandeep Moré
) * Checked Topology Port Mapping feature * Tested Yarn UI Was able to test Zeppelin, there could be a problem with my cluster configuration. Downloaded Apache Zeppelin 0.8.1 and it works as expected. Best, Sandeep On Mon, Jul 22, 2019 at 11:51 AM Sandeep Moré wrote: > I am running into iss

Re: [DISCUSS] Planning for Apache Knox 1.4

2019-11-01 Thread Sandeep Moré
Thanks for starting the planning thread Larry ! Agree with the theme and the release date for 1.4.0. +1 Best, Sandeep On Thu, Oct 31, 2019 at 11:53 AM larry mccay wrote: > Folks - > > Out last release with end of July, I apologize for the delay in starting > the planning thread for 1.4. > > We

Re: [DISCUSS] - Integrating Knox with Swagger

2019-11-13 Thread Sandeep Moré
Agreed +1 ! On Wed, Nov 13, 2019 at 4:05 PM larry mccay wrote: > + dev@... > > Thank you for the idea! > > Yes, I am familiar with Swagger and that would be huge for our current > APIs and others that may come along. > I think the effort to add a swagger filter or the like will be only one > par

Re: [VOTE] Release Apache Knox 1.4.0 - RC 1

2020-04-16 Thread Sandeep Moré
I am getting the same error as well, looks like the key used to sign the release has changed. It also appears that we do not have the tar.gz file for knox-1.4.0-src (i.e. knox-1.4.0-src.tar.gz) *gpg --list-keys | grep -B 2 Larrypub rsa4096 2013-10-08 [SC] CB951DC938391FE207682BB582F9C371

Re: [VOTE] Release Apache Knox 1.4.0 - RC 2

2020-04-20 Thread Sandeep Moré
+1 Found couple of issues in knoxcli while testing this release. Both of these bugs, KNOX-2315 and KNOX-2349 are not a regression so we can move ahead with the release. Checked: * Downloaded and bu

Re: [VOTE] Release Apache Knox 1.4.0 - RC 3

2020-04-24 Thread Sandeep Moré
Thank you Larry! +1 Checked: * Downloaded and built from source * Checked LICENSE and NOTICE files * Verified GPG/SHA signatures for Knox source, Knox and Knoxshell release packages * Installed pseudo-distributed instance (Mac OS X ) * Checked Zeppelin * Checked CM Service Discovery with kerberos

Re: [DISCUSS] Release an Apache Knox v1.5.0

2020-11-06 Thread Sandeep Moré
+1 Thanks Larry, Nov end sounds good to wrap up release just before the holidays. Best, Sandeep On Thu, Nov 5, 2020 at 3:57 PM larry mccay wrote: > All - > > There has been 7 months or so since we released 1.4.0. > While we haven't done any particular feature scoping as part of a release > them

Re: Travis CI migration

2020-11-12 Thread Sandeep Moré
Thanks for checking Kevin! On Thu, Nov 12, 2020 at 11:01 AM Kevin Risden wrote: > FYI this has been completed by Gavin. Nothing should really change - just > its https://travis-ci.com/github/apache/knox instead of travis-ci.org. > > Kevin Risden > > > On Thu, Nov 12, 2020 at 10:13 AM Kevin Risde

Re: Cookies get cleaned by knox

2021-08-11 Thread Sandeep Moré
Hello Eric, Knox should not be deleting cookies. These cookies by jupyterhub, I presume get added after successful authentication by Knox right? it could be that the cookies are not getting properly set (check the host and path on the cookies). What do you see in Knox logs? On Mon, Aug 9, 2021 at

Re: Cookies get cleaned by knox

2021-08-12 Thread Sandeep Moré
; On Aug 12, 2021, at 04:21, Sandeep Moré wrote: > > > > Hello Eric, > > Knox should not be deleting cookies. These cookies by jupyterhub, I > presume > > get added after successful authentication by Knox right? it could be that > > the cookies are not getting

Re: [VOTE] Release Apache Knox 1.6.0 - RC 1

2021-10-22 Thread Sandeep Moré
On Fri, Oct 22, 2021 at 2:02 PM Sandeep Moré > wrote: > > > **Update: vote -1 > > I discovered a bug while testing the logout feature so I need to withdraw > > my vote. > > This is the error I see when I click the logout button >

Re: [VOTE] Release Apache Knox 1.6.0 - RC 2

2021-10-27 Thread Sandeep Moré
Thank you Sandor! Here is my +1 * Downloaded and built from source * Checked LICENSE and NOTICE files * Verified GPG/SHA signatures for Knox source, Knox and Knoxshell release packages * Installed pseudo-distributed instance (Mac OS X ) * Checked logout page * Checked KnoxShell samples * Tested H

Re: [VOTE] Release Apache Knox 1.6.0 - RC 4

2021-11-03 Thread Sandeep Moré
Thanks Sandor, here is my +1 * Downloaded and built from source * Checked LICENSE and NOTICE files * Verified GPG/SHA signatures for Knox source, Knox and Knoxshell release packages * Installed pseudo-distributed instance (Mac OS X ) * Tested Knox logout * Tested Knoxshell samples * Tested HDFSUI

Re: [DISCUSS] Release an Apache Knox v1.6.0

2021-11-13 Thread Sandeep Moré
+1 ! On Fri, Nov 12, 2021 at 11:00 AM Attila Magyar wrote: > Hi, > > Now that the release is out, can we merge the log4j change as well? > > https://github.com/apache/knox/pull/488 > > Attila > > On Tue, Oct 12, 2021 at 9:00 PM larry mccay wrote: > > > Let's please make sure that communication

Re: Topology redeployment changes

2021-11-23 Thread Sandeep Moré
Thanks Sandor! I am also CC'ing the dev mailing list. Thank you for the patch and the heads up :) On Tue, Nov 23, 2021 at 4:12 AM Sandor Molnar wrote: > Hi again! > > I just wanted to add some clarification on the above news. If you actually > change the topology (adding a comment is not consid

Re: [VOTE] Release Apache Knox 1.6.1 - RC 1

2022-01-07 Thread Sandeep Moré
On Tue, Jan 4, 2022 at 3:47 PM Sandeep Moré wrote: > Thank you Sandor, > While checking the NOTICE file I realized that we have copyright date as > 2021, it is minor and I am okay with it since RC was spun up last year but > given this would be released this year wanted to bring it t

Re: [DISCUSS] - Upgrading Log4j to 2.17.1 on Knox 1.6 line

2022-01-13 Thread Sandeep Moré
Awesome! that sounds great Sandor, thanks! On Thu, Jan 13, 2022 at 5:46 AM Sandor Molnar wrote: > Hi folks, > > with our recent v1.6.1 release (an announcement is about to be sent out) we > are on 2.16.0 to mitigate the infamous CVE-2021-44228 >

[DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread Sandeep Moré
All, I would like to get community input on the process of merging Webshell feature to master. *Problem*: 1. We would like to get this feature in by 2.0 but also would like to make sure we get a proper reviews for this feature. 2. Given the size of the feature, keeping it up to date with recent co

Re: [DISCUSS] Feature branch for Webshell feature

2022-01-21 Thread Sandeep Moré
t; We can consider the flow detailed in [1] and there may be other details > that I will look for. > > 1. https://cwiki.apache.org/confluence/display/HADOOP2/HowToCommit > > On Fri, Jan 21, 2022 at 12:12 PM Sandeep Moré > wrote: > > > All, > > I would like

Re: [DISCUSS] Feature branch for Webshell feature

2022-01-24 Thread Sandeep Moré
Folks, We have a new branch "webshell" with commit history from PR https://github.com/apache/knox/pull/477 let me know if anyone has questions or concerns. Best, Sandeep On Fri, Jan 21, 2022 at 2:24 PM Sandeep Moré wrote: > Thanks Larry and Phil, > Makes sense, we could s

Re: [DISCUSS] Sign in with Ethereum Provider

2022-07-05 Thread Sandeep Moré
+1 On Mon, Jul 4, 2022 at 6:20 AM Sandor Molnar wrote: > Hi Larry! > > I think it is a great idea! I can't wait to read the KIP. > > Thanks, > Sandor > > On Sat, Jul 2, 2022 at 5:18 PM larry mccay wrote: > > > Hello All - > > > > I am considering adding a new federation provider that would enab

Re: Pac4J CVE Remediation for Knox

2022-08-02 Thread Sandeep Moré
Thank you Jerome! For now we will upgrade to v4.5.6 to mitigate the CVE risks while we chart out the plan to move to JDK 11. This will force us to think about moving to JDK 11, which I think is time for us to move. On Mon, Aug 1, 2022 at 3:31 AM Jérôme LELEU wrote: > Hi, > > I'm back from vac

[KNOX-2631] Webshell feature review

2022-10-02 Thread Sandeep Moré
Hello All, I would like to get code review for the Webshell feature from the community. I would like to get this in by the 2.0.0 release and am really excited about the feature. This is the link to the PR: https://github.com/apache/knox/pull/639 This is the JIRA: https://issues.apache.org/jira/bro

Re: [DISCUSS] Removing Travis CI integration from apache Knox builds

2022-10-25 Thread Sandeep Moré
Thank you Sandor for the discussion. Github actions seems to be the recommended way, thank you so much for the initiative! Best, Sandeep On Tue, Oct 25, 2022 at 4:45 AM Sandor Molnar wrote: > This issue is tracked under > https://issues.apache.org/jira/browse/KNOX-2830. > > On Tue, Oct 25, 2022

Re: [DISCUSS] Release Apache Knox v2.0.0

2022-10-28 Thread Sandeep Moré
My +1 for Knoxgiving too. On Fri, Oct 28, 2022 at 3:18 PM larry mccay wrote: > I am +1 on a Knoxgiving release for 2.0. > > @Philip Zampino - would you like to volunteer as the > Release Manager for 2.0? > > > On Fri, Oct 28, 2022 at 2:55 PM Phil Zampino wrote: > > > Knox 1.6.1 was released in

Re: [VOTE] Release Apache Knox 2.0.0

2023-02-07 Thread Sandeep Moré
While testing Webshell ran into KNOX-2877 and KNOX-2872 So -1 for RC1 from me as well :( On Tue, Feb 7, 2023 at 3:31 PM Phil Zampino wrote: > > Admin UI (given the Angular upgrade): > >- Creat

[Discuss] KNOX-2877 - HA support for Knox WebShell

2023-02-07 Thread Sandeep Moré
Hello Folks, I would like to solicit ideas and opinions from the community about HA support for Webshell feature. The problem is as follows: Say we have an HA deployment of Apache Knox (Knox Host 1 and Knox Host 2) fronted by a LB (nginx or trafik). Say, the LB is distributing requests in round ro

Re: [Discuss] KNOX-2877 - HA support for Knox WebShell

2023-02-07 Thread Sandeep Moré
Currently we don't. We don't have any usecase to LB knox specific service (like Webshell). On Tue, Feb 7, 2023 at 4:05 PM Phil Zampino wrote: > How do we handle this for other WebSocket interactions in Knox? > > On Tue, Feb 7, 2023 at 4:02 PM Sandeep Moré wrote: > > &

Re: [DISCUSS] Token State Service implementation cleanup

2023-11-14 Thread Sandeep Moré
Thank you for starting the thread Sandor. You bring up valid points and pain that we had to go through with these implementations :) I am in favor of removing these as well. My concern is around folks currently using any of these impls. Should we deprecate it this release (but keep the support and

Re: [DISCUSS] Token State Service implementation cleanup

2023-11-14 Thread Sandeep Moré
#x27;d say no, it's not necessary. > > Sandor > > On Tue, Nov 14, 2023 at 1:05 PM Sandeep Moré > wrote: > > > Thank you for starting the thread Sandor. You bring up valid points and > > pain that we had to go through with these implementations :) > > I

[Discuss] Knox as External Authorizer in Kubernetes

2024-02-09 Thread Sandeep Moré
Hello Folks, With workloads moving towards Kubernetes we should think about using Knox for authentication and authorization in Kubernetes. I created a design document (KIP) which includes design and usecases I can think of: https://cwiki.apache.org/confluence/display/KNOX/KIP-16+Knox+as+External+A

Re: [Discuss] Knox as External Authorizer in Kubernetes

2024-02-12 Thread Sandeep Moré
l. > Look forward to reading it closely! > > thanks > > --larry > > On Fri, Feb 9, 2024 at 3:39 PM Sandeep Moré wrote: > > > Hello Folks, > > With workloads moving towards Kubernetes we should think about using Knox > > for authentication and authorization i

Re: [Discuss] Knox as External Authorizer in Kubernetes

2024-02-22 Thread Sandeep Moré
> etc) locally and not rely on other services or redirects, etc. > > So, it isn't necessarily an assumption for the entire feature but may be > required for things like LDAP. > > > On Mon, Feb 12, 2024 at 7:56 PM Sandeep Moré > wrote: > > > Thanks Larry! >

Re: [DISCUSS] Release Apache Knox v2.1.0

2024-02-29 Thread Sandeep Moré
Great! +1 for releasing v2.1.0. Thank you so much for volunteering as release manager! On Tue, Feb 27, 2024 at 9:43 AM Sandor Molnar wrote: > Now, that Attila updated his JIRAs too, the previously mentioned 50+ items > are a huge underestimation as there are almost 90 issues fixed since our >

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-02-24 Thread Sandeep Moré
Thanks for starting the discussion Larry. I can take care of the Logout of KnoxSSO KIP, been thinking about it a lot lately, I will start a KIP and kickoff a discussion. The cloud KIP sounds great, we can finally iron out the Azure AD integration with this one. I haven't looked at the Jiras but

[DISCUSS] KIP-10 KnoxSSO Logout Flow

2018-02-25 Thread Sandeep Moré
Hello All, I am kickstarting a discussion about KnoxSSO logout flow, I created a KIP page for it https://cwiki.apache.org/confluence/display/KNOX/KIP-10+KnoxSSO+Logout+Flow In the coming week I am planning on adding more sections for CAS, OpenID connect etc. as I research them more. In the mean t

Re: KnoxSSO OpenID Error: Unable to renew the session. The session store may not support this feature

2018-03-04 Thread Sandeep Moré
Hello Ryan, Can you check the value of the State parameter ? you should see it in the request and response. The state attribute is stored in the session so if is not getting properly passed we might have an issue there (KNOX-1190 is tracking this), the current implementation of SessionStore for P

Knox builds failing

2018-03-08 Thread Sandeep Moré
It looks like Knox builds are failing with the error "Error creating assembly archive bin: posix is not a legal value for this attribute" It seems to be related to KNOX-1200 (which interestingly does not have commit associated to it) Changing the version back to 14 seems to fix the builds

Re: A question about rewrite rules!

2018-04-28 Thread Sandeep Moré
You should be able to, just like for *.js, you need to add filter rules for *.css content type. This wiki talks about the rewrites rules https://cwiki.apache.org/confluence/display/KNOX/2017/08/14/Understanding+Rewrite+Rules+for+Apache+Knox Best, Sandeep On Sat, Apr 28, 2018 at 5:11 AM, 可乐味的咖啡 <

Re: Knox Rule Pattern is Matching HTML Tags Beyond the Pattern

2018-05-21 Thread Sandeep Moré
Can you share Debug logs for this rewrite ? this might tell us a bit more about what pattern Knox is seeing. This should not be happening, especially given that this rule is not hooked up to html content filter. On Mon, May 21, 2018 at 6:48 PM, Shawn Weeks wrote: > The organization I work for n

Re: Knox Rule Pattern is Matching HTML Tags Beyond the Pattern

2018-05-22 Thread Sandeep Moré
t/yarn/cluster/nodes/unhealthy > 2018-05-21 18:22:01,631 DEBUG hadoop.gateway > (UrlRewriteProcessor.java:rewrite(164)) > - Rewrote URL: /cluster/nodes/rebooted, direction: OUT via implicit rule: > YARNUI/yarn/outbound/cluster to URL: https://mgt1.example.org:443/ > gateway/default/yarn/cl

Re: Knox Rule Pattern is Matching HTML Tags Beyond the Pattern

2018-05-22 Thread Sandeep Moré
working with is using the > Hortonworks distribution which is still on 0.12. > > > Thanks > > Shawn Weeks > > ________ > From: Sandeep Moré > Sent: Tuesday, May 22, 2018 8:51:41 AM > To: dev@knox.apache.org > Subject: Re: Knox Rule Patte

Re: Other Interesting Rewrite Failures

2018-05-22 Thread Sandeep Moré
This explains it, I was having headache trying to figure out the odd behavior. The problem here is that Knox combines all the rewrites rules into filters and then it tries to do a best match based on the pattern, in case where there is no match Knox engine will go for the next best match, This sho

Re: Other Interesting Rewrite Failures

2018-05-23 Thread Sandeep Moré
You can, using scoped rewrite rules and not making them global, I believe this is the JIRA for that https://issues.apache.org/jira/browse/KNOX-711 On Tue, May 22, 2018 at 4:25 PM, Shawn Weeks wrote: > Does that mean you can't have rules in two different services with the > same pattern? I was

Re: socket.io in knox

2018-06-19 Thread Sandeep Moré
g to control rewrites. I guess addressing (a) and > (d) would help in the longer term. > > Hope this makes sense and I haven't completely missed the point :-) It > does explain the behaviour I'm seeing. How would you like to proceed here? > > Cheers, > /ailuropod4 >

Re: socket.io in knox

2018-06-20 Thread Sandeep Moré
order in which this handler is added. Best, Sandeep On Wed, Jun 20, 2018 at 1:13 AM Sandeep Moré wrote: > Hello ailuropod4, > > Excellent analysis ! > you are right about (a), (b), (c) and (d). > (a) and (b) can be easily fixed, we should have caught this earlier :( we > do need

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-04 Thread Sandeep Moré
+1 Thanks Larry, sounds good. Best, Sandeep On Wed, Jul 4, 2018 at 1:18 PM larry mccay wrote: > All - > > We are done to around 4 JIRAs marked as 1.1.0 issues. > > I am thinking about branching for the release where we can continue the > work on the final changes but also start the planning of

Re: Branch for Apache Knox v1.1.0 Release

2018-07-09 Thread Sandeep Moré
Thanks Larry ! I am working on a fix and hopefully will try to land it in 1.1.0, thanks ! Best, Sandeep On Mon, Jul 9, 2018 at 7:41 AM larry mccay wrote: > All - > > I have branched for the Apache Knox 1.1.0 release. > We still have a couple service defs to get in before the first RC one of > w

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-19 Thread Sandeep Moré
Hello Larry, Yes, I have seen those exceptions, they seem to be happening fairly consistently and only for KnoxSSO redirects when trying to access admin UI, I am taking a look at them as we speak, will open up a JIRA for it as well. It would be good if we can get it in, I will try to get the fix o

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-19 Thread Sandeep Moré
t; On Thu, Jul 19, 2018 at 4:19 PM, Sandeep Moré > wrote: > > > Hello Larry, > > > > Yes, I have seen those exceptions, they seem to be happening fairly > > consistently and only for KnoxSSO redirects when trying to access admin > UI, > > I am taking a look at t

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-19 Thread Sandeep Moré
; Awesome, @sandeep! > I'll keep an eye out. > > Once that lands, you can bump this thread and I'll cut the RC. > Obviously, we will need it in both master and v1.1.0 branches. > > On Thu, Jul 19, 2018 at 4:19 PM, Sandeep Moré > wrote: > > > Hello Larry, > >

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-19 Thread Sandeep Moré
Perfect, thanks ! On Thu, Jul 19, 2018 at 6:12 PM larry mccay wrote: > Awesome - just checked it out and I will kick off a new build shortly! > > On Thu, Jul 19, 2018 at 6:01 PM, Sandeep Moré > wrote: > > > Hello Larry, > > > > I committed the fix to master

Re: [DISCUSS] Planning for Apache Knox 1.1.0 Release

2018-07-20 Thread Sandeep Moré
gt;> > > > * sometimes my host is HW14155.home and sometimes it is > >> new-host-5.home > >> > > for > >> > > > some reason > >> > > > > >> > > > Given that all of our samples and docs assume localhost and OOTB &

Re: [VOTE] Release Apache Knox 1.1.0 RC 2

2018-07-25 Thread Sandeep Moré
Thanks Larry ! +1 * Downloaded and built from source (with Java 1.8.0_101) * Checked LICENSE and NOTICE files * Verified GPG/MD5/SHA signatures for Knox source, Knox and Knoxshell release packages (zip files) * Installed pseudo-distributed instance (Mac OS X ) * Ran through knox tests * Checked we

Re: [VOTE] Release Apache Knox 1.1.0 RC 3

2018-07-26 Thread Sandeep Moré
+1 * Downloaded and built from source * Checked LICENSE and NOTICE files * Verified GPG/MD5/SHA signatures for Knox source, Knox and Knoxshell release packages (zip files) * Installed pseudo-distributed instance (Mac OS X ) * Ran through knox tests * Checked websocket functionality * Checked Topol

Re: logsearch with knox 0.12.0: errors without the trailing /

2018-07-28 Thread Sandeep Moré
If this is for a request going in then you can create a rewrite rule that matches *logsearch and rewrite it to logsearch/. If this does not work, you can try modifying the request in a custom dispatch, NiFi dispatch

Re: NPE from HttpServletRequest in Dispatch when query string contains special characters.

2018-09-10 Thread Sandeep Moré
Do you have a stack trace for the NPE ? On Mon, Sep 10, 2018 at 10:21 AM Theyaa Matti wrote: > Anyone has any idea how to resolve this please? > > On Fri, Sep 7, 2018 at 1:24 PM Theyaa Matti wrote: > >> I am using custom Dispatch class in my service.xml to handle html >> entities and I am getti

Re: gateway-adapter module question

2018-09-23 Thread Sandeep Moré
Most likely this is because these classes were added after the refactoring, but yes they all should have @Deprecated tag. On Sun, Sep 23, 2018 at 1:19 PM Kevin Risden wrote: > As far as I understand, the gateway-adapter module was created to move from > org.apache.hadoop.gateway.* to org.apache.

Re: gateway-adapter module question

2018-09-23 Thread Sandeep Moré
is. > > > > Kevin Risden > > > > > > On Sun, Sep 23, 2018 at 1:24 PM Sandeep Moré > > wrote: > > > >> Most likely this is because these classes were added after the > >> refactoring, > >> but yes they all should have @Depr

Re: Apache Knox and dependency handling in pom.xml

2018-09-25 Thread Sandeep Moré
Hello Kevin, Good idea, I would say using properties to list all the versions would be a good start, there are some dependencies that were included in the sub-modules for the unit tests to play well (I think kerby is an example) so, consolidating versions might have some unintended consequences, a

Re: [DISCUSS] Planning for Apache Knox 1.2.0 Release

2018-11-14 Thread Sandeep Moré
Great, thanks Kevin ! On Wed, Nov 14, 2018 at 11:25 AM Kevin Risden wrote: > There is one jira left for 1.2.0 related to YARN rewrite rules. It is > currently being tested manually. Still hoping to get an RC built in the > next day or so. > > Kevin Risden > > > On Fri, Nov 9, 2018 at 9:07 AM Kev

Re: [DISCUSS] Site on Git?

2018-12-04 Thread Sandeep Moré
You can find documentation on site maintenance and publishing here - https://cwiki.apache.org/confluence/display/KNOX/Site+Maintenance On Tue, Dec 4, 2018 at 3:42 PM Lars Francke wrote: > Ah well...that might be the flaw in my idea ;-) > > I assumed that while the site is hosted in SVN it's pu

Re: [DISCUSS] move from git-wip to gitbox

2018-12-10 Thread Sandeep Moré
Thanks for starting the discussion Kevin, Sorry for jumping in late, I think we should move proactively so we have time to iron out issues with the migration, if any, so here's my +1 Best, Sandeep On Mon, Dec 10, 2018 at 9:32 AM Kevin Risden wrote: > The below line is from the notice. Maybe a V

Re: [VOTE] Release Apache Knox 1.2.0 RC 4

2018-12-13 Thread Sandeep Moré
Thank you Kevin, +1 (binding) * Downloaded and built from source * Checked LICENSE and NOTICE files * Verified GPG/SHA signatures for Knox source, Knox and Knoxshell release packages * Installed pseudo-distributed instance (Mac OS X ) * Ran through knox tests * Checked websocket functionality * Ch

Re: [VOTE] Move Apache Knox repo to Gitbox

2018-12-18 Thread Sandeep Moré
+1 On Tue, Dec 18, 2018 at 6:12 AM Kevin Risden wrote: > Apache is moving off of their old Git servers (git-wip) to Gitbox. See > this post for details: > > https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories > > We just finished the Apache Knox 1.2.0 release so it would b

Re: [DISCUSS] Enter the Pull Request?

2019-02-07 Thread Sandeep Moré
I second Phil. Personally, I am more comfortable with the patches mostly because of their simplistic nature but do like PRs as they are more community friendly (helps people review, comment, critique) and looks like they have become OSS standard as Phil pointed out. So +1 from me. Best, Sandeep O

Re: [DISCUSS] Planning for Apache Knox 1.3.0 Release

2019-02-15 Thread Sandeep Moré
+1 and thanks for starting the Discuss thread Larry ! This is a pretty comprehensive list and captures a lot of items that are good candidates for 1.3.0 release, thanks for consolidating other items as well, like SSO integration with Azure AD and logout. I shifted back to finishing up these feature

Re: [DISCUSS] Enter the Pull Request?

2019-02-19 Thread Sandeep Moré
t; >> > > > > > default > >> > > > > > > currently. Something that we currently don't get with > patches > >> > > > > > > > >> > > > > > > If we go this route we should make sure we have the

Re: [DISCUSS] Knox Shell command for downloading the public cert from a Knox instance

2019-02-25 Thread Sandeep Moré
I agree with Kevin, having to endpoints would be a bit confusing for the users (HTTP for this and HTTPS for others) as well as from the code perspective, also I am not sure how resource intensive two jetty servers would be, I hear that it is not that bad. On Mon, Feb 25, 2019 at 9:54 AM Kevin Ris