Re: [REVIEW] (KNOX-647) Rename LDAP artifacts from test to demo

2016-01-14 Thread larry mccay
I agree with Sumit. As long as none of the scripting that is used by Ambari is explicitly referencing the jar and no classes/packages are renamed out from under a script then rolling upgrades and Ambari support for various versions should remain intact. I don't see any reason for this to affect 0

Re: [REVIEW] (KNOX-647) Rename LDAP artifacts from test to demo

2016-01-14 Thread Sumit Gupta
The patch looks like a simple (i.e. harmless) refactor/rename to me. I don¹t see any upgrade issues unless people are writing their own launchers, which doesn¹t make sense. In any case no one should be using the test/demo ldap in production. +1 Sumit. On 1/13/16, 3:16 PM, "Kevin Minder" wrote:

[REVIEW] (KNOX-647) Rename LDAP artifacts from test to demo

2016-01-13 Thread Kevin Minder
Hey Everyone, I’m thinking about pushing this to master. I’ve attached a format-patch to the jira for review. https://issues.apache.org/jira/browse/KNOX-647 https://issues.apache.org/jira/secure/attachment/12782120/0001-KNOX-647-Rename-LDAP-artifacts-from-test-to-demo.patch The basic questions