I've been looking into static build tools for Apache Calcite and others. It
turns out there is a lot of overlap. I took some time to see how this would
apply to Apache Knox. I'm sending this message to gauge Apache Knox
interest in this approach.
Some of the tools include:
* spotbugs [1] (newer ve
+1 - it's always good to have static build tools. Other projects I work on
use the pmd + checkstyle plugins to enforce code cleanliness.
Colm.
On Thu, Apr 26, 2018 at 5:21 AM, Kevin Risden wrote:
> I've been looking into static build tools for Apache Calcite and others. It
> turns out there is
+1 from me, Kevin!
On Thu, Apr 26, 2018 at 4:57 AM, Colm O hEigeartaigh
wrote:
> +1 - it's always good to have static build tools. Other projects I work on
> use the pmd + checkstyle plugins to enforce code cleanliness.
>
> Colm.
>
> On Thu, Apr 26, 2018 at 5:21 AM, Kevin Risden wrote:
>
> > I
+1 Sounds like a good improvement.
On Thu, Apr 26, 2018 at 8:51 AM, larry mccay wrote:
> +1 from me, Kevin!
>
>
> On Thu, Apr 26, 2018 at 4:57 AM, Colm O hEigeartaigh
> wrote:
>
> > +1 - it's always good to have static build tools. Other projects I work
> on
> > use the pmd + checkstyle plugins
Thanks everyone. I'll create a JIRA and start on getting a patch together
over the next week or so.
"pmd + checkstyle plugins"
Those are good ones as well. Thanks Colm.
Kevin Risden
On Thu, Apr 26, 2018 at 7:59 AM, Philip Zampino wrote:
> +1 Sounds like a good improvement.
>
> On Thu, Apr 26,
Created https://issues.apache.org/jira/browse/KNOX-1284
Kevin Risden
On Fri, Apr 27, 2018 at 10:10 PM, Kevin Risden wrote:
> Thanks everyone. I'll create a JIRA and start on getting a patch together
> over the next week or so.
>
> "pmd + checkstyle plugins"
>
> Those are good ones as well. Than
Getting back to this after some time and not destabilizing the 1.0 and 1.1
releases.
I split KNOX-1284 into two JIRAs to address separately.
- KNOX-1441 [1] - Spotbugs
- KNOX-1442 [2] - Forbiddenapis
The patches themselves are pretty large due to minor changes across the
code base from fixing the
KNOX-1441 and KNOX-1442 are now in master. This will identify any problems
with spotbugs or forbiddenapis.
As part of the review process for KNOX-1441 and KNOX-1442, it was
identified that wildcard imports are not preferred. Colm had previously
recommended checkstyle so I went ahead and created KN
