Re: 'tidy-bot' now running (experimentally)

2016-09-23 Thread Todd Lipcon
On Fri, Sep 23, 2016 at 10:57 AM, Dan Burkert wrote: > Another couple of things: > > Tidy-bot uses a very strict definition of lexicographic ordering, e.g. it > prefers: > > #include "kudu/client/value-internal.h" > #include "kudu/client/value.h" > > Whereas we have typically preferred the revers

Re: 'tidy-bot' now running (experimentally)

2016-09-23 Thread Dan Burkert
Another couple of things: Tidy-bot uses a very strict definition of lexicographic ordering, e.g. it prefers: #include "kudu/client/value-internal.h" #include "kudu/client/value.h" Whereas we have typically preferred the reverse ordering. I'm +1 on tidy bot's way, since it allows imports to be o

Re: Kudu Build: Unsupported options error

2016-09-23 Thread Dan Burkert
Valencia, If these are just issues with building libstdc++ in thirdparty, then the effect on Kudu should be negligible. libstdc++ is *only* used (linked-to) when building with thread sanitizer (TSAN) support. Right now we unconditionally build thirdparty libraries for TSAN when compiling on Linu

Kudu Build: Unsupported options error

2016-09-23 Thread Valencia Serrao
Hi All, I am building Kudu on ppc64le. However, while building Kudu's thirdparty "libstdc++-v3", I have encountered following errors: Error1: clang-3.8: error: unsupported option '-print-multi-os-directory' Error2: clang-3.8: error: unknown argument: '-mlong-double-64' I couldn't find any docume