答复: A question about the culling row-sets in ’Tablet::CaptureConsistentIterators’ function

2018-05-09 Thread helifu
Thanks, Todd. I did not notice this comment. Sorry for that:( 何李夫 2017-04-10 16:06:24 -邮件原件- 发件人: dev-return-5994-hzhelifu=corp.netease@kudu.apache.org 代表 Todd Lipcon 发送时间: 2018年5月8日 23:03 收件人: dev 主题: Re: A question about the culling row-sets in ’Tablet

Re: A question about the culling row-sets in ’Tablet::CaptureConsistentIterators’ function

2018-05-08 Thread Todd Lipcon
Hi 何李夫 Yes, it seems there's a TODO in the code here about supporting the open-ended intervals: if (spec != nullptr && spec->lower_bound_key() && spec->exclusive_upper_bound_key()) { // TODO : support open-ended intervals I think fixing this would be relatively straight-forward by adding s

A question about the culling row-sets in ’Tablet::CaptureConsistentIterators’ function

2018-05-07 Thread helifu
Hi all, In our kudu source code, we just cull row-sets when lower_bound_key and exclusive_upper_bound_key are existing at the same time. And if not, we will grab all row-sets of the tablet, then have to seek the key in ‘CFileSet::Iterator::PushdownRangeScanPredicate’ for the unnecessary row-set