[GitHub] [incubator-kvrocks] git-hulk merged pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
git-hulk merged PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kvroc

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
git-hulk commented on code in PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553#discussion_r867353455 ## README.md: ## @@ -42,7 +42,7 @@ Kvrocks has the following key features: ## Building kvrocks requirements - + Review Comment: ```suggestion `

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
git-hulk commented on code in PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553#discussion_r867353455 ## README.md: ## @@ -42,7 +42,7 @@ Kvrocks has the following key features: ## Building kvrocks requirements - + Review Comment: ```suggestion

[GitHub] [incubator-kvrocks] aleksraiden commented on a diff in pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
aleksraiden commented on code in PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553#discussion_r867346429 ## README.md: ## @@ -56,7 +56,7 @@ sudo yum install -y epel-release && sudo yum install -y git gcc gcc-c++ make sna # Ubuntu/Debian sudo apt update -sud

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
git-hulk commented on code in PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553#discussion_r867338382 ## README.md: ## @@ -56,7 +56,7 @@ sudo yum install -y epel-release && sudo yum install -y git gcc gcc-c++ make sna # Ubuntu/Debian sudo apt update -sudo a

[GitHub] [incubator-kvrocks] ShooterIT commented on a diff in pull request #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
ShooterIT commented on code in PR #553: URL: https://github.com/apache/incubator-kvrocks/pull/553#discussion_r867337366 ## README.md: ## @@ -42,7 +42,7 @@ Kvrocks has the following key features: ## Building kvrocks requirements - + Review Comment: ```suggestion

[GitHub] [incubator-kvrocks] aleksraiden opened a new pull request, #553: Missing googletest dependency for Ubuntu/Debian

2022-05-07 Thread GitBox
aleksraiden opened a new pull request, #553: URL: https://github.com/apache/incubator-kvrocks/pull/553 Update README.md (missing test dependency for Ubuntu/Debian) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-kvrocks] git-hulk merged pull request #550: Refactoring Dockerfile

2022-05-07 Thread GitBox
git-hulk merged PR #550: URL: https://github.com/apache/incubator-kvrocks/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kvroc

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #550: Refactoring Dockerfile

2022-05-07 Thread GitBox
git-hulk commented on PR #550: URL: https://github.com/apache/incubator-kvrocks/pull/550#issuecomment-1120176171 OK, I'm ok to go head with the current way. We can improve this before GitHub Actions supporting the arm64 runner. -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-kvrocks] ShooterIT commented on pull request #550: Refactoring Dockerfile

2022-05-07 Thread GitBox
ShooterIT commented on PR #550: URL: https://github.com/apache/incubator-kvrocks/pull/550#issuecomment-1120175261 @git-hulk Maybe i didn't describe clearly. I think `release.yaml` is OK since it runs in the background. But daily Ci takes much time. Let's keep current solution. We ca

[GitHub] [incubator-kvrocks] foxdalas commented on pull request #550: Refactoring Dockerfile

2022-05-07 Thread GitBox
foxdalas commented on PR #550: URL: https://github.com/apache/incubator-kvrocks/pull/550#issuecomment-1120172710 > @foxdalas Can you rollback the cross compile in `release.yaml`? For Daily CI, 197 minutes was ok to me, but it's too slowly to release. My point was we want to guarantee the c