Re: [Discuss] Apache Kylin Component Owner Plan

2018-02-02 Thread Billy Liu
+1 I will set up the code coverage check rule for each PR when the Gitbox migration is done. 2018-02-02 15:34 GMT+08:00 hongbin ma : > +1 > > suggest to establish more solid rules on test coverage. I've seen lots > patches without proper tests > > On Fri, Feb 2, 2018 at

Re: [VOTE] Migrate to gitbox

2018-02-02 Thread Billy Liu
Yes. For document update, PR will against the document branch. 2018-02-02 23:27 GMT+08:00 Jingke He : > +1 does that mean we can also pr to website document ? hejingke > 邮箱:hejin...@gmail.com 签名由 网易邮箱大师 定制 在2018年02月02日 17:24,Jianhua Peng 写道: +1 On > 2018/02/01 02:37:20,

Re: [VOTE] Migrate to gitbox

2018-02-02 Thread Jingke He
+1 does that mean we can also pr to website document ? hejingke 邮箱:hejin...@gmail.com 签名由 网易邮箱大师 定制 在2018年02月02日 17:24,Jianhua Peng 写道: +1 On 2018/02/01 02:37:20, Billy Liu wrote: > Hi all, > > I'm starting this vote to migrate Apache Kylin repository from git-wip > to

Re: [Discuss] Apache Kylin Component Owner Plan

2018-02-02 Thread Jingke He
+1 hejingke 邮箱:hejin...@gmail.com 签名由 网易邮箱大师 定制 在2018年02月02日 19:13,Roger Shi 写道: +1 I can take the owner of component "Query Engine". On 02/02/2018, 7:09 PM, "Li Yang" wrote:    +1        I can take the owner of component "Metadata" to offload Shaofeng.    And Roger is a

Re: 答复: Can't delete segment

2018-02-02 Thread ShaoFeng Shi
Thank you You Cheng; And if you want to contribute a patch, that is welcomed! 2018-02-02 21:29 GMT+08:00 张 佑铖 : > 1. KYLIN-3228 has > been created. > 2. > * > > > 发件人: ShaoFeng

答复: Can't delete segment

2018-02-02 Thread 张 佑铖
1. KYLIN-3228 has been created. 2. * 发件人: ShaoFeng Shi 发送时间: 2018年2月2日 19:02 收件人: dev 主题: Re: Can't delete segment Hi yousheng, it looks be a bug; when deleting a job, it should

[jira] [Created] (KYLIN-3228) Should remove the related segment when deleting a job

2018-02-02 Thread youcheng.zhang (JIRA)
youcheng.zhang created KYLIN-3228: - Summary: Should remove the related segment when deleting a job Key: KYLIN-3228 URL: https://issues.apache.org/jira/browse/KYLIN-3228 Project: Kylin Issue

Re: [Discuss] Apache Kylin Component Owner Plan

2018-02-02 Thread kangkaisen
+1. Thanks Shaofeng. It's more friendly for new contributors. -- Sent from: http://apache-kylin.74782.x6.nabble.com/

Re: [Discuss] Apache Kylin Component Owner Plan

2018-02-02 Thread Roger Shi
+1 I can take the owner of component "Query Engine". On 02/02/2018, 7:09 PM, "Li Yang" wrote: +1 I can take the owner of component "Metadata" to offload Shaofeng. And Roger is a better person to own "Query Engine" than me. :-) Cheers Yang

Re: [Discuss] Apache Kylin Component Owner Plan

2018-02-02 Thread Li Yang
+1 I can take the owner of component "Metadata" to offload Shaofeng. And Roger is a better person to own "Query Engine" than me. :-) Cheers Yang On Fri, Feb 2, 2018 at 6:58 PM, kangkaisen wrote: > +1. Thanks Shaofeng. > > It's more friendly for new contributors. > > >

Re: Can't delete segment

2018-02-02 Thread ShaoFeng Shi
Hi yousheng, it looks be a bug; when deleting a job, it should remove the related segment. Could you please report a JIRA? Next time, you don't need to purge the cube; you can backup the metadata to disk, edit the cube json manually, and then restore it. 2018-02-02 18:29 GMT+08:00 张 佑铖

Can't delete segment

2018-02-02 Thread 张 佑铖
Hi kylin team, After a job been error, I click drop instead of discard by mistake, I can't find the job anywhere, but it still remain an empty segment in cube. When I call restful request /{cubeName}/segs/{segmentName} it returns Cannot delete segment '' as its status is not READY. Discard

Re: Welcome new Apache Kylin committer: Jianhua Peng

2018-02-02 Thread kangkaisen
Welcome Jianhua! -- Sent from: http://apache-kylin.74782.x6.nabble.com/

Re: [Discuss] Patch +1 Policy

2018-02-02 Thread kangkaisen
+1. Thanks Shaofeng. It's great. Code review is necessary. -- Sent from: http://apache-kylin.74782.x6.nabble.com/

Re: [Discuss] Patch +1 Policy

2018-02-02 Thread ShaoFeng Shi
Hi Jianhua, Thanks for your suggestion. In another thread, Billy is proposing to use apache gitbox to host Kylin repository. After that, we may switch to GitHub PR for review and merge. If so, I think the review board is no longer recommended. 2018-02-02 17:20 GMT+08:00 ShaoFeng Shi

[jira] [Created] (KYLIN-3227) Automatically remove the blank at the end of lines in properties files

2018-02-02 Thread Guangyao Li (JIRA)
Guangyao Li created KYLIN-3227: -- Summary: Automatically remove the blank at the end of lines in properties files Key: KYLIN-3227 URL: https://issues.apache.org/jira/browse/KYLIN-3227 Project: Kylin

[jira] [Created] (KYLIN-3226) When user logs in with only query permission, 'N/A' is displayed in the cube's action list.

2018-02-02 Thread Peng Xing (JIRA)
Peng Xing created KYLIN-3226: Summary: When user logs in with only query permission, 'N/A' is displayed in the cube's action list. Key: KYLIN-3226 URL: https://issues.apache.org/jira/browse/KYLIN-3226

Re: [VOTE] Migrate to gitbox

2018-02-02 Thread Jianhua Peng
+1 On 2018/02/01 02:37:20, Billy Liu wrote: > Hi all, > > I'm starting this vote to migrate Apache Kylin repository from git-wip > to gitbox. Gitbox allows deeper integration with Github, enables > committers to merge, close or edit pull request in Github directly. > >

Re:[VOTE] Migrate to gitbox

2018-02-02 Thread Dayue Gao
+1 binding Regards, Dayue Gao At 2018-02-01 10:37:20, "Billy Liu" wrote: >Hi all, > >I'm starting this vote to migrate Apache Kylin repository from git-wip >to gitbox. Gitbox allows deeper integration with Github, enables >committers to merge, close or edit pull request in

Re: [Discuss] Patch +1 Policy

2018-02-02 Thread ShaoFeng Shi
Billy, this is an open discussion; A vote usually happens after the discussion. I'm not sure whether it is needed if all members are okay with it. 2018-02-02 14:56 GMT+08:00 Jianhua Peng : > +1 > > On 2018/02/02 03:10:32, ShaoFeng Shi wrote: > >

Re: [Discuss] Patch +1 Policy

2018-02-02 Thread Jianhua Peng
Hi shaofeng, We can also do the following step: 1. submit issue in https://issues.apache.org; 2. related a review request to https://reviews.apache.org/dashboard; 3. The committer can patch +1 policy in review request; 4. The committer can review patch of issue in review request. example:

Re: Welcome new Apache Kylin committer: Jianhua Peng

2018-02-02 Thread Ted Yu
Congratulations,  Jianhua ! Original message From: Luke Han Date: 2/1/18 10:02 PM (GMT-08:00) To: dev , user , Apache Kylin PMC Subject: Welcome new Apache Kylin committer: Jianhua

[jira] [Created] (KYLIN-3225) java.lang.ClassNotFoundException: org.apache.kylin.jdbc.Driver

2018-02-02 Thread Bowen Yang (JIRA)
Bowen Yang created KYLIN-3225: - Summary: java.lang.ClassNotFoundException: org.apache.kylin.jdbc.Driver Key: KYLIN-3225 URL: https://issues.apache.org/jira/browse/KYLIN-3225 Project: Kylin