[GitHub] momoxixi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java

2018-08-23 Thread GitBox
momoxixi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java URL: https://github.com/apache/kylin/pull/198#issuecomment-415633716 Hi shaofengshi, You get my point, and here is my opinion for two comments,: 1. I consider Embedded `try-catch` is a compromise plan, or it

[GitHub] shaofengshi closed pull request #200: KYLIN-3449 Allow deleting a NEW status orphan segment

2018-08-23 Thread GitBox
shaofengshi closed pull request #200: KYLIN-3449 Allow deleting a NEW status orphan segment URL: https://github.com/apache/kylin/pull/200 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark

2018-08-23 Thread GitBox
shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark URL: https://github.com/apache/kylin/pull/204#discussion_r212499697 ## File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java ## @@ -0,0

[GitHub] shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark

2018-08-23 Thread GitBox
shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark URL: https://github.com/apache/kylin/pull/204#discussion_r212499556 ## File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkBatchCubingJobBuilder2.java ##

[GitHub] shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark

2018-08-23 Thread GitBox
shaofengshi commented on a change in pull request #204: KYLIN-3442 Fact distinct columns in Spark URL: https://github.com/apache/kylin/pull/204#discussion_r212499407 ## File path: engine-spark/pom.xml ## @@ -100,6 +100,50 @@ 0.9.10 test

[GitHub] shaofengshi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java

2018-08-23 Thread GitBox
shaofengshi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java URL: https://github.com/apache/kylin/pull/198#issuecomment-415620951 Hi Momoxixi, Sorry for the late response. So you mean, the invocation of "table.checkAndPut" may throw a "RetriesExhaustedException"

[jira] [Created] (KYLIN-3510) Correct sqoopHome at 'createSqoopToFlatHiveStep'

2018-08-23 Thread Shaoxiong Zhan (JIRA)
Shaoxiong Zhan created KYLIN-3510: - Summary: Correct sqoopHome at 'createSqoopToFlatHiveStep' Key: KYLIN-3510 URL: https://issues.apache.org/jira/browse/KYLIN-3510 Project: Kylin Issue Type:

[jira] [Created] (KYLIN-3509) Allocate more memory for "Merge dictionary on yarn" step

2018-08-23 Thread Chao Long (JIRA)
Chao Long created KYLIN-3509: Summary: Allocate more memory for "Merge dictionary on yarn" step Key: KYLIN-3509 URL: https://issues.apache.org/jira/browse/KYLIN-3509 Project: Kylin Issue Type: