coveralls commented on issue #283: KYLIN-3597 fix code smells URL: https://github.com/apache/kylin/pull/283#issuecomment-427846521 ## Pull Request Test Coverage Report for [Build 3745](https://coveralls.io/builds/19403977) * **5** of **32** **(15.63%)** changed or added relevant lines in **7** files are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.004%**) to **23.295%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FBrokenEntity.java#L25) | 0 | 1 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/AppendTrieDictionary.java](https://coveralls.io/builds/19403977/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FAppendTrieDictionary.java#L120) | 0 | 1 | 0.0% | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19403977/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L52) | 1 | 3 | 33.33% | [core-common/src/main/java/org/apache/kylin/common/util/CheckUtil.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FCheckUtil.java#L30) | 0 | 3 | 0.0% | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/19403977/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L309) | 0 | 3 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L164) | 4 | 10 | 40.0% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java](https://coveralls.io/builds/19403977/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FZookeeperDistributedLock.java#L51) | 0 | 11 | 0.0% <!-- | **Total:** | **5** | **32** | **15.63%** | --> | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java](https://coveralls.io/builds/19403977/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FCubeSegmentScanner.java#L101) | 2 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L180) | 2 | 25.24% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19403977/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | <!-- | **Total:** | **7** | | --> | Totals | [![Coverage Status](https://coveralls.io/builds/19403977/badge)](https://coveralls.io/builds/19403977) | | :-- | --: | | Change from base [Build 3738](https://coveralls.io/builds/19396624): | 0.004% | | Covered Lines: | 16301 | | Relevant Lines: | 69976 | --- ##### 💛 - [Coveralls](https://coveralls.io)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services