Ted Yu created KYLIN-3081: ----------------------------- Summary: Ineffective null check in CubeController#cuboidsExport Key: KYLIN-3081 URL: https://issues.apache.org/jira/browse/KYLIN-3081 Project: Kylin Issue Type: Bug Reporter: Ted Yu Priority: Minor
{code} if (cuboidList == null || cuboidList.isEmpty()) { logger.warn("Cannot get recommend cuboid list for cube " + cubeName); } if (cuboidList.size() < top) { logger.info("Only recommend " + cuboidList.size() + " cuboids less than topn " + top); } {code} cuboidList.size() may result in NPE because the null check above doesn't have effect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)