[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
yaooqinn commented on pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777#issuecomment-878826788 please also update module name from `Kyuubi Tool Kubernetes Spark Block Cleaner` to `Kyuubi Project Spark Block Cleaner` -- This is an automated message from the Apach

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #779: Remove obsolete CODE_OF_CONDUCT.md

2021-07-12 Thread GitBox
yaooqinn commented on issue #779: URL: https://github.com/apache/incubator-kyuubi/issues/779#issuecomment-878815713 cc @zhang1002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-kyuubi-website] ulysses-you opened a new pull request #3: Add *.iml to .gitignore

2021-07-12 Thread GitBox
ulysses-you opened a new pull request #3: URL: https://github.com/apache/incubator-kyuubi-website/pull/3 Make this project friendly for idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-kyuubi] wuchunfu commented on issue #781: Fix status badges in README to point the current repo

2021-07-12 Thread GitBox
wuchunfu commented on issue #781: URL: https://github.com/apache/incubator-kyuubi/issues/781#issuecomment-878806223 @yaooqinn OK, I'll do the task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668449269 ## File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStatementInfo.scala ## @@ -0,0 +1

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
yaooqinn commented on pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777#issuecomment-878800268 can you fix the ci? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #781: Fix status badges in README to point the current repo

2021-07-12 Thread GitBox
yaooqinn commented on issue #781: URL: https://github.com/apache/incubator-kyuubi/issues/781#issuecomment-878799359 cc @wuchunfu, are you interested in this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-kyuubi-website] turboFei merged pull request #2: Refactor kyuubi website home page.

2021-07-12 Thread GitBox
turboFei merged pull request #2: URL: https://github.com/apache/incubator-kyuubi-website/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [incubator-kyuubi] timothy65535 commented on pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
timothy65535 commented on pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780#issuecomment-878794668 Thanks @yaooqinn @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-kyuubi-website] turboFei opened a new pull request #2: Refactor Kyuubi HomePage

2021-07-12 Thread GitBox
turboFei opened a new pull request #2: URL: https://github.com/apache/incubator-kyuubi-website/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [incubator-kyuubi] cutiechi closed issue #773: How to configure spark executor pod name prefix?

2021-07-12 Thread GitBox
cutiechi closed issue #773: URL: https://github.com/apache/incubator-kyuubi/issues/773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [incubator-kyuubi] cutiechi commented on issue #773: How to configure spark executor pod name prefix?

2021-07-12 Thread GitBox
cutiechi commented on issue #773: URL: https://github.com/apache/incubator-kyuubi/issues/773#issuecomment-878789490 @ulysses-you Ok, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-kyuubi] cutiechi closed issue #774: How to disable ha zk?

2021-07-12 Thread GitBox
cutiechi closed issue #774: URL: https://github.com/apache/incubator-kyuubi/issues/774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [incubator-kyuubi] cutiechi commented on issue #774: How to disable ha zk?

2021-07-12 Thread GitBox
cutiechi commented on issue #774: URL: https://github.com/apache/incubator-kyuubi/issues/774#issuecomment-878789315 @pan3793 Ok, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
ulysses-you commented on pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780#issuecomment-878789072 hi @timothy65535 the change LGTM, please rebase on latest master to trigger test -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn commented on pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#issuecomment-878785756 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn closed pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [incubator-kyuubi-website] turboFei merged pull request #1: Enable kyuubi.staged.apache.org for staging preview

2021-07-12 Thread GitBox
turboFei merged pull request #1: URL: https://github.com/apache/incubator-kyuubi-website/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [incubator-kyuubi-website] turboFei opened a new pull request #1: Enable kyuubi.staged.apache.org for staging preview

2021-07-12 Thread GitBox
turboFei opened a new pull request #1: URL: https://github.com/apache/incubator-kyuubi-website/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#discussion_r668416649 ## File path: .asf.yaml ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreem

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#discussion_r668416649 ## File path: .asf.yaml ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreem

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
pan3793 commented on a change in pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#discussion_r668415183 ## File path: .asf.yaml ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreeme

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668415174 ## File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala ## @@ -58,6 +62,12

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668414546 ## File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala ## @@ -156,6 +167,

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668413957 ## File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStatementInfo.scala ## @@ -0,0 +1

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668413699 ## File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStatementInfo.scala ## @@ -0,0 +1

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#discussion_r668413526 ## File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStatementInfo.scala ## @@ -0,0 +1

[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn edited a comment on pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#issuecomment-878762753 How about adding some unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #767: Event Tracking: For statement

2021-07-12 Thread GitBox
yaooqinn commented on pull request #767: URL: https://github.com/apache/incubator-kyuubi/pull/767#issuecomment-878762753 How about add some unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
yaooqinn commented on pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780#issuecomment-878761605 #783 merged, please trigger ci again thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #783: [KYUUBI #782] SparkProcessBuilder fails to generate SPARK_HOME after codebase migration

2021-07-12 Thread GitBox
yaooqinn commented on pull request #783: URL: https://github.com/apache/incubator-kyuubi/pull/783#issuecomment-878757566 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-kyuubi] yaooqinn closed issue #782: SparkProcessBuilder fails to generate SPARK_HOME after codebase migration

2021-07-12 Thread GitBox
yaooqinn closed issue #782: URL: https://github.com/apache/incubator-kyuubi/issues/782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #783: [KYUUBI #782] SparkProcessBuilder fails to generate SPARK_HOME after codebase migration

2021-07-12 Thread GitBox
yaooqinn closed pull request #783: URL: https://github.com/apache/incubator-kyuubi/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
yaooqinn commented on pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780#issuecomment-878749331 please wait for https://github.com/apache/incubator-kyuubi/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #783: [KYUUBI #782] SparkProcessBuilder fails to generate SPARK_HOME after codebase migration

2021-07-12 Thread GitBox
ulysses-you opened a new pull request #783: URL: https://github.com/apache/incubator-kyuubi/pull/783 ### _Why are the changes needed?_ Fix failed test ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and

[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #782: SparkProcessBuilder fails to generate SPARK_HOME after codebase migration

2021-07-12 Thread GitBox
yaooqinn opened a new issue #782: URL: https://github.com/apache/incubator-kyuubi/issues/782 ### 1. Describe the bug It causes the Github action and Travis CI fail ### 2. Environments 2.1 Versions - Kyuubi - [ ] 1.1.0 - [ ] 1.0.3 - [ ] 0.8.

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#discussion_r668387169 ## File path: .asf.yaml ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreem

[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #781: Fix status badges in README to point the current repo

2021-07-12 Thread GitBox
yaooqinn opened a new issue #781: URL: https://github.com/apache/incubator-kyuubi/issues/781 ### 1. Describe the bug ![GitHub top language](https://img.shields.io/github/languages/top/NetEase/kyuubi) [![GitHub release](https://img.shields.io/github/release/NetEase/kyuubi.svg)](ht

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
yaooqinn commented on pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780#issuecomment-878723786 cc @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-kyuubi] timothy65535 opened a new pull request #780: [KYUUBI 770] Fix flaky test: Add config to control if cancel invoke interrupt task on engine

2021-07-12 Thread GitBox
timothy65535 opened a new pull request #780: URL: https://github.com/apache/incubator-kyuubi/pull/780 ### _Why are the changes needed?_ Fix flaky test: Add config to control if cancel invoke interrupt task on engine. ``` The code passed to eventually never returned

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777#discussion_r668374585 ## File path: tools/kubernetes/spark-block-cleaner/src/main/scala/org/apache/kyuubi/tools/KubernetesSparkBlockCleaner.scala ## @@ -54,153 +56,142

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777#discussion_r668371688 ## File path: tools/kubernetes/spark-block-cleaner/src/test/scala/org.apache.kyuubi.tools/KubernetesSparkBlockCleanerTest.scala ## @@ -0,0 +1,108

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
yaooqinn commented on a change in pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777#discussion_r668371348 ## File path: tools/kubernetes/spark-block-cleaner/src/test/scala/org.apache.kyuubi.tools/KubernetesSparkBlockCleanerTest.scala ## @@ -0,0 +1,108

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
ulysses-you closed pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #777: Refactor Kyuubi kubernetes block cleaner

2021-07-12 Thread GitBox
ulysses-you opened a new pull request #777: URL: https://github.com/apache/incubator-kyuubi/pull/777 ### _Why are the changes needed?_ * fix bug as a blockMgr dir is created with no file at the begining. * simplify code * add test ### _How was this patch tested?_

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
pan3793 commented on a change in pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#discussion_r668088689 ## File path: .asf.yaml ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreeme

[GitHub] [incubator-kyuubi] Yikun commented on a change in pull request #776: Run kyuubi on kubernetes - make basic dockerfile and example

2021-07-12 Thread GitBox
Yikun commented on a change in pull request #776: URL: https://github.com/apache/incubator-kyuubi/pull/776#discussion_r667992957 ## File path: docker/Dockerfile ## @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license a

[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #758: [KYUUBI 661] Add UDF system_user

2021-07-12 Thread GitBox
zhaomin1423 commented on pull request #758: URL: https://github.com/apache/incubator-kyuubi/pull/758#issuecomment-878371360 @ulysses-you Should the system_user return the UserGroupInformation.getCurrentUser? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn commented on pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778#issuecomment-878418791 cc @WillemJiang @Apache9 @aajisaka @zjffdu @pan3793 @turboFei @ulysses-you @jhx1008 thanks -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #778: [BUILD] Enable .asf.yaml features

2021-07-12 Thread GitBox
yaooqinn opened a new pull request #778: URL: https://github.com/apache/incubator-kyuubi/pull/778 ### _Why are the changes needed?_ Follow https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features to enable `.asf.yaml` with some Github features - desc

[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #779: Remove obsolete CODE_OF_CONDUCT.md

2021-07-12 Thread GitBox
yaooqinn opened a new issue #779: URL: https://github.com/apache/incubator-kyuubi/issues/779 ### 1. Describe the feature We shall switch to use https://www.apache.org/foundation/policies/conduct.html now ### 2. Motivation ### 3. Describe the solution ###