Re: Review Request 40772: LENS-888: Limit of 4000 on total string length of dim attribute names of derived cube

2015-11-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40772/#review108282 --- Can you update the testing done? - Amareshwari Sriramadasu On No

Re: Review Request 40638: Base framework for scheduler.

2015-11-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review108280 --- lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.

Re: Review Request 40761: Query Completion email missing for some queries

2015-11-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review108283 --- Can you add unit tests? lens-server-api/src/main/java/org/apache/

[jira] [Updated] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-840: -- Attachment: LENS-840.patch > LDAP config loader should be more forgiving for attribute absense > -

[jira] [Updated] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-840: -- Status: Patch Available (was: Open) > LDAP config loader should be more forgiving for attribute a

[jira] [Updated] (LENS-123) Ability to load different instances of same driver class

2015-11-29 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-123: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

Re: Review Request 40751: LENS - 882: provide option from CLI as well to list queries by driver

2015-11-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40751/#review108285 --- lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.j

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-11-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40739/#review108288 --- lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMeta

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-11-29 Thread Amareshwari Sriramadasu
> On Nov. 13, 2015, 6:57 a.m., Pranav Agarwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1258 > > > > > > If we indeed decide to change the semantic of this meth

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-11-29 Thread Amareshwari Sriramadasu
> On Nov. 26, 2015, 9:14 a.m., Amareshwari Sriramadasu wrote: > > Deepak Barr, Is there any update on this for review comments? > > Deepak Barr wrote: > Sorry, I was occupied with something else. Will resume work on this. From > the review comments, I am thinking we should do the following

[jira] [Commented] (LENS-123) Ability to load different instances of same driver class

2015-11-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031356#comment-15031356 ] Hudson commented on LENS-123: - UNSTABLE: Integrated in Lens-Commit-Java8 #58 (See [https://buil

[jira] [Commented] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031358#comment-15031358 ] Hadoop QA commented on LENS-840: Applied patch: [LENS-840.patch|https://issues.apache.org/j

[jira] [Updated] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-840: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed. Thanks

[jira] [Created] (LENS-889) Collections to be stored in table properties should not be stored as a single property

2015-11-29 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-889: - Summary: Collections to be stored in table properties should not be stored as a single property Key: LENS-889 URL: https://issues.apache.org/jira/browse/LENS-889 Pr

[jira] [Updated] (LENS-888) Limit of 4000 on total string length of dim attribute names of derived cube

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-888: -- Issue Type: Sub-task (was: Bug) Parent: LENS-889 > Limit of 4000 on total string length o

[jira] [Commented] (LENS-888) Limit of 4000 on total string length of dim attribute names of derived cube

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031379#comment-15031379 ] Rajat Khandelwal commented on LENS-888: --- In our use case, we created a cube where tota

[jira] [Commented] (LENS-123) Ability to load different instances of same driver class

2015-11-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031383#comment-15031383 ] Hudson commented on LENS-123: - SUCCESS: Integrated in Lens-Commit #1145 (See [https://builds.ap

[jira] [Commented] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031392#comment-15031392 ] Hudson commented on LENS-840: - FAILURE: Integrated in Lens-Commit-Java8 #59 (See [https://build

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-11-29 Thread Rajat Khandelwal
> On Nov. 30, 2015, 11:24 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, > > line 24 > > > > > > Having cube.parse dependency from cube.me

[jira] [Commented] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031409#comment-15031409 ] Hudson commented on LENS-840: - SUCCESS: Integrated in Lens-Commit #1146 (See [https://builds.ap

[jira] [Commented] (LENS-123) Ability to load different instances of same driver class

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031416#comment-15031416 ] Rajat Khandelwal commented on LENS-123: --- Seems intermittent. https://builds.apache.org

[jira] [Commented] (LENS-840) LDAP config loader should be more forgiving for attribute absense

2015-11-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031419#comment-15031419 ] Rajat Khandelwal commented on LENS-840: --- Intermittent. Passed in https://builds.apach

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-11-29 Thread Amareshwari Sriramadasu
> On Nov. 30, 2015, 5:54 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, > > line 24 > > > > > > Having cube.parse dependency from cube.met

Re: Review Request 40772: LENS-888: Limit of 4000 on total string length of dim attribute names of derived cube

2015-11-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40772/ --- (Updated Nov. 30, 2015, 1:05 p.m.) Review request for lens. Bugs: LENS-888

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-11-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40739/#review108297 --- lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMeta