Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/ --- (Updated Dec. 10, 2015, 1:16 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-09 Thread Amareshwari Sriramadasu
> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179 > > > > > > I think we already have error code for parsing, can we use tha

[jira] [Commented] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050231#comment-15050231 ] Hudson commented on LENS-891: - UNSTABLE: Integrated in Lens-Commit #1147 (See [https://builds.a

[jira] [Commented] (LENS-888) Limit of 4000 on total string length of dim attribute names of derived cube

2015-12-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050232#comment-15050232 ] Hudson commented on LENS-888: - UNSTABLE: Integrated in Lens-Commit #1147 (See [https://builds.a

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Ajay Yadava
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, > > line 93 > > > > > > Please update the comment with "upda

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050219#comment-15050219 ] Rajat Khandelwal commented on LENS-270: --- Can you mention the change as observed from t

[jira] [Work started] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-09 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-270 started by Sushil Mohanty. --- > The exception thrown for no candidate fact should contain only brief error > --

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-09 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050207#comment-15050207 ] Sushil Mohanty commented on LENS-270: - In the following change NO_CANDIDATE_FACT_AVAILAB

[jira] [Updated] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-882: -- Fix Version/s: 2.5 > provide option from CLI as well to list queries by driver > -

[jira] [Commented] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050197#comment-15050197 ] Rajat Khandelwal commented on LENS-882: --- Committed. Thanks [~deepak.barr] > provide o

[jira] [Updated] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-882: -- Resolution: Fixed Status: Resolved (was: Patch Available) > provide option from CLI as we

Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-09 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/ --- Review request for lens. Bugs: LENS-270 https://issues.apache.org/jira/brow

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Ajay Yadava
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/scheduler-job-0.1.xsd, lines 102-106 > > > > > > Please add comments for these also. > > Ajay Yadava wrote: > will do

[jira] [Commented] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050183#comment-15050183 ] Hudson commented on LENS-891: - SUCCESS: Integrated in Lens-Commit-Java8 #62 (See [https://build

[jira] [Commented] (LENS-888) Limit of 4000 on total string length of dim attribute names of derived cube

2015-12-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050184#comment-15050184 ] Hudson commented on LENS-888: - SUCCESS: Integrated in Lens-Commit-Java8 #62 (See [https://build

[jira] [Commented] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050182#comment-15050182 ] Amareshwari Sriramadasu commented on LENS-872: -- [~raju.bairishetti], Seems the

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Ajay Yadava
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153 > > > > > > Needs update Sorry, I fixed it but looks like I missed it in the patch. willf

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-09 Thread Puneet Gupta
> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 115 > > > > > > Should we add error counters for kn

2.5 release planning

2015-12-09 Thread amareshwarisr .
Hi all, We should plan for 2.5 release, as 2.4 was frozen two months back. We have interesting features coming up in 2.5 : - Multiple driver support - Scheduler framework - Query submission throttling stabilized and more constraints getting added - Error codes and responses getting fixed. Volunt

[jira] [Commented] (LENS-839) Altering dimtable is losing dimtable partition cache

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050166#comment-15050166 ] Amareshwari Sriramadasu commented on LENS-839: -- [~archana.h], Can you verify th

[jira] [Updated] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-872: - Assignee: Raju Bairishetti > Download link is not correct for 2.4.0-beta in "release

[jira] [Updated] (LENS-839) Altering dimtable is losing dimtable partition cache

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-839: - Assignee: Archana H > Altering dimtable is losing dimtable partition cache > ---

[jira] [Updated] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-872: - Priority: Critical (was: Major) > Download link is not correct for 2.4.0-beta in "r

[jira] [Updated] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-872: - Description: [Release history page|http://lens.apache.org/releases/release-history.h

[jira] [Commented] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050158#comment-15050158 ] Amareshwari Sriramadasu commented on LENS-872: -- [~raju.bairishetti], The releas

[jira] [Updated] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-09 Thread Deepak Barr (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Barr updated LENS-882: - Status: Patch Available (was: Open) > provide option from CLI as well to list queries by driver > -

[jira] [Updated] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-09 Thread Deepak Barr (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Barr updated LENS-882: - Attachment: LENS-882.4.patch > provide option from CLI as well to list queries by driver > -

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review109690 --- lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInsta

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-09 Thread Amareshwari Sriramadasu
> On Dec. 7, 2015, 7:56 a.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 803 > > > > > > If sessions are getting closed at query finish, there

Re: Review Request 40751: LENS - 882: provide option from CLI as well to list queries by driver

2015-12-09 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40751/#review109688 --- Ship it! Ship It! - Amareshwari Sriramadasu On Dec. 9, 2015, 6:

[jira] [Updated] (LENS-888) Limit of 4000 on total string length of dim attribute names of derived cube

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-888: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

[jira] [Updated] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-891: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-09 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109474 --- lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDri

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-09 Thread Deepak Barr
> On Dec. 7, 2015, 7:56 a.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 803 > > > > > > If sessions are getting closed at query finish, there

Re: Review Request 40751: LENS - 882: provide option from CLI as well to list queries by driver

2015-12-09 Thread Deepak Barr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40751/ --- (Updated Dec. 9, 2015, 6:09 p.m.) Review request for lens. Changes --- U

[jira] [Created] (LENS-894) Result formatter failures should be retried

2015-12-09 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-894: - Summary: Result formatter failures should be retried Key: LENS-894 URL: https://issues.apache.org/jira/browse/LENS-894 Project: Apache Lens Issue Type: Imp

[jira] [Created] (LENS-893) Query Service should not mark queries failed in case driver is not responding in a timely manner

2015-12-09 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-893: - Summary: Query Service should not mark queries failed in case driver is not responding in a timely manner Key: LENS-893 URL: https://issues.apache.org/jira/browse/LENS-893

[jira] [Commented] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048681#comment-15048681 ] Hadoop QA commented on LENS-891: Applied patch: [LENS-891.01.patch|https://issues.apache.or

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048596#comment-15048596 ] Puneet Gupta commented on LENS-743: --- Good Question. Adding to that ... I would want a qui

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048582#comment-15048582 ] Rajat Khandelwal commented on LENS-743: --- Agree with the attempts approach. We can add

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048568#comment-15048568 ] Amareshwari Sriramadasu commented on LENS-743: -- bq. Query handle will be same,

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048560#comment-15048560 ] Amareshwari Sriramadasu commented on LENS-743: -- Note on this : Retry can actual

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048557#comment-15048557 ] Rajat Khandelwal commented on LENS-743: --- In Same id approach we won't need to add new

[jira] [Updated] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-743: -- Labels: (was: newbie) > Query failure retries for transient errors > ---

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048543#comment-15048543 ] Rajat Khandelwal commented on LENS-743: --- One major thing to consider is whether in an

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048541#comment-15048541 ] Puneet Gupta commented on LENS-743: --- *Different IDs Approach* *Pros* 1. Clean separati

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048519#comment-15048519 ] Puneet Gupta commented on LENS-743: --- Some more thoughts .. 1. We need a way to tell how m

[jira] [Updated] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-891: -- Attachment: LENS-891.01.patch > Weekly covering info for last Sunday of year and first Sunday of n

[jira] [Commented] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048416#comment-15048416 ] Rajat Khandelwal commented on LENS-891: --- Taking patch from reviewboard and attaching

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-09 Thread Rajat Khandelwal
> On Dec. 8, 2015, 9:08 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java, > > line 54 > > > > > > Not sure why this is changed only t

[jira] [Updated] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-891: -- Status: Patch Available (was: In Progress) > Weekly covering info for last Sunday of year and fir

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41033/ --- (Updated Dec. 9, 2015, 3:35 p.m.) Review request for lens. Bugs: LENS-836

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048410#comment-15048410 ] Rajat Khandelwal commented on LENS-743: --- I'm thinking creating a new query handle will

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-09 Thread Rajat Khandelwal
> On Dec. 4, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179 > > > > > > I think we already have error code for parsing, can we use that

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-09 Thread Amareshwari Sriramadasu
> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179 > > > > > > I think we already have error code for parsing, can we use tha