[jira] [Updated] (LENS-885) Cleanup of Cube test cases

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-885: -- Attachment: LENS-885.03.patch > Cleanup of Cube test cases > -- > >

[jira] [Updated] (LENS-885) Cleanup of Cube test cases

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-885: -- Status: Patch Available (was: In Progress) > Cleanup of Cube test cases > ---

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052352#comment-15052352 ] Rajat Khandelwal commented on LENS-885: --- Taking patch from reviewboard and attaching

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40739/ --- (Updated Dec. 11, 2015, 1:09 p.m.) Review request for lens. Bugs: LENS-885

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/ --- (Updated Dec. 11, 2015, 1:05 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109927 --- Deepak, can you mark the review issues as fixed/dropped accordingly

Re: 2.5 release planning

2015-12-10 Thread amareshwarisr .
Great! Deepak, to get started follow the doc at https://cwiki.apache.org/confluence/display/LENS/How+to+release+Apapche+Lens Thanks On Fri, Dec 11, 2015 at 12:06 PM, Deepak Kumar Barr (Tech_BLR) < deepak.b...@flipkart.com> wrote: > I will volunteer. > > Regards, > Deepak Kumar Barr > Bigfoot-App

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

2015-12-10 Thread Rajat Khandelwal
> On Dec. 11, 2015, 11:24 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 145 > > > > > > I did not like the fact that we need to put off p

Re: 2.5 release planning

2015-12-10 Thread Deepak Kumar Barr (Tech_BLR)
I will volunteer. Regards, Deepak Kumar Barr Bigfoot-Apps On Fri, Dec 11, 2015 at 9:46 AM, amareshwarisr . wrote: > Any volunteers please? > > On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr . > wrote: > > > Hi all, > > > > We should plan for 2.5 release, as 2.4 was frozen two months back. We

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/ --- (Updated Dec. 11, 2015, 12:02 p.m.) Review request for lens. Bugs: LENS-890

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109923 --- lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFact

[jira] [Comment Edited] (LENS-743) Query failure retries for transient errors

2015-12-10 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052190#comment-15052190 ] Puneet Gupta edited comment on LENS-743 at 12/11/15 6:13 AM: - Co

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review109920 --- lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensComman

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109919 --- lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFact

[jira] [Updated] (LENS-836) Query commands in CLI should take default value for query handle as the last executed query

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-836: - Component/s: client > Query commands in CLI should take default value for query hand

[jira] [Updated] (LENS-880) Organise utility classes in different modules

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-880: - Component/s: build > Organise utility classes in different modules > ---

[jira] [Updated] (LENS-830) Checkstyle version should be picked from project version

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-830: - Component/s: build > Checkstyle version should be picked from project version >

[jira] [Updated] (LENS-867) Do Query Comparison through individual ASTs

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-867: - Component/s: cube > Do Query Comparison through individual ASTs > --

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-10 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052190#comment-15052190 ] Puneet Gupta commented on LENS-743: --- Configurations *Retry attempts (driver specific/ Err

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41033/#review109913 --- lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryComma

Re: 2.5 release planning

2015-12-10 Thread amareshwarisr .
Any volunteers please? On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr . wrote: > Hi all, > > We should plan for 2.5 release, as 2.4 was frozen two months back. We have > interesting features coming up in 2.5 : > > - Multiple driver support > - Scheduler framework > - Query submission throttling

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Sushil Mohanty
> On Dec. 10, 2015, 10:48 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, > > line 850 > > > > > > Can you add NoCandidateDimAvailableException as w

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/ --- (Updated Dec. 10, 2015, 3:36 p.m.) Review request for lens. Changes ---

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050953#comment-15050953 ] Rajat Khandelwal commented on LENS-879: --- We might have to move away from PreCommit-Adm

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40739/#review109751 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 30, 2015, 1

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050917#comment-15050917 ] Hudson commented on LENS-879: - UNSTABLE: Integrated in Lens-Commit #1149 (See [https://builds.a

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050913#comment-15050913 ] Amareshwari Sriramadasu commented on LENS-879: -- I feel adding comments on jira

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/#review109746 --- lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCo

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050894#comment-15050894 ] Hudson commented on LENS-879: - SUCCESS: Integrated in Lens-Commit-Java8 #64 (See [https://build

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050634#comment-15050634 ] Rajat Khandelwal commented on LENS-743: --- After some offline discussions, I'm inclined

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/ --- (Updated Dec. 10, 2015, 5:01 p.m.) Review request for lens. Bugs: LENS-851

[jira] [Resolved] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-10 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti resolved LENS-872. --- Resolution: Invalid Not sure when the archival was happened for this release. Artifacts for 2.4

[jira] [Closed] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-10 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti closed LENS-872. - > Download link is not correct for 2.4.0-beta in "release-history.html" > --

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050590#comment-15050590 ] Rajat Khandelwal commented on LENS-879: --- bq. We should check if there is a way to down

[jira] [Updated] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-879: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

[jira] [Commented] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

2015-12-10 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050575#comment-15050575 ] Raju Bairishetti commented on LENS-872: --- [~amareshwari] http://archive.apache.org/dist

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109731 --- lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFact

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050559#comment-15050559 ] Sushil Mohanty commented on LENS-270: - Below are some sample error message from columns

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050542#comment-15050542 ] Ajay Yadava commented on LENS-879: -- I was curious about the metadata like git commits(in ca

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050538#comment-15050538 ] Amareshwari Sriramadasu commented on LENS-879: -- bq. I think instead of making t

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050536#comment-15050536 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v5.patch|https://issues.apache.or

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-10 Thread Deepak Barr
> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > lines 803-804 > > > > > > Please log the closing of session . Not required in l

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-10 Thread Deepak Barr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/ --- (Updated Dec. 10, 2015, 10:19 a.m.) Review request for lens. Changes ---

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050498#comment-15050498 ] Ajay Yadava commented on LENS-879: -- Thanks for the detailed response, appreciate it. My int

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-12-10 Thread Deepak Barr
> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 535 > > > > > > If closeQuery() is not called before this, which happens fo

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-10 Thread Rajat Khandelwal
> On Dec. 10, 2015, 2:58 p.m., Amareshwari Sriramadasu wrote: > > Ship It! I was thinking I'll add per-priority constraints too. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review109724 --- Ship it! Ship It! - Amareshwari Sriramadasu On Dec. 7, 2015, 2:

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050425#comment-15050425 ] Rajat Khandelwal commented on LENS-879: --- I believe that attaching patch just for the r

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Amareshwari Sriramadasu
> On Dec. 10, 2015, 8:14 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 152 > > > > > > Can it throw LensException out instead of catching a

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050399#comment-15050399 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v4.patch|https://issues.apache.or

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Rajat Khandelwal
> On Dec. 10, 2015, 1:44 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 152 > > > > > > Can it throw LensException out instead of catching a

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/ --- (Updated Dec. 10, 2015, 2:35 p.m.) Review request for lens. Bugs: LENS-851

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050366#comment-15050366 ] Ajay Yadava commented on LENS-879: -- I was not sure about the git metadata information getti

[jira] [Updated] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated LENS-879: - Attachment: LENS-879-v5.patch Changed the return type to void for scheduleJob method. > Base framework for

Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/ --- (Updated Dec. 10, 2015, 8:47 a.m.) Review request for lens. Changes ---

[jira] [Commented] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050344#comment-15050344 ] Hudson commented on LENS-882: - SUCCESS: Integrated in Lens-Commit #1148 (See [https://builds.ap

Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Ajay Yadava
> On Dec. 10, 2015, 8:29 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, > > line 57 > > > > > > return would be void. It's just to

[jira] [Commented] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050329#comment-15050329 ] Amareshwari Sriramadasu commented on LENS-879: -- [~ajayyadava], Thanks for takin

Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/#review109707 --- Ship it! lens-server-api/src/main/java/org/apache/lens/server/api

[jira] [Commented] (LENS-882) provide option from CLI as well to list queries by driver

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050304#comment-15050304 ] Hudson commented on LENS-882: - UNSTABLE: Integrated in Lens-Commit-Java8 #63 (See [https://buil

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

2015-12-10 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/#review109705 --- lens-api/src/main/resources/lens-errors.conf (lines 294 - 295)

[jira] [Updated] (LENS-879) Base framework for Scheduler.

2015-12-10 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated LENS-879: - Attachment: LENS-879-v4.patch Latest patch with all review comments addressed. > Base framework for Schedul

Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40638/ --- (Updated Dec. 10, 2015, 8:01 a.m.) Review request for lens. Changes ---