Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review110442 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 15, 2015, 8:29 a.m

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Dec. 15, 2015, 2:59 a.m.) Review request for lens. Changes ---

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta
> On Dec. 14, 2015, 1:44 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, > > line 140 > > > > > > Missing space here too. Checkstyle runs as part of "

[jira] [Created] (LENS-896) base url is not set by lens jdbc client.

2015-12-14 Thread piyush (JIRA)
piyush created LENS-896: --- Summary: base url is not set by lens jdbc client. Key: LENS-896 URL: https://issues.apache.org/jira/browse/LENS-896 Project: Apache Lens Issue Type: Bug Components:

[jira] [Updated] (LENS-896) base url is not set in lens jdbc client.

2015-12-14 Thread piyush (JIRA)
[ https://issues.apache.org/jira/browse/LENS-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] piyush updated LENS-896: Summary: base url is not set in lens jdbc client. (was: base url is not set by lens jdbc client.) > base url is not

Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40863/ --- (Updated Dec. 14, 2015, 8:45 p.m.) Review request for lens. Bugs: LENS-552

Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

2015-12-14 Thread Deepak Barr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39131/ --- (Updated Dec. 14, 2015, 3:07 p.m.) Review request for lens. Changes ---

Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

2015-12-14 Thread Deepak Barr
> On Oct. 9, 2015, 12:27 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 517 > > > > > > Can you do the same changes for explain, estimat

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/ --- (Updated Dec. 14, 2015, 8:32 p.m.) Review request for lens. Bugs: LENS-890

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal
> On Dec. 14, 2015, 6:34 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java, > > line 418 > > > > > > Add the assert back ? Added. > On Dec. 14

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal
> On Dec. 14, 2015, 6:48 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 432 > > > > > > Is cost not calculated at estimate already

Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40863/ --- (Updated Dec. 14, 2015, 8:12 p.m.) Review request for lens. Bugs: LENS-552

[jira] [Updated] (LENS-895) Add data availability based triggers in scheduler

2015-12-14 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-895: -- Component/s: server > Add data availability based triggers in scheduler >

[jira] [Created] (LENS-895) Add data availability based triggers in scheduler

2015-12-14 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-895: - Summary: Add data availability based triggers in scheduler Key: LENS-895 URL: https://issues.apache.org/jira/browse/LENS-895 Project: Apache Lens Issue Typ

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review110227 --- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNot

Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40863/#review110226 --- lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.j

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review110221 --- lens-server-api/src/main/java/org/apache/lens/server/api/query/Que

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review110202 --- lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDri

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Dec. 14, 2015, 11:50 a.m.) Review request for lens. Changes ---

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/ --- (Updated Dec. 14, 2015, 3:48 p.m.) Review request for lens. Bugs: LENS-890

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/ --- (Updated Dec. 14, 2015, 2:13 p.m.) Review request for lens. Bugs: LENS-890

[jira] [Work started] (LENS-890) Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-890 started by Rajat Khandelwal. - > Allow per-queue driver max launched queries constraints > -

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055609#comment-15055609 ] Hudson commented on LENS-270: - SUCCESS: Integrated in Lens-Commit #1153 (See [https://builds.ap