[ 
https://issues.apache.org/jira/browse/LENS-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360879#comment-15360879
 ] 

Lavkesh Lahngir edited comment on LENS-1184 at 7/4/16 6:12 AM:
---------------------------------------------------------------

{code}
SchedulerDAO schedulerDAO = new SchedulerDAO(hiveConf);
{code}
Above code is correct, however it should be called in the init() method, not in 
constructor. Lens services has a order in which they are intialized. Something 
like that. 
{code}
public SchedulerServiceImpl(CLIService cliService) throws LensException {
    super(NAME, cliService);
  }

  public synchronized void init(HiveConf hiveConf) {
    super.init(hiveConf);
    try {
      schedulerDAO = new SchedulerDAO(hiveConf);
      .....   
    } catch (LensException e) {
      log.error("Error Initialising Scheduler-service", e);
    }
  }
{code}



was (Author: lavkesh):
{code}
SchedulerDAO schedulerDAO = new SchedulerDAO(hiveConf);
{code}
Above code is correct, however it should be called in the init() method, not in 
constructor. Lens services has a order in which are thet are intialized. 
Something like that. 
{code}
public SchedulerServiceImpl(CLIService cliService) throws LensException {
    super(NAME, cliService);
  }

  public synchronized void init(HiveConf hiveConf) {
    super.init(hiveConf);
    try {
      schedulerDAO = new SchedulerDAO(hiveConf);
      .....   
    } catch (LensException e) {
      log.error("Error Initialising Scheduler-service", e);
    }
  }
{code}


> REST API for the scheduler
> --------------------------
>
>                 Key: LENS-1184
>                 URL: https://issues.apache.org/jira/browse/LENS-1184
>             Project: Apache Lens
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Ajay Yadava
>            Assignee: Ajay Yadava
>             Fix For: 2.6
>
>         Attachments: LENS-1184.patch
>
>
> For the sake of breaking in smaller commits, will publish the REST API 
> signatures with placeholders or dummy values being returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to