Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 22, 2016, 8:30 a.m.) Review request for lens. Bugs: LENS-932

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review120122 --- Ship it! Ship It! - Rajat Khandelwal On Feb. 19, 2016, 3:47

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review120120 --- Ship it! Ship It! - Amareshwari Sriramadasu On Feb. 19, 2016

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 17, 2016, 8:54 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, > > line 1680 > > > > > > Can you add another test setting only

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 19, 2016, 10:17 a.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review119426 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 16, 2016, 8:02 a.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 16, 2016, 6:34 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 924 > > > > > > How are we deciding the `2 days` value? And why are

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review119269 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 12, 2016, 11:19 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 931 > > > > > > Can you put skippedParts.size() in the log

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 15, 2016, 5:14 p.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118999 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 11, 2016, 11:56 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 883 > > > > > > Shall we skip this isEmpty check and add Fa

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 11, 2016, 6:12 p.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118851 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 11, 2016, 7:16 a.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 10, 2016, 12:25 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 907 > > > > > > Should we skip partitions after end date as

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 10, 2016, 6:55 a.m., Amareshwari Sriramadasu wrote: > > Can you verify the return status from REST API is partial when add > > partition skips partitions? Verified. - Sushil --- This is an automatically generated e-mail. To r

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 10, 2016, 12:07 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 878 > > > > > > Can we use the same method in query writing

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118631 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118630 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118601 --- Can you verify the return status from REST API is partial when add

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 4, 2016, 3:03 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 912 > > > > > > should we need to log the skipped entries ? Added log f

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

> On Feb. 4, 2016, 12:32 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 899 > > > > > > Dont see a caller of this. Am i missing any?

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- (Updated Feb. 9, 2016, 12:11 p.m.) Review request for lens. Changes ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review117800 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review117753 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetasto

Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/ --- Review request for lens. Bugs: LENS-932 https://issues.apache.org/jira/brow