Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146595 --- Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 23, 2016

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 23, 2016, 7:24 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 23, 2016, 5:33 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 585 > > > > > > How is time update happening in this flow? Can

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146511 --- Other changes look fine to me. - Amareshwari Sriramadasu On Aug

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146509 --- lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.j

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 23, 2016, 3:52 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146500 --- lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.j

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 22, 2016, 2:24 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

- Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146065 --- On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote: >

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

- Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146065 --- On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote: >

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

- Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review145315 --- On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote: >

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 18, 2016, 11:40 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1075 > > > > > > isFinished is checking for all states - fini

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, > > line 1047 > > > > > > why is this change done? > > Rajat

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 22, 2016, 1:17 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review146065 --- lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDr

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 10, 2016, 7:21 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java, > > line 56 > > > > > > no cancel here? > > Rajat Khand

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 12, 2016, 1:10 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 10, 2016, 12:31 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, > > line 1044 > > > > > > Is ctx's status not updated upon cancel? Tha

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java, > > line 56 > > > > > > no cancel here? I don't think

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 10, 2016, 12:53 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, > > line 952 > > > > > > logSegregationContext no more passed? It was u

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review145316 --- lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDr

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review145315 --- lens-server-api/src/main/java/org/apache/lens/server/api/driver/Q

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review145314 --- lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDr

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 9, 2016, 6:34 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 8, 2016, 6:35 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, > > line 1041 > > > > > > will driver status cancelled be different from query statu

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

> On July 29, 2016, 4:08 p.m., Puneet Gupta wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, > > lines 337-340 > > > > > > Do we need to syncronize this on query context to make

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144728 --- lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDr

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 4, 2016, 6:30 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144727 --- lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWrite

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 3, 2016, 2:28 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 1, 2016, 4:34 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 1, 2016, 4:33 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 1, 2016, 4:28 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- (Updated Aug. 1, 2016, 12:57 p.m.) Review request for lens. Bugs: LENS-1243

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144069 --- lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDr

Re: Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144070 --- We already have registerForCompletionNotification in driver api. S

Review Request 50600: LENS-1243: Support Asynchronous status updates from drivers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/ --- Review request for lens. Bugs: LENS-1243 https://issues.apache.org/jira/bro