On Thu, Jun 27, 2013 at 3:00 AM, Tomaz Muraus wrote:
> Cool.
>
> I have some comments and questions:
>
> 1. We should probably get rid of the "Base" suffix.
>
> All of the bases API interfaces (libcloud.compute.base, libcloud.dns.base,
> libcloud.storage.base, etc.), don't contain this suffix.
>
On Wed, Jun 26, 2013 at 8:01 PM, Jed Smith wrote:
> This looks great, Alex! I haven't studied intently, but I have a
> couple quick comments:
>
> Line 16: Yes, I think it should be a parameter on create_volume. That
> makes the implementation less awkward if a provider does not support
> snapshot
Cool.
I have some comments and questions:
1. We should probably get rid of the "Base" suffix.
All of the bases API interfaces (libcloud.compute.base, libcloud.dns.base,
libcloud.storage.base, etc.), don't contain this suffix.
2. As far as line 16 goes - Imo, having a separate method makes it mo
