Sorry for my delayed weigh-in as a committer, I was on (a rare) vacation.
As for the discussion, I agree with Marco's points. As far as I go, the
PR's I've been pinged on are either WIP or changes were requested and then
left hanging. Also as many have said, if I'm not pinged I don't usually
check on open PRs since I haven't have bandwidth for Livy development
recently. For PRs I do believe things could be better, but I also believe
that Livy's handling of open PRs is approximately the same as other
projects like Spark (not to say that's necessarily a positive). It also may
be time to start pruning hanging PRs: pinging creators on PRs left with
unaddressed change requests and closing them if there's no response in a
set time, closing PRs that have been discussed and seemingly rejected,
requesting reviewers for PRs that are active but without reviews. This is
something Spark does regularly but after 2 years we've yet to do. We could
also offer the dev list an opportunity to resurrect PRs abandoned by their
original dev before closing them if another dev wants to continue work on
it.
Alex Bozarth
Software Engineer
Center for Open-Source Data & AI Technologies
E-mail: ajboz...@us.ibm.com
GitHub: github.com/ajbozarth
505 Howard
Street
San Francisco, CA
94105
United
States
From: Marco Gaido <marcogaid...@gmail.com>
To: dev@livy.incubator.apache.org
Cc: Sid Anand <san...@apache.org>
Date: 09/02/2019 02:01 AM
Subject: [EXTERNAL] Re: Possible missing mentor(s)
Sid, answering to the PRs you pointed out, I think open meisam's PRs are:
- 1 WIP;
- 1 changes were requested and he has not done them;
- 1 I commented on it and it was stated that the feature could have been
merged if the PR is brought up to date, which hasn't so far by the
contributor.
Moreover, I have never seen on the PRs committers getting pinged. IMHO,
those PRs are stuck due to the inactivity of the contributor.
Surely we have to do more in order to be able to review more PRs, but, as
Saisai said, we are stil a small community with few active committers, so
we try and do our best.
More importantly, I think there is really no evidence at all of the alleged
bias.
In general, I think we all know that you need to be very active in the
community to avoid PRs getting stale. This is true also for bigger
communities like Spark.
So what I'd encourage is also more proactivity by the contributors. I think
the message should not be: "I open a PR and committer must immediately
merge it"; but "I open a PR, I ask for committers' help on reviews and try
and push in order to have it in if the PR is important".
Thanks,
Marco
Il giorno dom 1 set 2019 alle ore 20:52 Pat Ferrel <p...@occamsmachete.com>
ha scritto:
> Seems like some action should be taken before 2 years, even if it is to
> close the PR because it is not appropriate. Isn’t this the responsibility
> of the chair to guard against committer changes where the contributor is
> still willing? Or if a mentor is guiding the PR they should help it get
> unstalled if the contributor is still willing to make changes.
>
> The point (2 year old PRs) seems well taken. The question should be; what
> can be done about this?
>
> For what it’s worth, we are just starting to use Livy and wish it was
part
> of Spark. We would like to treat Spark as a “microservice” as a compute
> engine. The Spark team seems to want to make Spark integral to the
> architecture of ALL applications that use it. Very odd from our point of
> view.
>
> So to integrate Livy we deeply hope it doesn’t fall into disrepair and
are
> willing to help when we run into something.
>
>
> From: Sid Anand <san...@apache.org> <san...@apache.org>
> Reply: dev@livy.incubator.apache.org <dev@livy.incubator.apache.org>
> <dev@livy.incubator.apache.org>
> Date: September 1, 2019 at 11:19:00 AM
> To: dev@livy.incubator.apache.org <dev@livy.incubator.apache.org>
> <dev@livy.incubator.apache.org>
> Subject: Re: Possible missing mentor(s)
>
> "Second, if someone has a *good* and *large* contribution history, and
> actively participates in community, we will add him without doubt. Third,
> 2-year old open PRs doesn't stand anything, some reviewers left the
> community and PRs get staled, it is quite common, especially in large
> community."
>
> Meisam has 7 closed and 3 open PRs - of the 4 oldest open PRs in Livy (I
> see 4 in 2017), 2 are his. He's ranked #10 in the contributor list --
> It's not a large contribution history mostly because it takes so long to
> merge and he has been consistently active for 2 years. The size of the
> community doesn't seem a factor here with <200 closed PRs and <50
> contributors.
>
> How are you prioritizing PR merges if you think having a 2 year old open
PR
> is okay and you don't a ton of open PRs?
> -s
>
> On Sun, Sep 1, 2019 at 2:25 AM Saisai Shao <sai.sai.s...@gmail.com>
wrote:
>
> > First, we're scaling the PR review, but we only have few active
> committers,
> > so the merge may not be fast.
> > Second, if someone has a *good* and *large* contribution history, and
> > actively participates in community, we will add him without doubt.
> > Third, 2-year old open PRs doesn't stand anything, some reviewers left
> the
> > community and PRs get staled, it is quite common, especially in large
> > community.
> >
> > Sid Anand <san...@apache.org> 于2019年9月1日周日 下午4:46写道：
> >
> > > Apache projects promote contributors to committers based on
> contributions
> > > made, not on an expectation of future activity. That's the Apache way
> per
> > > my understanding. Over time, folks become inactive and busy -- life
> > > happens, I get it. May I ask what are you folks doing to scale PR
> review
> > > and merging? Are you adding new committers? Do you feel that 2-year
old
> > > open PRs is where you wish to be and is the right way to grow a
> > community?
> > >
> > > On Sun, Sep 1, 2019 at 1:46 AM Sid Anand <r39...@gmail.com> wrote:
> > >
> > > > Apache projects promote contributors to committers based on
> > contributions
> > > > made, not on an expectation of future activity. That's the Apache
way
> > per
> > > > my understanding. Over time, folks become inactive and busy -- life
> > > > happens, I get it. May I ask what are you folks doing to scale PR
> > review
> > > > and merging? Are you adding new committers? Do you feel that 2-year
> > old
> > > > open PRs is where you wish to be and is the right way to grow a
> > > community?
> > > >
> > > > -s
> > > >
> > > > On Sun, Sep 1, 2019 at 12:59 AM Saisai Shao
<sai.sai.s...@gmail.com>
> > > > wrote:
> > > >
> > > >> It's unfair to say there's underlying bias. Livy project is a
small
> > > >> project, the contributor diversity may not be as rich as popular
> > project
> > > >> like Spark, it is not fair to say that the contributions only
limits
> > to
> > > >> someones, so project is biased. There're many small Apache project
> > which
> > > >> has only few contributors, can we say those projects are biased?
> Also
> > > for
> > > >> years the committers have joined and left the community, it is
hard
> to
> > > >> track every contribution in time, as we're not a full-time Livy
open
> > > >> source
> > > >> contributors. I also have several PRs left unreviewed for years.
> It's
> > > >> quite
> > > >> common even for large project like Spark, Hadoop, there're so many
> > > >> un-merged PRs left for several years. It's unfair to say the
project
> > is
> > > >> biased, unhealthy because of some un-merged PRs.
> > > >>
> > > >> The community is small but free and open, I would deny that the
> > > community
> > > >> is unhealthy especially biased, this is an irresponsible and
> > subjective
> > > >> word.
> > > >>
> > > >> Sid Anand <san...@apache.org> 于2019年9月1日周日 上午4:20写道：
> > > >>
> > > >> > Folks!
> > > >> > We've (several devs, myself included) contacted the livy dev
list
> > and
> > > >> the
> > > >> > owners DL several times. Our PRs stagnated over a few years.
Livy
> > is a
> > > >> > central component in PayPal's Data Infra (Our data footprint is
> 80+
> > > PB).
> > > >> > The project seems pretty unhealthy. After a few years, this dev
> > moved
> > > on
> > > >> > and the state of our PR may be harder to define, with both
> absentee
> > > >> > mentors/PMC/committers and PR author.
> > > >> >
> > > >> > I see only a narrow band of contributors being merged. I hope
> there
> > is
> > > >> no
> > > >> > underlying bias, given that this would not be the Apache way. As
> > > >> mentors, I
> > > >> > hope the goal is to watch for such bias and eliminate it to
> promote
> > > >> > community health, engagement, and integrity.
> > > >> >
> > > >> > -s
> > > >> >
> > > >> > On Fri, Aug 30, 2019 at 10:22 PM Jean-Baptiste Onofré <
> > > j...@nanthrax.net>
> > > >> > wrote:
> > > >> >
> > > >> > > Hi Justin,
> > > >> > >
> > > >> > > Like Luciano, I'm also around. I've proposed couple of new
> > features
> > > >> that
> > > >> > > I plan to work on and I try to review/verify the releases.
> > > >> > >
> > > >> > > Regards
> > > >> > > JB
> > > >> > >
> > > >> > > On 21/10/2018 01:50, Justin Mclean wrote:
> > > >> > > > Hi,
> > > >> > > >
> > > >> > > > We have discussed missing mentors on the incubator general
> list,
> > > >> > > identified those who may be missing and over a couple of
months
> > > tried
> > > >> to
> > > >> > > contact your mentor in several ways but have got no reply so
> they
> > > have
> > > >> > been
> > > >> > > removed from the roster.
> > > >> > > >
> > > >> > > > If this is error, and your mentor is actually active, please
> > > >> contact me
> > > >> > > and I'll add them back to the roster.
> > > >> > > >
> > > >> > > > The IPMC will also do what it can to find extra mentors for
> > those
> > > >> > > podling that need them.
> > > >> > > >
> > > >> > > > Thanks,
> > > >> > > > Justin
> > > >> > > > (V.P. Incubator)
> > > >> > > >
> > > >> > >
> > > >> > > --
> > > >> > > Jean-Baptiste Onofré
> > > >> > > jbono...@apache.org
> > > >> > >
https://urldefense.proofpoint.com/v2/url?u=http-3A__blog.nanthrax.net&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=S1_S7Dymu4ZL6g7L21O78VQZ53vEnAyZ-cx37DPYDyo&m=79giSRK7IUn3zXaM7ySmizaESAKLZX6DfnboFN4kAmg&s=VMIWhY6PSSjQOKzhS2RpMbbVRTwPd0qvSUHUT0q3GNc&e=
> > > >> > > Talend -
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.talend.com&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=S1_S7Dymu4ZL6g7L21O78VQZ53vEnAyZ-cx37DPYDyo&m=79giSRK7IUn3zXaM7ySmizaESAKLZX6DfnboFN4kAmg&s=8a9EnolsIQYOOttVJbk4Pxu0cW-FZM-E55LJXoWHomw&e=
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>
