Re: Commit style best practices, was Re: incubator-livy-website git commit: Fix bug in merge_livy_pr.py because incubator-livy-website repo has no branch it's name started with "branch-"

e end of sentences. > > From: Marcelo Vanzin <van...@cloudera.com> > To: dev@livy.incubator.apache.org > Date: 07/20/2017 01:12 PM > Subject: Re: Commit style best practices, was Re: incubator-livy-website > git commit: Fix bug in merge_livy_pr.py because incubator-livy-web

Re: Commit style best practices, was Re: incubator-livy-website git commit: Fix bug in merge_livy_pr.py because incubator-livy-website repo has no branch it's name started with "branch-"

United States From: Marcelo Vanzin <van...@cloudera.com> To: dev@livy.incubator.apache.org Date: 07/20/2017 01:12 PM Subject: Re: Commit style best practices, was Re: incubator-livy-website git commit: Fix bug in merge_livy_pr.py bec

Re: Commit style best practices, was Re: incubator-livy-website git commit: Fix bug in merge_livy_pr.py because incubator-livy-website repo has no branch it's name started with "branch-"

+1. Bad commit messages are one of my pet peeves. Although I like periods at the end of sentences. On Thu, Jul 20, 2017 at 1:09 PM, Luciano Resende wrote: > Could we try to follow some best practices on PR title, commit message, etc? > > Some info from:

Commit style best practices, was Re: incubator-livy-website git commit: Fix bug in merge_livy_pr.py because incubator-livy-website repo has no branch it's name started with "branch-"

Could we try to follow some best practices on PR title, commit message, etc? Some info from: http://bahir.apache.org/contributing/#Creating+a+Pull+ Request - Open a pull request against the master branch - The PR title should be of the form [LIVY-] Title, where LIVY- is the