And I doubt there are many use cases where doing that will be an issue.
Ralph
> On Aug 19, 2017, at 5:35 PM, Gary Gregory wrote:
>
> The only change I am now talking about is replacing getName() with
> getCannonicalName().
>
> Gary
>
> On Aug 19, 2017 18:00, "Remko Popma" wrote:
>
>> No obj
The only change I am now talking about is replacing getName() with
getCannonicalName().
Gary
On Aug 19, 2017 18:00, "Remko Popma" wrote:
> No objection to creating logger names from Class.getCanonicalName() instead
> of Class.getName(). I assume that this means we don't need a custom
> toLogger
No objection to creating logger names from Class.getCanonicalName() instead
of Class.getName(). I assume that this means we don't need a custom
toLoggerName(Class)
method.
Question for our Scala experts: does Class.getCanonicalName() preserve the
trailing $ in Scala classes?
At some point there w
I agree.
Ralph
> On Aug 19, 2017, at 11:43 AM, Matt Sicker wrote:
>
> Canonical name sounds like it makes sense. I wonder what that evaluates to
> in other JVM languages like Scala, Kotlin, Clojure, etc., but it seems to
> make sense.
>
> On 19 August 2017 at 13:23, Dominik Psenner wrote:
>
Canonical name sounds like it makes sense. I wonder what that evaluates to
in other JVM languages like Scala, Kotlin, Clojure, etc., but it seems to
make sense.
On 19 August 2017 at 13:23, Dominik Psenner wrote:
> To me it is a simple and good solution to the problem. The first outlined
> soluti
To me it is a simple and good solution to the problem. The first outlined
solution has the pro that it would give a user more sophisticated ways to
build logger hierarchies from class names, but it is also something that
only a very small subset of users would use. We can keep that as a wish for
la
Any opposition to using the canonical name?
Gary
On Aug 14, 2017 15:28, "Gary Gregory" wrote:
> In LogManager, if we call getCanonicalName() instead of getName(), we only
> get "."s, no "$"s...
>
> How about that?
>
> Gary
>
> On Mon, Aug 14, 2017 at 3:24 PM, Gary Gregory
> wrote:
>
>> Another
[
https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134211#comment-16134211
]
Gary Gregory commented on LOG4J2-2013:
--
[~taylorp36],
May you verify please?
Gary
[
https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134111#comment-16134111
]
Dominik Psenner edited comment on LOG4NET-552 at 8/19/17 1:21 PM:
-
[
https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134111#comment-16134111
]
Dominik Psenner edited comment on LOG4NET-552 at 8/19/17 1:18 PM:
-
[
https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134111#comment-16134111
]
Dominik Psenner commented on LOG4NET-552:
-
I gave this a few thoughts and am quit
[
https://issues.apache.org/jira/browse/LOG4NET-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134105#comment-16134105
]
Dominik Psenner commented on LOG4NET-567:
-
Could the test failure relate to the f
[
https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134063#comment-16134063
]
Sachin Abaso Patil commented on LOG4NET-552:
Hi Dominik,
We have implemented
GitHub user ssachin3108 opened a pull request:
https://github.com/apache/logging-log4net/pull/16
Implemented review comments given under Pull Request
Implemented review comments given under Pull Request
https://github.com/apache/logging-log4net/pull/15
Below was questio
[
https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134061#comment-16134061
]
ASF GitHub Bot commented on LOG4NET-552:
Github user ssachin3108 closed the pull
Github user ssachin3108 closed the pull request at:
https://github.com/apache/logging-log4net/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
16 matches
Mail list logo
