[jira] [Commented] (LOG4J2-1925) Having log4j-core on the compile classpath somehow breaks compilation even if I'm not calling it

2017-08-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136372#comment-16136372 ] Ralph Goers commented on LOG4J2-1925: - I have started testing this. I commented out a

[jira] [Commented] (LOG4J2-1999) HighlightConverter converts all unrecognised levels to DEBUG

2017-08-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136302#comment-16136302 ] ASF subversion and git services commented on LOG4J2-1999: - Commit

[jira] [Commented] (LOG4J2-1584) RFC5424 layout needs better delimiter specification between message and throwable

2017-08-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136296#comment-16136296 ] Ralph Goers commented on LOG4J2-1584: - No patch is necessary. RFC5424Layout accepts a

[jira] [Resolved] (LOG4J2-1584) RFC5424 layout needs better delimiter specification between message and throwable

2017-08-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-1584. - Resolution: Not A Problem > RFC5424 layout needs better delimiter specification between message a

[jira] [Resolved] (LOG4J2-1916) Nullpointer with DirectWriteRolloverStrategy

2017-08-21 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-1916. - Resolution: Fixed Fix Version/s: 2.9 This issue was fixed with the fix for LOG4J2-1961. Pl

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
On Mon, Aug 21, 2017 at 10:27 PM, Ralph Goers wrote: > I would say look at http://logging.apache.org/log4j/2.x/ < > http://logging.apache.org/log4j/2.x/> and that paragraph entitled “API > Separation”. Then look at http://logging.apache.org/ > log4j/2.x/manual/api.html

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Ralph Goers
I would say look at http://logging.apache.org/log4j/2.x/ and that paragraph entitled “API Separation”. Then look at http://logging.apache.org/log4j/2.x/manual/api.html . The first paragraph makes it clea

[GitHub] logging-log4net issue #14: Add .NET Standard 2.0 build

2017-08-21 Thread chlowell
Github user chlowell commented on the issue: https://github.com/apache/logging-log4net/pull/14 Glad the build works. I expect CI will be blocked until there's some resolution for nunit/nunit3-vs-adapter#377, and I suppose there's also a decision to make about the exclusive locking tes

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

2017-08-21 Thread chlowell
Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r134377119 --- Diff: tests/src/log4net.Tests.csproj --- @@ -19,245 +18,25 @@ under the License. --> -http://schemas.microsoft.com/developer

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
Hi Ralph, Would you say that is your opinion or the intent of the design? And if the latter, should we adjust the Javadoc accordingly. Gary On Mon, Aug 21, 2017 at 7:31 PM, Ralph Goers wrote: > I am against encouraging users to directly acquire a Logger. > > Ralph > > > > On Aug 21, 2017, at 5

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Ralph Goers
I am against encouraging users to directly acquire a Logger. Ralph > On Aug 21, 2017, at 5:24 PM, Gary Gregory wrote: > > On Mon, Aug 21, 2017 at 6:01 PM, Ralph Goers > wrote: > >> It is actually funny that you say that. The API we provide for performing >> logging is log4j-api, not log4j-co

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
That is a much bigger topic than the one core API I am talking about. Gary On Aug 21, 2017 18:35, "Matt Sicker" wrote: > I'd rather we had a log4j-api way to initialise configuration outside the > default class initialisation path. > > On 21 August 2017 at 19:24, Gary Gregory wrote: > > > On M

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Matt Sicker
I'd rather we had a log4j-api way to initialise configuration outside the default class initialisation path. On 21 August 2017 at 19:24, Gary Gregory wrote: > On Mon, Aug 21, 2017 at 6:01 PM, Ralph Goers > wrote: > > > It is actually funny that you say that. The API we provide for performing >

[jira] [Commented] (LOG4J2-2006) LOG4j2 Syslog appender UDP message excceds limit error when over 65446 bytes

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136090#comment-16136090 ] Gary Gregory commented on LOG4J2-2006: -- I think that might only be possible if you a

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
On Mon, Aug 21, 2017 at 6:01 PM, Ralph Goers wrote: > It is actually funny that you say that. The API we provide for performing > logging is log4j-api, not log4j-core. We provide access in log4j-core for > users to customize how they configure their logging - not perform it. > I'm all about humo

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Ralph Goers
It is actually funny that you say that. The API we provide for performing logging is log4j-api, not log4j-core. We provide access in log4j-core for users to customize how they configure their logging - not perform it. Ralph > On Aug 21, 2017, at 3:42 PM, Gary Gregory wrote: > > Hi, > > When

Re: [log4j2] sys props driving me nuts

2017-08-21 Thread Matt Sicker
I won't be free until Wednesday night at the earliest. If Ralph wants to start the release before that, I'm alright with that. On 21 August 2017 at 17:43, Gary Gregory wrote: > Sweet. I've been going through the back log and picking some low-hanging > fruit as you may have noticed. Maybe others

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

2017-08-21 Thread chlowell
Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r134355177 --- Diff: tests/src/Context/LogicalThreadContextTest.cs --- @@ -17,7 +17,7 @@ // #endregion -#if NET_4_5 || NETSTANDARD1_3 +#

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

2017-08-21 Thread chlowell
Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r134354215 --- Diff: src/CompatibilityExtensions.cs --- @@ -0,0 +1,53 @@ +#region Apache License +// +// Licensed to the Apache Software Foundati

[jira] [Commented] (LOG4J2-2023) Use a class' canonical name instead of name to create its logger name

2017-08-21 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135981#comment-16135981 ] Remko Popma commented on LOG4J2-2023: - As discussed in the mailing list, the user man

Re: SocketOptions builder

2017-08-21 Thread Remko Popma
Not breaking binary comparability (so leaving it as it is) is fine. (Shameless plug) Every java main() method deserves http://picocli.info > On Aug 22, 2017, at 0:32, Gary Gregory wrote: > > To be clear, what is fine? Leaving it as is, or breaking Core BC and make > the change from "set" to "w

Re: [log4j2] sys props driving me nuts

2017-08-21 Thread Gary Gregory
Sweet. I've been going through the back log and picking some low-hanging fruit as you may have noticed. Maybe others could do the same. Gary On Mon, Aug 21, 2017 at 4:31 PM, Ralph Goers wrote: > I plan on starting the 2.9 release any day… > > Ralph > > > On Aug 21, 2017, at 3:25 PM, Gary Gregor

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
Hi, When someone calls any of the init methods like org.apache.logging.log4j.core.config.Configurator.initialize(String, ClassLoader, String), you get a Core LoggerContext, and that's what you've got to work with... Why is that a bad idea? That's the API we provide. Gary On Mon, Aug 21, 2017 at

Re: [log4j2] sys props driving me nuts

2017-08-21 Thread Ralph Goers
I plan on starting the 2.9 release any day… Ralph > On Aug 21, 2017, at 3:25 PM, Gary Gregory wrote: > > On Thu, Jul 20, 2017 at 9:05 PM, Gary Gregory > wrote: > >> On Thu, Jul 20, 2017 at 7:19 PM, Matt Sicker wrote: >> >>> I haven't been able to get to this so far this week. Been finishing

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Ralph Goers
So you are saying that your application is getting Loggers by doing LoggerContext.getLogger()? I guess I don’t really understand why that is a good idea. Are you saying you have your own custom LoggerContext and that you want to modify Log4j’s LoggerContext simply so you can modify yours? Ralp

Re: [log4j2] sys props driving me nuts

2017-08-21 Thread Gary Gregory
On Thu, Jul 20, 2017 at 9:05 PM, Gary Gregory wrote: > On Thu, Jul 20, 2017 at 7:19 PM, Matt Sicker wrote: > >> I haven't been able to get to this so far this week. Been finishing up a >> project for work. I should hopefully have enough time to merge this >> tomorrow though. >> > > Thank you for

[jira] [Resolved] (LOG4J2-1999) HighlightConverter converts all unrecognised levels to DEBUG

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1999. -- Resolution: Fixed Fix Version/s: 2.9 In git master. Please verify and close this issue.

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
My use case is that deep in the guts and call stack of my server/app, I have a specific Core LoggerContext that I should/must use. Log4j and other components must co-exist in a long-lived server that have modules that are constantly re-initialized/re-configured during development and testing phases

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Ralph Goers
Did you ask this question last week? Why is it needed? Why can’t this be handled in LogManager? Ralph > On Aug 21, 2017, at 2:10 PM, Gary Gregory wrote: > > Hi All: > > I have a need for the shortcut method > org.apache.logging.log4j.core.LoggerContext getLogger(Class) which would > use getC

Jenkins build is back to normal : Log4j 2.x #3017

2017-08-21 Thread Apache Jenkins Server
See

[jira] [Updated] (LOG4J2-1999) HighlightConverter converts all unrecognised levels to DEBUG

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1999: - Summary: HighlightConverter converts all unrecognised levels to DEBUG (was: HilightConverter con

[jira] [Updated] (LOG4J2-1999) HilightConverter converts all unrecognised levels to DEBUG

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1999: - Description: _emphasized text_On line 166 HighlightConverter maps the level in the highlight st

[jira] [Commented] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly

2017-08-21 Thread Pierrick HYMBERT (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135855#comment-16135855 ] Pierrick HYMBERT commented on LOG4J2-1086: -- Hi Ralph, agreed thanks for your fe

[jira] [Commented] (LOG4NET-567) Use new csproj format to target multiple frameworks

2017-08-21 Thread Charles Lowell (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135849#comment-16135849 ] Charles Lowell commented on LOG4NET-567: The netstandard projects use NUnit 3. I

[jira] [Assigned] (LOG4J2-1999) HilightConverter converts all unrecognised levels to DEBUG

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reassigned LOG4J2-1999: Assignee: Gary Gregory > HilightConverter converts all unrecognised levels to DEBUG >

Re: org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Matt Sicker
No object for core.LoggerContext. Too late to add it to the API, but LogManager already handles that now, right? On 21 August 2017 at 16:10, Gary Gregory wrote: > Hi All: > > I have a need for the shortcut method > org.apache.logging.log4j.core.LoggerContext getLogger(Class) which would > use ge

org.apache.logging.log4j.core.LoggerContext getLogger(Class)

2017-08-21 Thread Gary Gregory
Hi All: I have a need for the shortcut method org.apache.logging.log4j.core.LoggerContext getLogger(Class) which would use getCannonicalName(). Any objection to adding that? Gary

Jenkins JDKs

2017-08-21 Thread Ralph Goers
For future reference - https://cwiki.apache.org/confluence/display/INFRA/JDK+Installation+Matrix Ralph

Build failed in Jenkins: Log4j 2.x #3016

2017-08-21 Thread Apache Jenkins Server
See Changes: [rgoers] Change jdk name -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on ubuntu-4 (ubuntu trusty) in workspace

Build failed in Jenkins: Log4j 2.x #3015

2017-08-21 Thread Apache Jenkins Server
See Changes: [garydgregory] maven-resources-plugin 3.0.1 -> 3.0.2. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H22 (couch

Build failed in Jenkins: Log4j 2.x #3014

2017-08-21 Thread Apache Jenkins Server
See Changes: [garydgregory] [LOG4J2-2001] StyleConverter.newInstance argument validation is -- Started by an SCM change [EnvInject] - Loading node environment variables. Buildi

[jira] [Resolved] (LOG4J2-2001) StyleConverter.newInstance argument validation is incorrect

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-2001. -- Resolution: Fixed Fix Version/s: 2.9 In Git master. Please verify and close this issue.

[jira] [Commented] (LOG4J2-2001) StyleConverter.newInstance argument validation is incorrect

2017-08-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135684#comment-16135684 ] ASF subversion and git services commented on LOG4J2-2001: - Commit

Re: Build failed in Jenkins: Log4j 2.x #3013

2017-08-21 Thread Ralph Goers
I have posted to infra to try to find out how to determine what the Java home path needs to be. However, my experience is that questions posted to the infra list never get answered so I may have to create a Jira issue. Ralph > On Aug 21, 2017, at 8:33 AM, Apache Jenkins Server > wrote: > >

Re: [jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

2017-08-21 Thread kenneth mcfarland
The way docker manages secrets could an option. On Aug 21, 2017 8:32 AM, "Gary Gregory (JIRA)" wrote: [ https://issues.apache.org/jira/browse/LOG4J2-1896?page= com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=16135305#comment-16135305 ] Gary Gregory commen

[jira] [Assigned] (LOG4J2-2001) StyleConverter.newInstance argument validation is incorrect

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reassigned LOG4J2-2001: Assignee: Gary Gregory > StyleConverter.newInstance argument validation is incorrect > ---

Build failed in Jenkins: Log4j 2.x #3013

2017-08-21 Thread Apache Jenkins Server
See Changes: [rgoers] Update java build number -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu xenial

Re: SocketOptions builder

2017-08-21 Thread Gary Gregory
To be clear, what is fine? Leaving it as is, or breaking Core BC and make the change from "set" to "with" now? Gary On Thu, Aug 17, 2017 at 4:21 PM, Remko Popma wrote: > That's fine I think. > > (Shameless plug) Every java main() method deserves http://picocli.info > > > On Aug 18, 2017, at 7:1

[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135305#comment-16135305 ] Gary Gregory commented on LOG4J2-1896: -- I like the idea of abstract away the access

Build failed in Jenkins: Log4j 2.x #3012

2017-08-21 Thread Apache Jenkins Server
See -- Started by user rgoers [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu xenial) in workspace

Build failed in Jenkins: Log4j 2.x #3011

2017-08-21 Thread Apache Jenkins Server
See Changes: [rgoers] Update java build number -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu xenial

[jira] [Commented] (LOG4J2-2013) SslSocketManager does not apply SSLContext on TCP reconnect

2017-08-21 Thread Taylor Patton (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135296#comment-16135296 ] Taylor Patton commented on LOG4J2-2013: --- Checking > SslSocketManager does not appl

Build failed in Jenkins: Log4j 2.x #3010

2017-08-21 Thread Apache Jenkins Server
See -- Started by user rgoers [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu xenial) in workspace

Build failed in Jenkins: Log4j 2.x #3009

2017-08-21 Thread Apache Jenkins Server
See Changes: [rgoers] Update java build number -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu xenial

Build failed in Jenkins: Log4j 2.x #3008

2017-08-21 Thread Apache Jenkins Server
See Changes: [garydgregory] [LOG4J2-2023] Use a class' canonical name instead of name to create its -- Started by an SCM change [EnvInject] - Loading node environment variable

[jira] [Closed] (LOG4J2-2023) Use a class' canonical name instead of name to create its logger name

2017-08-21 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-2023. Resolution: Fixed In Git master. > Use a class' canonical name instead of name to create its logge

Build failed in Jenkins: Log4j 2.x #3007

2017-08-21 Thread Apache Jenkins Server
See Changes: [garydgregory] Better JUnit integration. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H22 (couchdbtest ubuntu

Re: Logger names for nested classes

2017-08-21 Thread Gary Gregory
In git master now tracked with LOG4J2-2023. Gary On Mon, Aug 21, 2017 at 8:32 AM, Matt Sicker wrote: > Calling getnCanonicalName on the Scala companion object preserves the > trailing $ as it's part of the class name itself. Thus: > > object Foo > println(Foo.getClass.getCanonicalName) > > Prin

[jira] [Commented] (LOG4J2-2023) Use a class' canonical name instead of name to create its logger name

2017-08-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135273#comment-16135273 ] ASF subversion and git services commented on LOG4J2-2023: - Commit

Build failed in Jenkins: Log4j 2.x #3006

2017-08-21 Thread Apache Jenkins Server
See Changes: [garydgregory] Better JUnit integration. -- [...truncated 458 B...] Fetching changes from the remote Git repository > git config remote.origin.url > https://git

[jira] [Created] (LOG4J2-2023) Use a class' canonical name instead of name to create its logger name

2017-08-21 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-2023: Summary: Use a class' canonical name instead of name to create its logger name Key: LOG4J2-2023 URL: https://issues.apache.org/jira/browse/LOG4J2-2023 Project: Log4j

Re: Build failed in Jenkins: Log4j 2.x #3005

2017-08-21 Thread Matt Sicker
Can we build inside Docker containers on Jenkins? This would make controlling specific compiler versions a lot easier (plus we can make an array of versions to automatically run tests on that way). On 21 August 2017 at 00:58, Apache wrote: > I guess it was changed from getPid() to pid() after 15

Re: Logger names for nested classes

2017-08-21 Thread Matt Sicker
Calling getnCanonicalName on the Scala companion object preserves the trailing $ as it's part of the class name itself. Thus: object Foo println(Foo.getClass.getCanonicalName) Prints out "Foo$". More complete example (using ammonite, a Scala repl thing): $ amm Loading... Welcome to the Ammonite

Re: Scala web site

2017-08-21 Thread Matt Sicker
The styles are all broken: https://logging.apache.org/log4j/scala/log4j-api-scala_2.11/index.html On 20 August 2017 at 13:08, Ralph Goers wrote: > The Scala web site is now published at http://logging.apache.org/ > log4j/scala/index.html . > I ha

[jira] [Commented] (LOG4NET-552) Incorrect behavior of RollingFileAppender while rolling files, if multiple processes appending into same file

2017-08-21 Thread Dominik Psenner (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135036#comment-16135036 ] Dominik Psenner commented on LOG4NET-552: - You can reference a custom implementat

Re: [jira] [Commented] (LOG4NET-552) Incorrect behavior of RollingFileAppender while rolling files, if multiple processes appending into same file

2017-08-21 Thread Dominik Psenner
On 21 Aug 2017 10:37 a.m., "Sachin Abaso Patil (JIRA)" wrote: [ https://issues.apache.org/jira/browse/LOG4NET-552?page= com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=16134885#comment-16134885 ] Sachin Abaso Patil commented on LOG4NET-552: ---

[GitHub] logging-log4net pull request #16: Implemented review comments given under Pu...

2017-08-21 Thread jbaehr
Github user jbaehr commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/16#discussion_r134177639 --- Diff: src/Appender/FileAppender.cs --- @@ -371,21 +371,22 @@ public abstract class LockingModelBase { priva

[jira] [Commented] (LOG4NET-552) Incorrect behavior of RollingFileAppender while rolling files, if multiple processes appending into same file

2017-08-21 Thread Sachin Abaso Patil (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134885#comment-16134885 ] Sachin Abaso Patil commented on LOG4NET-552: Yes, we can implement this fix a