Re: Json Template Layout

2020-05-17 Thread Ralph Goers
See https://cwiki.apache.org/confluence/display/LOGGING/Logging+to+ELK . This is what I get when using the Layout and configuration in Logging in the Cloud. Ralph > On May 17, 2020, at 4:18 PM, Ralph Goers wrote: > > > >>

Re: Json Template Layout

2020-05-17 Thread Ralph Goers
To be clear, while I could easily merge the PR for you I am sure you would like to do it yourself now that you have commit privileges. Ralph > On May 17, 2020, at 2:37 PM, Volkan Yazıcı wrote: > > Thanks so much for the thorough review Ralph, really appreciated! I > will address issues you hav

Re: Json Template Layout

2020-05-17 Thread Ralph Goers
> On May 17, 2020, at 2:37 PM, Volkan Yazıcı wrote: > > Thanks so much for the thorough review Ralph, really appreciated! I > will address issues you have raised. > > [As a side note, I have pushed changes containing performance > improvements and benchmark results. The module is still depende

Re: Json Template Layout

2020-05-17 Thread Volkan Yazıcı
Thanks so much for the thorough review Ralph, really appreciated! I will address issues you have raised. [As a side note, I have pushed changes containing performance improvements and benchmark results. The module is still dependency free and performance-wise pretty good.] > all the default templ

Re: [Log4j] Potential simplification to java9 builds?

2020-05-17 Thread Ralph Goers
I kind of doubt it. Logging runs up against this primarily because Oracle dropped support for sun.reflect.Reflection at the same time they added StackWalker. Most everything else had years to switch to a replacement. https://www.elastic.co/blog/elasticsearch-java-9-and-beyond

Re: [Log4j] Potential simplification to java9 builds?

2020-05-17 Thread Matt Sicker
Maven and Ant are a couple places that likely needed custom solutions, but probably not applicable here. Maybe something in Commons? I tried looking at a few random projects, but I'm not seeing anything. Spring Framework might have something. On Sun, 17 May 2020 at 13:03, Volkan Yazıcı wrote: > >

Re: [Log4j] Potential simplification to java9 builds?

2020-05-17 Thread Volkan Yazıcı
Maybe a naive question, but... Does anybody know how other Apache projects deal with this? Do they also require multiple JDKs to be present at compile time? Do they also employ `java9` directory work arounds as in log4j? On Sat, Apr 11, 2020 at 6:39 PM Matt Sicker wrote: > > I was playing around

Re: [ANNOUNCEMENT] Welcome Volkan Yazici

2020-05-17 Thread Volkan Yazıcı
I am speechless, thanks so much Ralph! That means a lot coming from you. I will do my best push the project forward. On Sun, May 17, 2020 at 12:19 AM Ralph Goers wrote: > > > > Hi, > > it is my pleasure to announce to the community that Volkan Yazici has joined > our ranks as a new Committer. >

Re: [Log4j] Potential simplification to java9 builds?

2020-05-17 Thread Matt Sicker
Yikes, that sounds similar to OSGi. Adding modules makes testing into more of an integration exercise since traditional JUnit usage assumes a flat class path. On Sun, May 17, 2020 at 00:10 Ralph Goers wrote: > I played around with this today. I don’t think it is possible to make the > tests work