Re: [log4cxx] Short filename options

2022-01-02 Thread Robert Middleton
Thinking about this a bit more still, I think we can do this in two ways to make everything work properly. We can check for the __cpp_lib_string_view macro and/or _MSVC_LANG(because windows always needs to be different), and if the compiler supports std::string view we use that at compile-time to

Re: [log4cxx] Short filename options

2022-01-02 Thread Thorsten Schöning
Guten Tag Robert Middleton, am Sonntag, 2. Januar 2022 um 02:38 schrieben Sie: > 2. Create a constexpr function that we control[...] > 3. Use std::string_view(for C++17) or > boost::string_view(pre-c++17).[...] Just to make sure I understand correctly: The difference between 2 and 3 is using a cu

Re: [log4cxx] Short filename options

2022-01-02 Thread Tobias Frost
On Sat, Jan 01, 2022 at 08:38:43PM -0500, Robert Middleton wrote: > The full path is already in the compiled code anyway, this would > simply add the ability to get the filename from the full path(so > another member to the LocationInfo class). I can see certain > circumstances where it is useful