Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3394 - Allow substitution of system properties and environment variables in shorthand variables introduced in LOG4J2-3341

2022-02-06 Thread Ralph Goers
See my reply. If you have an alternate way to implement this feel free. But trying to do it during the course of “normal” properties processing seems like it would be very messy. Ralph > On Feb 6, 2022, at 1:55 PM, Carter Kozak wrote: > > I have added a few review comments on this change >

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3394 - Allow substitution of system properties and environment variables in shorthand variables introduced in LOG4J2-3341

2022-02-06 Thread Carter Kozak
I have added a few review comments on this change https://github.com/apache/logging-log4j2/commit/b69b7b802539d87aab6b51aca0a0df8a669ce6ee -ck On Sun, Feb 6, 2022, at 12:38, rgo...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > rgoers pushed a commit

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3394 - Allow substitution of system properties and environment variables in shorthand variables introduced in LOG4J2-3341

2022-02-06 Thread Carter Kozak
-1 see GitHub comments regarding recursive lookup evaluation https://github.com/apache/logging-log4j2/commit/6d6ff5b85bbdba8895c41de5c5b6049e07635395 -ck > On Feb 6, 2022, at 12:39, rgo...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > rgoers pushed