Re: LOG4J2-3022 AsyncLogger with JDBC Appender PoolingDriver not concurrent

not concurrent > <https://issues.apache.org/jira/browse/LOG4J2-3022>. > > @Gary Gregory , you appear to be the most active > regarding JDBC appender. Hence your expertise will be much appreciated. But > of course anybody is welcome to chime in to examine the issue. > > Cheers! >

Re: What is going on with Master?

FWIW but not master, I've been building release-2.x lately over and over without issues aside from the rare random failure. G On Sun, Feb 7, 2021 at 2:37 PM Matt Sicker wrote: > I'm not getting errors in log4j-api, though it's possible some test is > missing a JUnit annotation which is causing

Re: Procedure on accepting GitHub PRs

I wonder if we could give ourselves guidelines like: - any change to an algorithm is not trivial (I know, i know, every line of code can be considered an algorithm) - any change created by a tool is trivial, like clean ups that remove trailing whitespace, reflectors code and so on. The issue is th

Re: Putting a ribbon around 2.14.1?

I'm going to do a wee bit of testing in my work env with MongoDb in the meantime... Gary On Thu, Jan 28, 2021, 10:38 Ralph Goers wrote: > Sure. I’m busy with $dayjob stuff anyway. > > Ralph > > > On Jan 28, 2021, at 4:02 AM, Volkan Yazıcı > wrote: > > > > For 2.14.1, would you wait for the res

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

d the introduced fix has already broken the > backward compatibility. See LOG4J2-2961 > <https://issues.apache.org/jira/browse/LOG4J2-2961> for details. Hence, it > should be okay. > > On Tue, Jul 14, 2020 at 11:59 PM Gary Gregory > wrote: > > > On Tue, Jul 14, 2020 a

Re: Putting a ribbon around 2.14.1?

Since we are adding adding a feature, we should be at 2.15.0 IMO. Gary On Sat, Jan 9, 2021, 11:23 Volkan Yazıcı wrote: > Hello, > > Shall we release 2.14.1? I really want to get the next release out of the > door in particular for the following changes: > > LOG4J2-2972 Refactor AsyncAppender an

Re: Deleting log4j-layout-jackson* modules from master

-jackson* modules from master > > Changing package names would require every user of the Log4j API to have > to change their code. We are not going to do that to our users. That is one > of the reasons folks have stuck with Log4j 1.x for so long. I would be -1 > on any changes that re

Re: Deleting log4j-layout-jackson* modules from master

pi or log4j-core. > > Ralph > > > On Dec 30, 2020, at 1:02 PM, Gary Gregory > wrote: > > > > Another thing for 3.0 is when to change the package name so you can have > > 2.x and 3.x in the same class loader without things blowing left and > right.

Re: Deleting log4j-layout-jackson* modules from master

Another thing for 3.0 is when to change the package name so you can have 2.x and 3.x in the same class loader without things blowing left and right. Just like you can have 1.x and 2.x at the same time. Gary On Wed, Dec 30, 2020, 14:47 Ralph Goers wrote: > If we are going to deprecate them we ne

Re: Deleting log4j-layout-jackson* modules from master

On Tue, Dec 29, 2020 at 4:52 PM Volkan Yazıcı wrote: > Hello, > > I propose deleting all the following 4 modules from master: > > log4j-layout-jackson > log4j-layout-jackson-json > log4j-layout-jackson-xml > log4j-layout-jackson-yaml > > The most (only?) used one, JsonLayout, is, IMHO, superseded

Re: [log4j] Release log4j-tools

> very often. Certainly not as frequently as log4j itself. It hardly ever > changes. It needs an independent versioning scheme. > > Ralph > > > On Dec 10, 2020, at 1:50 PM, Gary Gregory > wrote: > > > > I think the log4j-tools version should be set to 2.14.0

Re: [log4j] Release log4j-tools

I think the log4j-tools version should be set to 2.14.0 for a RC to match the release of log4j. Thoughts? Gary On Thu, Dec 10, 2020, 15:45 Ralph Goers wrote: > OK. Then I guess I forgot since it has been so long. > > Ralph > > > On Dec 10, 2020, at 1:09 PM, Gary Gregory &g

Re: [log4j] Release log4j-tools

to release something with known security problems. > > Ralph > > > On Dec 3, 2020, at 8:09 AM, Gary Gregory wrote: > > > > Hi All: > > > > We've never released from > > https://gitbox.apache.org/repos/asf?p=logging-log4j-tools.git and I'm

Re: Log4Go

I'm always up for learning something new :-) Gary On Wed, Dec 9, 2020, 16:29 Ralph Goers wrote: > The company I work for has started using Go for some of the middleware > components we are developing. I have looked at several logging frameworks > for Go and have not been impressed by any of the

Re: [VOTE] Move Log4PHP to dormant status

+1 Gary On Wed, Dec 9, 2020, 16:20 Ralph Goers wrote: > I started a discussion several days ago regarding moving Log4PHP to > dormant status and have gotten no feedback. Given there has been no > development activity in years and there is no one actively working on the > project it seems it sho

[log4j] Release log4j-tools

Hi All: We've never released from https://gitbox.apache.org/repos/asf?p=logging-log4j-tools.git and I'm currently using a SNAPSHOT build. Any thoughts on releasing from there? Gary

Re: Log4j JSON layout template Uris enum

TW, I am really happy this (un?)fortunate occasion triggered another > committer to review the JTL code base. Feels like a win for me. ;P > > On Wed, Nov 18, 2020 at 12:28 AM Gary Gregory > wrote: > > > [Please take this constructively despite my string words] > > > >

Re: Log4j JSON layout template Uris enum

them > > to a final class with a private ctor. Should I? > > > > On Tue, Nov 17, 2020 at 9:25 PM Gary Gregory > wrote: > > > > > Hi all, > > > > > > Why is this an enum and not a class? > > > > > > Gary > > > > > >

Fwd: Log4j JSON layout template Uris enum

Hi all, Why is this an enum and not a class? Gary

Re: Jenkins build failure in JSON template module

Thank you Volkan! :-) Gary On Tue, Nov 17, 2020, 08:12 Volkan Yazıcı wrote: > revapi complaints. Fixed. > > On Mon, Nov 16, 2020 at 4:19 PM Gary Gregory > wrote: > > > Hi All, > > > > The Jenkins build is failing in the JSON template module. > > > > Gary > > >

Re: Opt in for JMX server?

, Carter Kozak wrote: > > > > Sounds like a great idea to me. At work we use a different framework to > report metrics and generally disable jmx everywhere that allows us to do so. > > > > -ck > > > > On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote: > &

Jenkins build failure in JSON template module

Hi All, The Jenkins build is failing in the JSON template module. Gary

Fwd: Opt in for JMX server?

Hi All, I am starting to think that registering JMX MBeans after setting a config from the Core's logger context should be opt in and not done always. This would make startup (a little?) faster and "safer" since opening up JMX could be considered a security issue. At least we have a global opt o

Re: Identifying the set of events to be logged

Great write up Ralph! Gary PS: in the same vein, my "The Art of Test Driven Development: Understanding Logging" https://garygregory.wordpress.com/2015/09/10/the-art-of-test-driven-development-understanding-logging/ On Thu, Nov 12, 2020, 02:15 Ralph Goers wrote: > FYI - > > https://www.ralphgoer

Re: Test framework updates (was: vote thread)

le yet. > > On Mon, Nov 9, 2020 at 11:08 Gary Gregory wrote: > > > Matt & all: > > > > The last failing test I have on Windows fails, always, from the Maven > > command line or Eclipse: > > > > > > > [ERROR] Failure

Re: Test framework updates (was: vote thread)

e could be a bug that wasn’t encountered other than in CI related to > the test changes. > > -- Forwarded message - > From: Gary Gregory > Date: Sun, Nov 8, 2020 at 16:55 > Subject: Re: [VOTE] Release Log4j 2.14.0-rc1 > To: Apache Logging Developers List > >

Re: [VOTE] Release Log4j 2.14.0-rc1

hat could be considered a blocker. But if you can find and > fix the problems to the tests that would be appreciated. If not, I can try > to do it when I get spare cycles to run it in a VM. > > Ralph > > > On Nov 9, 2020, at 8:08 AM, Gary Gregory wrote: > > > > I found

Re: [VOTE] Release Log4j 2.14.0-rc1

ures before the 72 hour deadline passes. Until I can get my Windows build to pass, I am +0. Gary On Sun, Nov 8, 2020 at 5:54 PM Gary Gregory wrote: > On Sun, Nov 8, 2020 at 12:03 PM Matt Sicker wrote: > >> There’s a system property you can override in the tests to increase the &g

Re: [VOTE] Release Log4j 2.14.0-rc1

ts trying to cleanup. Not a blocker for the release. > > > > Ralph > > > > > On Nov 8, 2020, at 8:46 AM, Gary Gregory > wrote: > > > > > > From the git tags, my failures on Windows are: > > > > > > [INFO] > > > [ERROR] Failures:

Re: [VOTE] Release Log4j 2.14.0-rc1

dor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-8.0.272.10-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows On Sat, Nov 7, 2020 at 10:49 AM Gary Gregory wrote: > Hi All: &g

Re: TestConfigurator error

be unique: org.junit.jupiter:junit-jupiter-params:jar -> duplicate declaration of version (?) @ line 203, column 17 Gary On Sat, Nov 7, 2020 at 9:08 PM Gary Gregory wrote: > I am building from the RC tag and I tried 'mvn clean install' again and I > wonder if there is something wrong with my

Re: TestConfigurator error

8.272 on two different MacBook Pros both running macOS Catalina 10.15.7. I > don’t get any failing tests on any of them although on one machine I do get > sporadic test failures when running the site build. Jenkins builds on > Ubuntu and Windows. The Ubuntu build has no test failur

Re: Minimum Java version for Log4j 2 3.0?

The main hurdle for my day job is that Java 11 is not supported on all hardware platforms yet, specifically, some of our customers run our apps on IBM i/Series. That should not stop Log4j 3 to require Java 11 of course. It's just one data point. To make the migration even slower, even when Java 11

Re: [VOTE] Release Log4j 2.14.0-rc1

Hi All: I am getting: [ERROR] Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 116.204 s <<< FAILURE! - in org.apache.logging.log4j.core.config.TestConfigurator [ERROR] testReconfiguration Time elapsed: 15.044 s <<< FAILURE! java.lang.AssertionError: Configuration not reset Expe

Re: [VOTE] Release Log4j 2.14.0-rc1

Would you all mind replying with what OS, Java versions, build commands, an so on, you validated the release candidate? I think it would be good to know FTR what kind of coverage we got for a RC. Gary On Fri, Nov 6, 2020, 19:51 Volkan Yazıcı wrote: > +1 > > Thanks so much to everyone who put e

Re: Log4j 2.14.0 release status

/groups/public/ Vs. https://repository.apache.org/content/groups/snapshots/ Vs. https://repository.apache.org/content/groups/staging/ Is wrong... darn. Gary On Sun, Nov 1, 2020, 08:05 Gary Gregory wrote: > Very odd indeed, the public (non-snapshot) repository is full of snapshots: > >

Re: Log4j 2.14.0 release status

Very odd indeed, the public (non-snapshot) repository is full of snapshots: https://repository.apache.org/content/groups/public/org/apache/logging/log4j/log4j-core/ Gary On Sun, Nov 1, 2020, 00:51 Ralph Goers wrote: > I started the process of preparing for the release today. The Maven site > b

Re: Catching Throwable's in AsyncAppender worker

Hi, I am not sure it is wise to catch VM Errors like out of memory and stack overflow Errors... any thoughts on those? Gary On Wed, Oct 28, 2020, 16:05 Volkan Yazıcı wrote: > Hello, > > While logging, we sometimes notice that the entire logging infra comes to a > halt, even though the rest of t

Re: Disable dependabot

On Thu, Sep 17, 2020 at 8:49 PM Ralph Goers wrote: > I very much like all the emails due to dependabot. Furthermore, if it is > going to create 25 PRs then it also needs to create Jira issues and include > updates to changes.xml, otherwise it just creates a lot of work. > Furthermore, I have neve

Re: JsonTemplateLayout is ready to be shipped!

I think focusing on fixing the build should come before considering bringing in PRs or Jira issues. I think Matt stated we don't get a clean build ATM? Gary On Sat, Sep 12, 2020, 13:55 Ralph Goers wrote: > Yeah, I rely mostly on the automation but I run the build on my Mac > several times befor

Re: [apache/logging-log4j2] Bump jetty-util from 8.2.0.v20160908 to 9.4.31.v20200723 (#393)

t, allowing only a single entry? >2. right on the spot, allowing multiple entries? (e.g., Jackson example >above.) >3. prior to a release? > > Do we have a policy/convention for this? Unless there is, I'd vote for the > 3rd option. > > Kind regards? > > On We

Re: [apache/logging-log4j2] Bump jetty-util from 8.2.0.v20160908 to 9.4.31.v20200723 (#393)

Hi Volkan, May you please document this version change in changes.xml? Gary On Wed, Aug 26, 2020 at 4:59 AM Volkan Yazıcı wrote: > Merged #393 into > master. > > — > You are receiving this because you are subscribed to this thread. > Reply to

Re: [log4j] Too long file name when using TortoiseGIT.

I've run into the same issues, and decided to was simpler for me to allow long path names (on Windows): https://garygregory.wordpress.com/2019/09/13/enabling-long-path-names-on-windows/ Gary On Sun, Aug 23, 2020 at 8:10 AM Thorsten Schöning wrote: > Hi, > > this is a just a hint you might want

Re: [ANNOUNCE] Welcome our new committer, Stephen Webb!

Welcome aboard Stephen! Gary On Tue, Aug 11, 2020 at 3:41 PM Matt Sicker wrote: > Hi, > > It is my pleasure to announce to the community that Stephen Webb > has joined our ranks. > > Stephen has been contributing to log4cxx for a while and helping to > shape a new release, and we think that he'

Re: [Java] What's this extra copy of log4j-1.2-api?

Sure does :-( On Sun, Aug 9, 2020, 20:51 Matt Sicker wrote: > https://github.com/apache/logging-log4j2/tree/master/log4j-1.2-api/src/src > > Looks like some sort of mis-merge? > > -- > Matt Sicker >

Re: Json Template Layout

Hi Volkan, I look forward to more interactions with you in Log4j :-) Gary On Tue, Aug 4, 2020 at 2:48 AM Volkan Yazıcı wrote: > [Had a private chat with Ralph and the outcome of it is] I will see if I > can spare time for it this week. If not, I will let you know at the end of > the week. In t

Re: [apache/logging-log4j2] Bump springVersion from 3.2.18.RELEASE to 5.2.8.RELEASE (#391)

gt; > > On Wed, 29 Jul 2020 at 19:34, Ralph Goers > wrote: > >> > >> > >> > >>> On Jul 29, 2020, at 3:28 PM, Gary Gregory > wrote: > >>> > >>> On Wed, Jul 29, 2020 at 4:33 PM Matt Sicker wrote: > >>> > >

Re: [apache/logging-log4j2] Bump springVersion from 3.2.18.RELEASE to 5.2.8.RELEASE (#391)

On Wed, Jul 29, 2020 at 4:33 PM Matt Sicker wrote: > ICLAs aren't required for trivial contributions, though they are > required for committers. Are bots committers? Alternatively, if we > only merge PRs from the bot using the Merge button rather than the > @dependabot comment commands, then that

Re: [apache/logging-log4j2] Bump springVersion from 3.2.18.RELEASE to 5.2.8.RELEASE (#391)

"Does dependabot run a build with the proposed change to verify it works?" Just look at any PR, for example https://github.com/apache/logging-log4j2/pull/380, the PR follows the same workflow by running checks like a Travis build and/or a GitHub Actions build. In this case, the build was green. If

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

, and STRING could be a "type" only in the free-form-string sense (to my mind again.) So maybe this is a "format" choice of JSON vs. ANY_STRING/ 2c, Gary > Ralph > > > On Jul 14, 2020, at 7:43 AM, Gary Gregory > wrote: > > > > Hi All, > > > &

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

ure, or - Add something else like a String type ivar, which is what? A free-form string? Gary On Tue, Jul 14, 2020 at 10:24 AM Volkan Yazıcı wrote: > Adding a "String type" field sounds pretty generic to me. What do you > mean by "generic"? > > On Tue, Jul 14, 2020 at

Re: Adding type attribute to KeyValuePair (Was: Testing Json Template Layout)

On Tue, Jul 14, 2020 at 8:51 AM Volkan Yazıcı wrote: > May I add a "type" (of type String) parameter to KeyValuePair? Do you > have any objections? > Would we want to make this a generic? Gary > > On Mon, Jul 6, 2020 at 8:01 AM Ralph Goers > wrote: > > > > I finally got some time to start te

Re: Approving GitHub Dependabot PRs

y relatively heavy and adding more friction to > ship a release isn't a great solution either. > > -ck > > On Thu, Jul 2, 2020, at 08:30, Gary Gregory wrote: > > That's fine with me. You will want to update changes.xml to track > changes. > > >

Re: Approving GitHub Dependabot PRs

That's fine with me. You will want to update changes.xml to track changes. Gary On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı wrote: > Hello, > > 1. I will approve GitHub dependabot PRs that pass the CI tests. > 2. I will (blindly?) cherry-pick them onto release-2.x. > > Objections? > > Kind regards

Re: Migrating from Travis CI to GitHub Actions

In Travis-CI, you can say "java-ea", what is the equivalent in GitHub? Gary On Wed, Jul 1, 2020 at 9:33 AM Matt Sicker wrote: > I’ll take a look this week sometime. I’m in support of everything said > here, too. This should help the PR testing feature actually work again! > > On Wed, Jul 1, 202

Re: Enabling Dependabot in GitHub (#368)

Fine with me. Gary On Tue, Jun 30, 2020, 15:31 Volkan Yazıcı wrote: > Hello, > > #368[1] requests to add dependabot support. I am inclined to merge it. > Any objections? > > Kind regards. > > [1] https://github.com/apache/logging-log4j2/pull/368 >

Re: [log4j] Drop org.apache.logging.log4j.util.Supplier from master for 3.x

,Tri}Consumer classes as well? > > > > On Sun, May 24, 2020 at 11:21 PM Gary Gregory > wrote: > > > > > > Hi All, > > > > > > Can we drop org.apache.logging.log4j.util.Supplier from master for 3.x > and > > > replace its usage with java.util.function.Supplier? > > > > > > Gary >

Re: [log4j] Drop org.apache.logging.log4j.util.Supplier from master for 3.x

duplicate code (org.apache.logging.log4j.util.Supplier) for what is in Java 8 (java.util.function.Supplier) for 3.0 IMO. Gary > > Ralph > > > On May 24, 2020, at 2:57 PM, Volkan Yazıcı > wrote: > > > > May I second that with {Bi,Tri}Consumer classes as well? > > > >

[log4j] Drop org.apache.logging.log4j.util.Supplier from master for 3.x

Hi All, Can we drop org.apache.logging.log4j.util.Supplier from master for 3.x and replace its usage with java.util.function.Supplier? Gary

Re: [log4j] @PluginBuilderAttribute in master

gt; > On Sat, 23 May 2020 at 12:44, Gary Gregory wrote: > > > > Hi All: > > > > The deprecated @PluginBuilderAttribute in master does not seem to use its > > value(). > > > > Is that a bug and if not how am I supposed to port a builder that has an >

Re: Slack

Keep in mind that Slack should be considered as temporary storage, since you have to pay to access data past some threshold. Gary On Sat, May 23, 2020 at 4:39 PM Ralph Goers wrote: > FYI - there is a Logging channel in the ASF’s account on Slack. I have > Slack on all my devices, Matt and I cha

[log4j] @PluginBuilderAttribute in master

Hi All: The deprecated @PluginBuilderAttribute in master does not seem to use its value(). Is that a bug and if not how am I supposed to port a builder that has an ivar like: @PluginBuilderAttribute(value = "connection") @Required(message = "No connection string provided")

[log4j] Disable logging when disk space is low

Hi All: I have cases where our consultants at work want to turn on debug logging to help diagnose issues for long running tasks but... they do not want to crash a machine by making it run out of disk space. Do we foresee a FileAppender feature to disable logging if disk space falls below a certai

Re: [RESULT][VOTE] Release Log4j 2.13.3-rc1

Thank you Ralph! Gary On Wed, May 13, 2020, 23:12 Ralph Goers wrote: > This vote has passed with +1 votes from Gary Gregory, Matt Sicker, and > Ralph Goers. I will continue with the release process. > > Ralph > > >

Re: [VOTE] Release Log4j 2.13.3-rc1

+1 Tested 'mvn clean install' with: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp1252 OS

Re: [VOTE] Release Log4j Scala API 12.0-rc4

+1 but... while everything builds per the instructions I found, it would be nice to have something that tells you 'I ran tests and nothing blew up' ATM, it just feels like it compiled some stuff and who know if it works. - Not a blocker: On https://jvz.github.io/log4j-scala-site/#_download update

Re: [log4j][LOG4J2-2803] Getting back to the dependency injection story later this month

Hi Matt, Anyway you want to share this info is fine with me, especially since I've not paid attention to the branch. A web meeting would be great to ask questions, walk through code or pictures. Gary On Sat, May 2, 2020, 12:28 Matt Sicker wrote: > I lost a bit of momentum over the past few wee

Fwd: [log4j] InitTest fails in release-2.x

-- Forwarded message - From: Gary Gregory Date: Wed, Apr 29, 2020, 18:33 Subject: [log4j] InitTest fails in release-2.x To: Commons Developers List I always get this failure in release-2.x and 'mvn clean install -V': [INFO] Running org.apache.logging.log4j.core.uti

Re: [VOTE] Release Log4j 2.13.2-rc1

+1 Build 'mvn clean install' succeeds with: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp

Re: Release 2.13.2

Good news Ralph! Gary On Mon, Apr 20, 2020, 14:47 Ralph Goers wrote: > I have committed a fair number of changes and we have reason to get a > release out fairly quickly. I am hopeful I can do it this week, possibly > even tonight. > > If you have something that needs to be committed please let

Re: [log4j] Makr Java 8 dep with version bump

17, 2020, at 08:49, Gary Gregory wrote: > > Now that 2.x is on Java 8 (aka "The Ocho > > <https://www.youtube.com/watch?v=8414uArsBOs>"), I think the next > release > > label should be 2.14 instead of 2.13.2. > > > > Gary > > >

[log4j] Makr Java 8 dep with version bump

Now that 2.x is on Java 8 (aka "The Ocho "), I think the next release label should be 2.14 instead of 2.13.2. Gary

[log4j] Duplicate appenders in XML config

Hi All: I just had a case where I had two appenders with the same name in my XML config. Would it make sense to issue a WARN event to the status logger in this case? Gary

Re: [VOTE] Move Log4net to dormant state

+1 Gary On Sun, Mar 29, 2020 at 6:23 PM Ralph Goers wrote: > Seeing as there have been no volunteers after my last message regarding > Log4Net, I propose that it be moved to a dormant status. This would simply > entail: > 1. Create a tag of the source. > 2. Create an archive of the source to b

Roadmap?

Hi All: I see a current burst of activity on the commit list. I have not looked closely. Can anyone provide a big picture of what is happening? Thank you, Gary

Re: [Discuss] Retire Log4net to the attic.

I'm not foreseeing needing or helping on this one, so the attic is OK by me. Gary On Sat, Mar 21, 2020 at 8:15 PM Ralph Goers wrote: > The PMC has struggled for several years trying to attract new developers > to the project and has not succeeded. The latest discussion was last > October where

Re: [log4j] getLogger(String... name)?

Java 8 to the rescue somewhat: loggerContext.getLogger(String.join(".", MY_ROOT_NAME, "foo", "bar")); loggerContext.getLogger(String.join(".", MY_ROOT_NAME, "boo", "baz")); Gary On Tue, Mar 10, 2020 at 4:33 PM Gary Gregory wro

Re: Dependency-free JsonTemplateLayout

Hi All: If this is in master, it should go into a JSON module, existing or new but not core. FYI: Dependencies or not, the current JSON layout is in master in log4j-layout-jackson-json. One of the complaints I've heard over the years is that log4j-core is too "big" at 1.6 MB, not to speak of the t

Re: TimeFilterTest

+1 Gary On Wed, Mar 11, 2020 at 12:55 AM Ralph Goers wrote: > I have modified TimeFilter to properly account for the change from > daylight saving time to standard time and vice-versa. I also modified it to > handle a start time on the day before the end time. I have a suspicion > that this fi

Re: Emoji in PatternLayout?

I do not think your file.encoding sys prop matters, see the Javadoc for the Properties class. Gary On Tue, Mar 10, 2020, 20:22 Christopher wrote: > That was my guess, but I don't see how this could happen since my JVM > default encoding, my terminal, System.getProperty("file.encoding"), > Syste

Re: Emoji in PatternLayout?

I think only new Java versions parse prop files as utf8 Gary On Tue, Mar 10, 2020, 20:17 Carter Kozak wrote: > I wonder if the log4j2.properties file is being parsed as ISO-8859-1 > rather than UTF-8, so we're not reading the cat properly? > > On Tue, Mar 10, 2020, at 20:04, Christopher wrote:

Re: [log4j] getLogger(String... name)?

On Tue, Mar 10, 2020 at 12:06 PM Ralph Goers wrote: > > > > On Mar 10, 2020, at 8:40 AM, Gary Gregory > wrote: > > > > My POV has nothing to do with performance, more about code clarity. > > Building strings 'manually' can be error/typo prone, you can

Re: [log4j] getLogger(String... name)?

, at 10:32, Ralph Goers wrote: > >> Cleaner? You changed a plus sign to a comma and turned the > concatenation from happening at compile time to runtime. Even if you could > I would argue you shouldn’t. > >> > >> Ralph > >> > >>> On Mar 10, 2020, at

Re: [log4j] getLogger(String... name)?

gerContext.getLogger(ROOT_LOGGER_NAME, CLIENT, RESPONSE); loggerContext.getLogger(ROOT_LOGGER_NAME, SERVER, REQUEST); loggerContext.getLogger(ROOT_LOGGER_NAME, SERVER, RESPONSE ); Gary > Ralph > > > On Mar 9, 2020, at 7:51 AM, Gary Gregory wrote: > > > > Hi All: > > > &

[log4j] getLogger(String... name)?

Hi All: Any thought for or against adding the API 'getLogger(String... name)' which would build a hierarchical logger name. These would be equivalent: - getLogger("com.a.b.c") - getLogger("com", "a", "b", "c") Gary

Re: Modularization

Is this worthy doing in 2.0? In 3 we can do whatever we want IMO. Gary On Sat, Mar 7, 2020, 23:24 Ralph Goers wrote: > I started looking at log4j-core in master today with an eye towards > creating the module-info.java file. As I went through it I realized we > would have to expose almost all o

Re: shade+relocate policy & parsing JSON

Shading Antlr or another parser, generated or in a library, is out of bounds IMO. Writing our own JSON parser is not a good idea either, it's not something a logging library should be in the business of maintaining, IMO again. It just feels to me like you just want jam your new module in core at an

Re: Towards 3.0 (was Re: Filtering out excessive log payloads)

ic since none of this has much to do with the > questions that were asked. > > > > On Mar 3, 2020, at 6:52 AM, Gary Gregory wrote: > > > > Hi All (I'm back from vacation today): > > > > For 3.0, my thoughts are that the 'core' should only inclu

Re: Filtering out excessive log payloads

a 2.X release. Would you mind elaborating on this, > > please? > > > > On Tue, Mar 3, 2020 at 2:52 PM Gary Gregory > > wrote: > > > > > > Hi All (I'm back from vacation today): > > > > > > For 3.0, my thoughts are that the '

Re: Filtering out excessive log payloads

Hi All (I'm back from vacation today): For 3.0, my thoughts are that the 'core' should only include infrastructure used to implement actual appenders and layouts (and filters and so on.) My experience with the products that use Log4j 1 and 2 at work is: - Use the Console appender by default. - No

Re: [VOTE] Release Log4j 2.13.1-rc2

+1 My review is based on the git tag. Running 'mvn -V clean package' OK with: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default l

Re: [VOTE] Release Log4j 2.13.1-rc1

ception at org.apache.logging.log4j.core.impl.ThrowableProxyTest.testLogStackTraceWithClassLoaderThatWithCauseSecurityException(ThrowableProxyTest.java:211) But from Eclipse's git HEAD of 2.x-release, it passes. Thoughts? Gary On Mon, Feb 24, 2020 at 11:14 AM Gary Gregory wrote: > TL;DR: > > > My review is based on the git tag > > - Apache RAT check OK. > - C

Re: [VOTE] Release Log4j 2.13.1-rc1

TL;DR: My review is based on the git tag - Apache RAT check OK. - Can't find a way to run Apache CLIRR from the command line, so I am relying on the site https://rgoers.github.io/log4j2-site -- Expected missing classes in Log4j 1.2 compatibility layer -- API report OK, but the text refers to org

Re: [VOTE] Release Log4j 2.13.1-rc1

On Mon, Feb 24, 2020 at 12:52 AM Ralph Goers wrote: > This is a vote to release Log4j 2.13.1, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... > > The vote will

Re: [VOTE] Release Log4j Scala API 12.0-rc2

The v12.0 tag can't be right. My understanding is that each RC MUST have its own tag so we can track what we vote and have voted on, I had forgotten that in RC1. Once a vote passes you can copy the tag to rel/whatever; since "rel/" is a special place for Apache tags that is 'locked down'. Or. is my

Re: [VOTE] Release Log4j Scala API 12.0-rc1

On Sat, Feb 8, 2020 at 2:27 PM Matt Sicker wrote: > I'm closing this vote to make a new release candidate. Thanks for the > checks everyone! > Good luck :-) G > > On Sun, 2 Feb 2020 at 07:59, Gary Gregory wrote: > > > > Housekeeping: > > > > The

Re: Upcoming release candidates

on > what state its website contents are when I try it out. > Are you feeling generous enough with your time to RC Log4j2 2.13.1? ;-) Gary > > On Sat, 1 Feb 2020 at 14:14, Gary Gregory wrote: > > > > Matt, > > > > If have Kotlin specific instructions I am happ

Re: Necessity of multiple JDKs for build

Compiling on Java 9 or above will break Java 8 clients if we have code that complies against Buffer classes. Gary On Tue, Feb 4, 2020, 08:49 Volkan Yazıcı wrote: > Okay. I've created a ticket[1] for this. Note that once this is done, > migration to GitHub Actions[2] becomes straightforward. (Ma

Re: [jira] [Created] (LOG4J2-2771) Remove need for multiple JDKs during build

The problem is that this will mess up Java 8 clients when code compiled against various Buffer classes runs due to methods added or tweaked in Java 9's Buffer classes. Gary Gary On Tue, Feb 4, 2020, 08:46 Volkan Yazici (Jira) wrote: > Volkan Yazici created LOG4J2-2771: > --

Re: Best practices for editing the manual

You can short circuit the tests with -DskipTests Gary On Tue, Feb 4, 2020, 04:29 Volkan Yazıcı wrote: > Hello, > > I have a couple of questions regarding working on the manual. I will > appreciate if you can spare some time to help me out with them: > > 1. What is the easiest Maven command just

<    2   3   4   5   6   7   8   9   10   11   >