Fix windows build on master (via Tim Perry)

Hello, Tim has submitted a PR to fix the Windows build on master in February. In essence, it introduces prepareToStop() to StatusLogger. IIRC, there was a discussion regarding this subject in the mailing list. I think I have missed that. The PR l

Re: Fix windows build on master (via Tim Perry)

Volkan, I should probably withdraw that pull request. It assumes that the status logger is not a singleton. However, status logger is a singleton and so this is a problem. I’ve implemented to changes which tracks the different status logger listeners by the context name. There are still a co

Re: Fix windows build on master (via Tim Perry)

Tim, Go ahead and create a PR and note that it still has unit test failures that need to be looked into. I can’t guarantee one of us will get to it before you but at least that way we might be able to. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > Volkan, > > I should probably w

Re: Fix windows build on master (via Tim Perry)

Should I just push the changes to pull request 469? That way there is a bit of history. On Wed, Apr 28, 2021 at 8:26 AM Ralph Goers wrote: > Tim, > > Go ahead and create a PR and note that it still has unit test failures > that need to be looked into. I can’t guarantee one of us will get to it >

Re: Fix windows build on master (via Tim Perry)

That would be up to you. If you have been working on the same branch there shouldn’t be a problem. But if it is going to cause merge conflicts then I wouldn’t bother as you can just link to the prior PR for the history. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > > > It assume

Re: Fix windows build on master (via Tim Perry)

I pushed 46f7b08288e1f8843d293bb75950a8b466854ba6 to pull 469. My recollection is that there was a test failing where I thought the problem was the test, not the code. The test was checking to see if the log file was gone inside the @Test and I don't think that is valid. I was meaning to ask someo

Re: Fix windows build on master (via Tim Perry)

After more carefully reading the code and unit tests, I have come to the conclusion that the interaction between context-specific listeners and the StatusLogger lifecycle need to be rethought. My approach, at best, would have arrived at a kludge that worked but made the code difficult to maintain.

Re: Fix windows build on master (via Tim Perry)

I created a pull request which fixes the windows build. I have tested on windows 10 using maven 3.6.3 and Zulu's OpenJDK 11 build and it works. I noticed the automatic test framework that ran for the pull request failed. https://github.com/apache/logging-log4j2/pull/491 This request adds an annota