RE: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Denis Petker
Hi Davyd Thanks for the quick response! Agreed, I also don't think, that the username doesn't change for a process. If we say, that the username isn't going to change for a process, I think there is no reason in printing the user name per log statement. However, the ticket LOG4NET-205 has been

RE: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Davyd McColl
Hi Denis I would imagine that the use case is for shared logging config between processes. I think that the issue could be resolved by some caching in LoggingEvent.TryGetCurrentUserName (LoggingEvent.cs:927).  I was just going to provide guidance, but it's probably quicker to just patch and te

Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Dominik Psenner
I believe the caching has already been implemented but don't have any references to mention right now. On Tue, 22 Feb 2022 at 09:56, Denis Petker wrote: > Hi Davyd > > Thanks for the quick response! Agreed, I also don't think, that the > username doesn't change for a process. > If we say, that t

Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Vladimir Vedeneev
Sorry if will be saying dumb things here, as I've seen that several years ago and have no time to review that now; but maybe that'll ring the bell for somebody I thought that UserName could be related to user name from principal (thus basically anything set in code - and can be easily different fo

Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Davyd McColl
Hi Vladimir That's a very good point - the thread could be impersonating a user (https://docs.microsoft.com/en-us/dotnet/api/system.security.principal.windowsidentity.getcurrent),   and I could imagine this being the user for an asp.net request if it's tied into windows identities. It is not the

RE: Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Denis Petker
og4net - performance hit because UserName is fetched always Hi Vladimir That's a very good point - the thread could be impersonating a user (https://docs.microsoft.com/en-us/dotnet/api/system.security.principal.windowsidentity.getcurrent), and I could imagine this being the user for an asp.

Re: Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Vladimir Vedeneev
ent thread in the mailing list, rather than creating a > new thread on each response? > > Thank you guys > Denis > > > From: Davyd McColl > Sent: Tuesday, February 22, 2022 3:29 PM > To: dev@logging.apache.org > Cc: Petker Denis 8BM3 > Subject: *EXT* Re: [Newsle

Re: Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-22 Thread Davyd McColl
BM3 mailto:denis.pet...@rohde-schwarz.com]> Subject: *EXT* Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always Hi Vladimir That's a very good point - the thread could be impersonating a user (https://docs.microsoft.com/en-us/dotnet/api/system.security.principal.wind

RE: [Newsletter] Re: Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always

2022-02-23 Thread Denis Petker
for the bad responsivness From: Davyd McColl Sent: Wednesday, February 23, 2022 7:51 AM To: Vladimir Vedeneev ; dev@logging.apache.org Cc: Petker Denis 8BM3 Subject: *EXT* [Newsletter] Re: Re: [Newsletter] Re: log4net - performance hit because UserName is fetched always Hi Vladimir (to clarify